* [PATCH 01/27] clk: sophgo: cv18xx-ip: convert from divider_round_rate() to divider_determine_rate()
2026-01-08 21:16 [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Brian Masney
@ 2026-01-08 21:16 ` Brian Masney
2026-01-08 21:16 ` [PATCH 17/27] clk: sophgo: sg2042-clkgen: " Brian Masney
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Brian Masney @ 2026-01-08 21:16 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-kernel, Brian Masney, Chen Wang, Inochi Amaoto,
sophgo
The divider_round_rate() function is now deprecated, so let's migrate
to divider_determine_rate() instead so that this deprecated API can be
removed. Also go ahead and convert all of the driver from round rate
type to determine rate that accepts a 'struct clk_rate_request' to
simplify the overall driver code.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Chen Wang <unicorn_wang@outlook.com>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: sophgo@lists.linux.dev
---
drivers/clk/sophgo/clk-cv18xx-ip.c | 154 ++++++++++++++++++++-----------------
1 file changed, 85 insertions(+), 69 deletions(-)
diff --git a/drivers/clk/sophgo/clk-cv18xx-ip.c b/drivers/clk/sophgo/clk-cv18xx-ip.c
index c2b58faf0938b7d537dc3a81aef59c549b9c9c79..e936e315400393662a24e0d0189f7f74e01fa586 100644
--- a/drivers/clk/sophgo/clk-cv18xx-ip.c
+++ b/drivers/clk/sophgo/clk-cv18xx-ip.c
@@ -152,28 +152,27 @@ static u32 div_helper_get_clockdiv(struct cv1800_clk_common *common,
return clockdiv;
}
-static u32 div_helper_round_rate(struct cv1800_clk_regfield *div,
- struct clk_hw *hw, struct clk_hw *parent,
- unsigned long rate, unsigned long *prate)
+static int div_helper_determine_rate(struct cv1800_clk_regfield *div,
+ struct clk_hw *hw,
+ struct clk_rate_request *req)
{
if (div->width == 0) {
if (div->initval <= 0)
- return DIV_ROUND_UP_ULL(*prate, 1);
+ req->rate = DIV_ROUND_UP_ULL(req->best_parent_rate, 1);
else
- return DIV_ROUND_UP_ULL(*prate, div->initval);
+ req->rate = DIV_ROUND_UP_ULL(req->best_parent_rate, div->initval);
+
+ return 0;
}
- return divider_round_rate_parent(hw, parent, rate, prate, NULL,
- div->width, div->flags);
+ return divider_determine_rate(hw, req, NULL, div->width, div->flags);
}
-static long div_round_rate(struct clk_hw *parent, unsigned long *parent_rate,
- unsigned long rate, int id, void *data)
+static int do_div_determine_rate(struct clk_rate_request *req, int id, void *data)
{
struct cv1800_clk_div *div = data;
- return div_helper_round_rate(&div->div, &div->common.hw, parent,
- rate, parent_rate);
+ return div_helper_determine_rate(&div->div, &div->common.hw, req);
}
static bool div_is_better_rate(struct cv1800_clk_common *common,
@@ -188,53 +187,60 @@ static bool div_is_better_rate(struct cv1800_clk_common *common,
static int mux_helper_determine_rate(struct cv1800_clk_common *common,
struct clk_rate_request *req,
- long (*round)(struct clk_hw *,
- unsigned long *,
- unsigned long,
- int,
- void *),
+ int (*round)(struct clk_rate_request *,
+ int,
+ void *),
void *data)
{
unsigned long best_parent_rate = 0, best_rate = 0;
struct clk_hw *best_parent, *hw = &common->hw;
unsigned int i;
+ int ret;
if (clk_hw_get_flags(hw) & CLK_SET_RATE_NO_REPARENT) {
- unsigned long adj_parent_rate;
+ struct clk_rate_request tmp_req = *req;
best_parent = clk_hw_get_parent(hw);
- best_parent_rate = clk_hw_get_rate(best_parent);
+ tmp_req.best_parent_hw = best_parent;
+ tmp_req.best_parent_rate = clk_hw_get_rate(best_parent);
- best_rate = round(best_parent, &adj_parent_rate,
- req->rate, -1, data);
+ ret = round(&tmp_req, -1, data);
+ if (ret)
+ return ret;
+
+ best_parent_rate = tmp_req.best_parent_rate;
+ best_rate = tmp_req.rate;
goto find;
}
for (i = 0; i < clk_hw_get_num_parents(hw); i++) {
- unsigned long tmp_rate, parent_rate;
+ struct clk_rate_request tmp_req = *req;
struct clk_hw *parent;
parent = clk_hw_get_parent_by_index(hw, i);
if (!parent)
continue;
- parent_rate = clk_hw_get_rate(parent);
+ tmp_req.best_parent_hw = parent;
+ tmp_req.best_parent_rate = clk_hw_get_rate(parent);
- tmp_rate = round(parent, &parent_rate, req->rate, i, data);
+ ret = round(&tmp_req, i, data);
+ if (ret)
+ continue;
- if (tmp_rate == req->rate) {
+ if (tmp_req.rate == req->rate) {
best_parent = parent;
- best_parent_rate = parent_rate;
- best_rate = tmp_rate;
+ best_parent_rate = tmp_req.best_parent_rate;
+ best_rate = tmp_req.rate;
goto find;
}
if (div_is_better_rate(common, req->rate,
- tmp_rate, best_rate)) {
+ tmp_req.rate, best_rate)) {
best_parent = parent;
- best_parent_rate = parent_rate;
- best_rate = tmp_rate;
+ best_parent_rate = tmp_req.best_parent_rate;
+ best_rate = tmp_req.rate;
}
}
@@ -254,7 +260,7 @@ static int div_determine_rate(struct clk_hw *hw,
struct cv1800_clk_div *div = hw_to_cv1800_clk_div(hw);
return mux_helper_determine_rate(&div->common, req,
- div_round_rate, div);
+ do_div_determine_rate, div);
}
static unsigned long div_recalc_rate(struct clk_hw *hw,
@@ -301,24 +307,28 @@ hw_to_cv1800_clk_bypass_div(struct clk_hw *hw)
return container_of(div, struct cv1800_clk_bypass_div, div);
}
-static long bypass_div_round_rate(struct clk_hw *parent,
- unsigned long *parent_rate,
- unsigned long rate, int id, void *data)
+static int do_bypass_div_determine_rate(struct clk_rate_request *req, int id,
+ void *data)
{
struct cv1800_clk_bypass_div *div = data;
if (id == -1) {
- if (cv1800_clk_checkbit(&div->div.common, &div->bypass))
- return *parent_rate;
- else
- return div_round_rate(parent, parent_rate, rate,
- -1, &div->div);
+ if (cv1800_clk_checkbit(&div->div.common, &div->bypass)) {
+ req->rate = req->best_parent_rate;
+
+ return 0;
+ }
+
+ return do_div_determine_rate(req, -1, &div->div);
}
- if (id == 0)
- return *parent_rate;
+ if (id == 0) {
+ req->rate = req->best_parent_rate;
+
+ return 0;
+ }
- return div_round_rate(parent, parent_rate, rate, id - 1, &div->div);
+ return do_div_determine_rate(req, id - 1, &div->div);
}
static int bypass_div_determine_rate(struct clk_hw *hw,
@@ -327,7 +337,7 @@ static int bypass_div_determine_rate(struct clk_hw *hw,
struct cv1800_clk_bypass_div *div = hw_to_cv1800_clk_bypass_div(hw);
return mux_helper_determine_rate(&div->div.common, req,
- bypass_div_round_rate, div);
+ do_bypass_div_determine_rate, div);
}
static unsigned long bypass_div_recalc_rate(struct clk_hw *hw,
@@ -414,13 +424,11 @@ static int mux_is_enabled(struct clk_hw *hw)
return cv1800_clk_checkbit(&mux->common, &mux->gate);
}
-static long mux_round_rate(struct clk_hw *parent, unsigned long *parent_rate,
- unsigned long rate, int id, void *data)
+static int do_mux_determine_rate(struct clk_rate_request *req, int id, void *data)
{
struct cv1800_clk_mux *mux = data;
- return div_helper_round_rate(&mux->div, &mux->common.hw, parent,
- rate, parent_rate);
+ return div_helper_determine_rate(&mux->div, &mux->common.hw, req);
}
static int mux_determine_rate(struct clk_hw *hw,
@@ -429,7 +437,7 @@ static int mux_determine_rate(struct clk_hw *hw,
struct cv1800_clk_mux *mux = hw_to_cv1800_clk_mux(hw);
return mux_helper_determine_rate(&mux->common, req,
- mux_round_rate, mux);
+ do_mux_determine_rate, mux);
}
static unsigned long mux_recalc_rate(struct clk_hw *hw,
@@ -512,24 +520,28 @@ hw_to_cv1800_clk_bypass_mux(struct clk_hw *hw)
return container_of(mux, struct cv1800_clk_bypass_mux, mux);
}
-static long bypass_mux_round_rate(struct clk_hw *parent,
- unsigned long *parent_rate,
- unsigned long rate, int id, void *data)
+static int do_bypass_mux_determine_rate(struct clk_rate_request *req, int id,
+ void *data)
{
struct cv1800_clk_bypass_mux *mux = data;
if (id == -1) {
- if (cv1800_clk_checkbit(&mux->mux.common, &mux->bypass))
- return *parent_rate;
- else
- return mux_round_rate(parent, parent_rate, rate,
- -1, &mux->mux);
+ if (cv1800_clk_checkbit(&mux->mux.common, &mux->bypass)) {
+ req->rate = req->best_parent_rate;
+
+ return 0;
+ }
+
+ return do_mux_determine_rate(req, -1, &mux->mux);
}
- if (id == 0)
- return *parent_rate;
+ if (id == 0) {
+ req->rate = req->best_parent_rate;
+
+ return 0;
+ }
- return mux_round_rate(parent, parent_rate, rate, id - 1, &mux->mux);
+ return do_mux_determine_rate(req, id - 1, &mux->mux);
}
static int bypass_mux_determine_rate(struct clk_hw *hw,
@@ -538,7 +550,7 @@ static int bypass_mux_determine_rate(struct clk_hw *hw,
struct cv1800_clk_bypass_mux *mux = hw_to_cv1800_clk_bypass_mux(hw);
return mux_helper_determine_rate(&mux->mux.common, req,
- bypass_mux_round_rate, mux);
+ do_bypass_mux_determine_rate, mux);
}
static unsigned long bypass_mux_recalc_rate(struct clk_hw *hw,
@@ -639,27 +651,31 @@ static int mmux_is_enabled(struct clk_hw *hw)
return cv1800_clk_checkbit(&mmux->common, &mmux->gate);
}
-static long mmux_round_rate(struct clk_hw *parent, unsigned long *parent_rate,
- unsigned long rate, int id, void *data)
+static int do_mmux_determine_rate(struct clk_rate_request *req, int id, void *data)
{
struct cv1800_clk_mmux *mmux = data;
s8 div_id;
if (id == -1) {
- if (cv1800_clk_checkbit(&mmux->common, &mmux->bypass))
- return *parent_rate;
+ if (cv1800_clk_checkbit(&mmux->common, &mmux->bypass)) {
+ req->rate = req->best_parent_rate;
+
+ return 0;
+ }
id = mmux_get_parent_id(mmux);
}
div_id = mmux->parent2sel[id];
- if (div_id < 0)
- return *parent_rate;
+ if (div_id < 0) {
+ req->rate = req->best_parent_rate;
+
+ return 0;
+ }
- return div_helper_round_rate(&mmux->div[div_id],
- &mmux->common.hw, parent,
- rate, parent_rate);
+ return div_helper_determine_rate(&mmux->div[div_id], &mmux->common.hw,
+ req);
}
static int mmux_determine_rate(struct clk_hw *hw,
@@ -668,7 +684,7 @@ static int mmux_determine_rate(struct clk_hw *hw,
struct cv1800_clk_mmux *mmux = hw_to_cv1800_clk_mmux(hw);
return mux_helper_determine_rate(&mmux->common, req,
- mmux_round_rate, mmux);
+ do_mmux_determine_rate, mmux);
}
static unsigned long mmux_recalc_rate(struct clk_hw *hw,
--
2.52.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 17/27] clk: sophgo: sg2042-clkgen: convert from divider_round_rate() to divider_determine_rate()
2026-01-08 21:16 [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Brian Masney
2026-01-08 21:16 ` [PATCH 01/27] clk: sophgo: cv18xx-ip: convert from divider_round_rate() to divider_determine_rate() Brian Masney
@ 2026-01-08 21:16 ` Brian Masney
2026-01-12 2:57 ` Chen Wang
2026-01-10 19:11 ` (subset) [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Bjorn Andersson
` (3 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Brian Masney @ 2026-01-08 21:16 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-kernel, Brian Masney, Chen Wang, Inochi Amaoto,
sophgo
The divider_round_rate() function is now deprecated, so let's migrate
to divider_determine_rate() instead so that this deprecated API can be
removed.
Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:
req->rate = divider_round_rate(...)
This is invalid in the case when an error occurs since it can set the
rate to a negative value.
Note that this commit also removes a debugging message that's not really
needed.
Fixes: 9a3b6993613d ("clk: sophgo: sg2042-clkgen: convert from round_rate() to determine_rate()")
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
To: Chen Wang <unicorn_wang@outlook.com>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: sophgo@lists.linux.dev
---
drivers/clk/sophgo/clk-sg2042-clkgen.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/clk/sophgo/clk-sg2042-clkgen.c b/drivers/clk/sophgo/clk-sg2042-clkgen.c
index 683661b71787c9e5428b168502f6fbb30ea9f7da..9725ac4e050a4e6afd3fd50241fbd2fc105a31ca 100644
--- a/drivers/clk/sophgo/clk-sg2042-clkgen.c
+++ b/drivers/clk/sophgo/clk-sg2042-clkgen.c
@@ -180,7 +180,6 @@ static int sg2042_clk_divider_determine_rate(struct clk_hw *hw,
struct clk_rate_request *req)
{
struct sg2042_divider_clock *divider = to_sg2042_clk_divider(hw);
- unsigned long ret_rate;
u32 bestdiv;
/* if read only, just return current value */
@@ -191,17 +190,13 @@ static int sg2042_clk_divider_determine_rate(struct clk_hw *hw,
bestdiv = readl(divider->reg) >> divider->shift;
bestdiv &= clk_div_mask(divider->width);
}
- ret_rate = DIV_ROUND_UP_ULL((u64)req->best_parent_rate, bestdiv);
- } else {
- ret_rate = divider_round_rate(hw, req->rate, &req->best_parent_rate, NULL,
- divider->width, divider->div_flags);
- }
+ req->rate = DIV_ROUND_UP_ULL((u64)req->best_parent_rate, bestdiv);
- pr_debug("--> %s: divider_round_rate: val = %ld\n",
- clk_hw_get_name(hw), ret_rate);
- req->rate = ret_rate;
+ return 0;
+ }
- return 0;
+ return divider_determine_rate(hw, req, NULL, divider->width,
+ divider->div_flags);
}
static int sg2042_clk_divider_set_rate(struct clk_hw *hw,
--
2.52.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 17/27] clk: sophgo: sg2042-clkgen: convert from divider_round_rate() to divider_determine_rate()
2026-01-08 21:16 ` [PATCH 17/27] clk: sophgo: sg2042-clkgen: " Brian Masney
@ 2026-01-12 2:57 ` Chen Wang
2026-01-12 17:27 ` Brian Masney
0 siblings, 1 reply; 9+ messages in thread
From: Chen Wang @ 2026-01-12 2:57 UTC (permalink / raw)
To: Brian Masney, Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-kernel, Inochi Amaoto, sophgo
On 1/9/2026 5:16 AM, Brian Masney wrote:
> The divider_round_rate() function is now deprecated, so let's migrate
> to divider_determine_rate() instead so that this deprecated API can be
> removed.
>
> Note that when the main function itself was migrated to use
> determine_rate, this was mistakenly converted to:
>
> req->rate = divider_round_rate(...)
>
> This is invalid in the case when an error occurs since it can set the
> rate to a negative value.
>
> Note that this commit also removes a debugging message that's not really
> needed.
>
> Fixes: 9a3b6993613d ("clk: sophgo: sg2042-clkgen: convert from round_rate() to determine_rate()")
> Signed-off-by: Brian Masney <bmasney@redhat.com>
>
> ---
> To: Chen Wang <unicorn_wang@outlook.com>
> To: Inochi Amaoto <inochiama@gmail.com>
> Cc: sophgo@lists.linux.dev
> ---
> drivers/clk/sophgo/clk-sg2042-clkgen.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/clk/sophgo/clk-sg2042-clkgen.c b/drivers/clk/sophgo/clk-sg2042-clkgen.c
> index 683661b71787c9e5428b168502f6fbb30ea9f7da..9725ac4e050a4e6afd3fd50241fbd2fc105a31ca 100644
> --- a/drivers/clk/sophgo/clk-sg2042-clkgen.c
> +++ b/drivers/clk/sophgo/clk-sg2042-clkgen.c
> @@ -180,7 +180,6 @@ static int sg2042_clk_divider_determine_rate(struct clk_hw *hw,
> struct clk_rate_request *req)
> {
> struct sg2042_divider_clock *divider = to_sg2042_clk_divider(hw);
> - unsigned long ret_rate;
> u32 bestdiv;
>
> /* if read only, just return current value */
> @@ -191,17 +190,13 @@ static int sg2042_clk_divider_determine_rate(struct clk_hw *hw,
> bestdiv = readl(divider->reg) >> divider->shift;
> bestdiv &= clk_div_mask(divider->width);
> }
> - ret_rate = DIV_ROUND_UP_ULL((u64)req->best_parent_rate, bestdiv);
> - } else {
> - ret_rate = divider_round_rate(hw, req->rate, &req->best_parent_rate, NULL,
> - divider->width, divider->div_flags);
> - }
> + req->rate = DIV_ROUND_UP_ULL((u64)req->best_parent_rate, bestdiv);
>
> - pr_debug("--> %s: divider_round_rate: val = %ld\n",
> - clk_hw_get_name(hw), ret_rate);
> - req->rate = ret_rate;
> + return 0;
> + }
>
> - return 0;
> + return divider_determine_rate(hw, req, NULL, divider->width,
> + divider->div_flags);
> }
>
> static int sg2042_clk_divider_set_rate(struct clk_hw *hw,
Tested-by: Chen Wang <unicorn_wang@outlook.com>
Reviewed-by: Chen Wang <unicorn_wang@outlook.com>
BTW: I have a question about the base-commit on which your patch series
is based. Could you please tell me where I can find this base-commit?
I'm asking this because I found that for the changes in [25/27]
phy-j721e-wiz, if I'm based on the latest upstream master, I can't
successfully apply this patch.
So, in my testing, I'm based on 6.19-rc1 and haven't picked [25/27].
Thanks,
Chen
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 17/27] clk: sophgo: sg2042-clkgen: convert from divider_round_rate() to divider_determine_rate()
2026-01-12 2:57 ` Chen Wang
@ 2026-01-12 17:27 ` Brian Masney
0 siblings, 0 replies; 9+ messages in thread
From: Brian Masney @ 2026-01-12 17:27 UTC (permalink / raw)
To: Chen Wang
Cc: Michael Turquette, Stephen Boyd, linux-clk, linux-kernel,
Inochi Amaoto, sophgo
Hi Chen,
On Mon, Jan 12, 2026 at 10:57:17AM +0800, Chen Wang wrote:
>
> On 1/9/2026 5:16 AM, Brian Masney wrote:
> > The divider_round_rate() function is now deprecated, so let's migrate
> > to divider_determine_rate() instead so that this deprecated API can be
> > removed.
> >
> > Note that when the main function itself was migrated to use
> > determine_rate, this was mistakenly converted to:
> >
> > req->rate = divider_round_rate(...)
> >
> > This is invalid in the case when an error occurs since it can set the
> > rate to a negative value.
> >
> > Note that this commit also removes a debugging message that's not really
> > needed.
> >
> > Fixes: 9a3b6993613d ("clk: sophgo: sg2042-clkgen: convert from round_rate() to determine_rate()")
> > Signed-off-by: Brian Masney <bmasney@redhat.com>
> >
> > ---
> > To: Chen Wang <unicorn_wang@outlook.com>
> > To: Inochi Amaoto <inochiama@gmail.com>
> > Cc: sophgo@lists.linux.dev
> > ---
> > drivers/clk/sophgo/clk-sg2042-clkgen.c | 15 +++++----------
> > 1 file changed, 5 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/clk/sophgo/clk-sg2042-clkgen.c b/drivers/clk/sophgo/clk-sg2042-clkgen.c
> > index 683661b71787c9e5428b168502f6fbb30ea9f7da..9725ac4e050a4e6afd3fd50241fbd2fc105a31ca 100644
> > --- a/drivers/clk/sophgo/clk-sg2042-clkgen.c
> > +++ b/drivers/clk/sophgo/clk-sg2042-clkgen.c
> > @@ -180,7 +180,6 @@ static int sg2042_clk_divider_determine_rate(struct clk_hw *hw,
> > struct clk_rate_request *req)
> > {
> > struct sg2042_divider_clock *divider = to_sg2042_clk_divider(hw);
> > - unsigned long ret_rate;
> > u32 bestdiv;
> > /* if read only, just return current value */
> > @@ -191,17 +190,13 @@ static int sg2042_clk_divider_determine_rate(struct clk_hw *hw,
> > bestdiv = readl(divider->reg) >> divider->shift;
> > bestdiv &= clk_div_mask(divider->width);
> > }
> > - ret_rate = DIV_ROUND_UP_ULL((u64)req->best_parent_rate, bestdiv);
> > - } else {
> > - ret_rate = divider_round_rate(hw, req->rate, &req->best_parent_rate, NULL,
> > - divider->width, divider->div_flags);
> > - }
> > + req->rate = DIV_ROUND_UP_ULL((u64)req->best_parent_rate, bestdiv);
> > - pr_debug("--> %s: divider_round_rate: val = %ld\n",
> > - clk_hw_get_name(hw), ret_rate);
> > - req->rate = ret_rate;
> > + return 0;
> > + }
> > - return 0;
> > + return divider_determine_rate(hw, req, NULL, divider->width,
> > + divider->div_flags);
> > }
> > static int sg2042_clk_divider_set_rate(struct clk_hw *hw,
> Tested-by: Chen Wang <unicorn_wang@outlook.com>
>
> Reviewed-by: Chen Wang <unicorn_wang@outlook.com>
>
> BTW: I have a question about the base-commit on which your patch series is
> based. Could you please tell me where I can find this base-commit? I'm
> asking this because I found that for the changes in [25/27] phy-j721e-wiz,
> if I'm based on the latest upstream master, I can't successfully apply this
> patch.
>
> So, in my testing, I'm based on 6.19-rc1 and haven't picked [25/27].
My branch is based on linux-next-20260105. I verified that this series
also applies to linux-next-20260109. The TI patch depends on patch 9
from this series that's in linux-next:
https://lore.kernel.org/linux-phy/176656156358.817806.16966474957670370356.b4-ty@kernel.org/
Brian
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends
2026-01-08 21:16 [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Brian Masney
2026-01-08 21:16 ` [PATCH 01/27] clk: sophgo: cv18xx-ip: convert from divider_round_rate() to divider_determine_rate() Brian Masney
2026-01-08 21:16 ` [PATCH 17/27] clk: sophgo: sg2042-clkgen: " Brian Masney
@ 2026-01-10 19:11 ` Bjorn Andersson
2026-01-15 21:05 ` Dmitry Baryshkov
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2026-01-10 19:11 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-clk, linux-kernel, Chen Wang, Inochi Amaoto, sophgo,
Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, Samuel Holland,
linux-arm-kernel, linux-sunxi, Alexandre Belloni, linux-rtc,
Andreas Färber, Manivannan Sadhasivam, linux-actions,
Keguang Zhang, linux-mips, Taichi Sugaya, Takao Orito,
Jacky Huang, Shan-Chun Hung, Vladimir Zapolskiy,
Piotr Wojtaszczyk, linux-arm-msm, Orson Zhai, Baolin Wang,
Chunyan Zhang, Maxime Coquelin, Alexandre Torgue, linux-stm32,
Michal Simek, Rob Clark, Dmitry Baryshkov, David Airlie,
Simona Vetter, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, dri-devel, freedreno, Vinod Koul, Neil Armstrong,
linux-phy
On Thu, 08 Jan 2026 16:16:18 -0500, Brian Masney wrote:
> Here's a series that gets rid of the deprecated APIs
> divider_round_rate(), divider_round_rate_parent(), and
> divider_ro_round_rate_parent() since these functions are just wrappers
> for the determine_rate variant.
>
> Note that when I converted some of these drivers from round_rate to
> determine_rate, this was mistakenly converted to the following in some
> cases:
>
> [...]
Applied, thanks!
[14/27] clk: qcom: alpha-pll: convert from divider_round_rate() to divider_determine_rate()
commit: e1f08613e113f02a3ec18c9a7964de97f940acbf
[15/27] clk: qcom: regmap-divider: convert from divider_ro_round_rate() to divider_ro_determine_rate()
commit: 35a48f41b63f67c490f3a2a89b042536be67cf0f
[16/27] clk: qcom: regmap-divider: convert from divider_round_rate() to divider_determine_rate()
commit: b2f36d675e09299d9aee395c6f83d8a95d4c9441
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends
2026-01-08 21:16 [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Brian Masney
` (2 preceding siblings ...)
2026-01-10 19:11 ` (subset) [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Bjorn Andersson
@ 2026-01-15 21:05 ` Dmitry Baryshkov
2026-01-21 22:53 ` Brian Masney
2026-02-04 15:44 ` (subset) " Vinod Koul
5 siblings, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2026-01-15 21:05 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-clk, linux-kernel, Chen Wang, Inochi Amaoto, sophgo,
Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, Samuel Holland,
linux-arm-kernel, linux-sunxi, Alexandre Belloni, linux-rtc,
Andreas Färber, Manivannan Sadhasivam, linux-actions,
Keguang Zhang, linux-mips, Taichi Sugaya, Takao Orito,
Jacky Huang, Shan-Chun Hung, Vladimir Zapolskiy,
Piotr Wojtaszczyk, Bjorn Andersson, linux-arm-msm, Orson Zhai,
Baolin Wang, Chunyan Zhang, Maxime Coquelin, Alexandre Torgue,
linux-stm32, Michal Simek, Rob Clark, Dmitry Baryshkov,
David Airlie, Simona Vetter, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, dri-devel, freedreno, Vinod Koul,
Neil Armstrong, linux-phy
On Thu, 08 Jan 2026 16:16:18 -0500, Brian Masney wrote:
> Here's a series that gets rid of the deprecated APIs
> divider_round_rate(), divider_round_rate_parent(), and
> divider_ro_round_rate_parent() since these functions are just wrappers
> for the determine_rate variant.
>
> Note that when I converted some of these drivers from round_rate to
> determine_rate, this was mistakenly converted to the following in some
> cases:
>
> [...]
Applied to msm-next, thanks!
[24/27] drm/msm/dsi_phy_14nm: convert from divider_round_rate() to divider_determine_rate()
https://gitlab.freedesktop.org/lumag/msm/-/commit/1d232f793d4d
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends
2026-01-08 21:16 [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Brian Masney
` (3 preceding siblings ...)
2026-01-15 21:05 ` Dmitry Baryshkov
@ 2026-01-21 22:53 ` Brian Masney
2026-02-04 15:44 ` (subset) " Vinod Koul
5 siblings, 0 replies; 9+ messages in thread
From: Brian Masney @ 2026-01-21 22:53 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-kernel, Chen Wang, Inochi Amaoto, sophgo,
Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, Samuel Holland,
linux-arm-kernel, linux-sunxi, Alexandre Belloni, linux-rtc,
Andreas Färber, Manivannan Sadhasivam, linux-actions,
Keguang Zhang, linux-mips, Taichi Sugaya, Takao Orito,
Jacky Huang, Shan-Chun Hung, Vladimir Zapolskiy,
Piotr Wojtaszczyk, Bjorn Andersson, linux-arm-msm, Orson Zhai,
Baolin Wang, Chunyan Zhang, Maxime Coquelin, Alexandre Torgue,
linux-stm32, Michal Simek, Rob Clark, Dmitry Baryshkov,
David Airlie, Simona Vetter, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, dri-devel, freedreno, Vinod Koul,
Neil Armstrong, linux-phy
Hi Stephen,
On Thu, Jan 08, 2026 at 04:16:18PM -0500, Brian Masney wrote:
> Here's a series that gets rid of the deprecated APIs
> divider_round_rate(), divider_round_rate_parent(), and
> divider_ro_round_rate_parent() since these functions are just wrappers
> for the determine_rate variant.
I sent you a GIT PULL for what can go to Linus for the upcoming merge
window from this series:
https://lore.kernel.org/linux-clk/aXFYU324yQ6uBmk0@redhat.com/T/#u
Thanks,
Brian
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: (subset) [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends
2026-01-08 21:16 [PATCH 00/27] clk: remove deprecated API divider_round_rate() and friends Brian Masney
` (4 preceding siblings ...)
2026-01-21 22:53 ` Brian Masney
@ 2026-02-04 15:44 ` Vinod Koul
5 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2026-02-04 15:44 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-clk, linux-kernel, Chen Wang, Inochi Amaoto, sophgo,
Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, Samuel Holland,
linux-arm-kernel, linux-sunxi, Alexandre Belloni, linux-rtc,
Andreas Färber, Manivannan Sadhasivam, linux-actions,
Keguang Zhang, linux-mips, Taichi Sugaya, Takao Orito,
Jacky Huang, Shan-Chun Hung, Vladimir Zapolskiy,
Piotr Wojtaszczyk, Bjorn Andersson, linux-arm-msm, Orson Zhai,
Baolin Wang, Chunyan Zhang, Maxime Coquelin, Alexandre Torgue,
linux-stm32, Michal Simek, Rob Clark, Dmitry Baryshkov,
David Airlie, Simona Vetter, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, dri-devel, freedreno, Neil Armstrong,
linux-phy
On Thu, 08 Jan 2026 16:16:18 -0500, Brian Masney wrote:
> Here's a series that gets rid of the deprecated APIs
> divider_round_rate(), divider_round_rate_parent(), and
> divider_ro_round_rate_parent() since these functions are just wrappers
> for the determine_rate variant.
>
> Note that when I converted some of these drivers from round_rate to
> determine_rate, this was mistakenly converted to the following in some
> cases:
>
> [...]
Applied, thanks!
[25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate()
commit: dbeea86fecef7cf2b93aded4525d74f6277376ef
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread