Re: [PATCH 1/8] dt-bindings: sound: sophgo: add CV1800B I2S/TDM controller binding

Rob Herring
2026-01-21T16:32:15Z

On Thu, Jan 15, 2026 at 11:17:38PM +0400, Anton D. Stavinskii wrote:
> Purpose: introduce DT schema for the CPU driver

Please write a better commit msg. Use complete sentences for starters.

>
> Signed-off-by: Anton D. Stavinskii <stavinsky@gmail.com>
> ---
> .../bindings/sound/sophgo,cv1800b-i2s.yaml | 75 ++++++++++++++++++++++
> 1 file changed, 75 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/sophgo,cv1800b-i2s.yaml b/Documentation/devicetree/bindings/sound/sophgo,cv1800b-i2s.yaml
> new file mode 100644
> index 000000000000..cf30880a62da
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/sophgo,cv1800b-i2s.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/sophgo,cv1800b-i2s.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sophgo CV1800B I2S/TDM controller
> +
> +maintainers:
> + - Anton D. Stavinskii <stavinsky@gmail.com>
> +
> +description: |

Don't need '|' if no formatting.

> + I2S/TDM controller found in CV1800B / Sophgo SG2002/SG2000 SoCs.
> +
> +properties:
> + compatible:
> + const: sophgo,cv1800b-i2s
> +
> + reg:
> + maxItems: 1
> +
> + "#sound-dai-cells":
> + const: 0
> +
> + clocks:
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: i2s
> + - const: mclk
> +
> + dmas:
> + maxItems: 2

dma-names allows 1 entry, but this requires 2?

> +
> + dma-names:
> + description: |
> + Names of DMA channels. May be omitted. If present, one entry
> + selects a single direction, while two entries select RX and TX.

Drop the first 2 sentences.

> + minItems: 1
> + maxItems: 2
> + items:
> + enum: [rx, tx]
> +

> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0

What are these for? You don't have any child nodes with addresses.

> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - "#sound-dai-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/sophgo,cv1800.h>
> +
> + i2s1: i2s@4110000 {

Drop unused label.

> + compatible = "sophgo,cv1800b-i2s";
> + reg = <0x04110000 0x10000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clk CLK_APB_I2S1>, <&clk CLK_SDMA_AUD1>;
> + clock-names = "i2s", "mclk";
> + dmas = <&dmamux 2 1>, <&dmamux 3 1>;
> + dma-names = "rx", "tx";
> + };
> +...
>
> --
> 2.43.0
>