Re: [PATCH v4 5/6] ASoC: sophgo: add CV1800B internal DAC codec driver

Anton D. Stavinskii
2026-01-27T15:30:34Z

On Tue, Jan 27, 2026 at 03:13:59PM +0400, Mark Brown wrote:
> On Tue, Jan 27, 2026 at 07:11:24PM +0400, Anton D. Stavinskii wrote:
> > On Tue, Jan 27, 2026 at 12:49:52PM +0400, Mark Brown wrote:
>
> > > Nothing ever mutes the DAC so this is a bit redundant. The mute should
> > > probably be a mute_stream() operation.
>
> > I'm not sure here. DAC mute feature was not implemented because I don't know how
> > exactly do that. The public documentation is very weak for my taste.
> > This call added here to be sure that override flag is
> > not set (override feature replaces the output by setting it to constant
> > value and ignoring the input, so it is some kind of mute from my understanding.
> > So ensuring this off is needed be sure that DAC will output our I2S data).
> > What do you think will be better to do here?
> > I'm sure that is needed, but may be better to move
> > it to some early stages, like probe function.
>
> It's probably fine to leave the functional code as is but you should add
> some comments to the mute function explaining waht's going on here.

Sounds good. Will add comments and prepare v5.
Thanks a lot!

> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv