Re: [PATCH v4 5/6] ASoC: sophgo: add CV1800B internal DAC codec driver

Anton D. Stavinskii
2026-01-27T15:11:31Z

On Tue, Jan 27, 2026 at 12:49:52PM +0400, Mark Brown wrote:
> On Tue, Jan 20, 2026 at 11:06:07PM +0400, Anton D. Stavinskii wrote:
>
> > help
> > This driver provides an ASoC codec DAI for capture and basic
> > control of the RXADC registers.
> > -
> > Say Y or M to build support for the Sophgo CV1800B
> > internal analog ADC codec block (RXADC).
> > The module will be called cv1800b-sound-adc
>
> Extra change here.
Will fix, thanks.
>
> > +static int cv1800b_dac_hw_params(struct snd_pcm_substream *substream,
> > + struct snd_pcm_hw_params *params,
> > + struct snd_soc_dai *dai)
> > +{
> > + struct cv1800b_priv *priv = snd_soc_dai_get_drvdata(dai);
> > + int ret;
> > + unsigned int rate = params_rate(params);
>
> > + cv1800b_dac_mute(priv, false);
> > + /* minimal decimation for 48kHz is 64*/
>
> Nothing ever mutes the DAC so this is a bit redundant. The mute should
> probably be a mute_stream() operation.

I'm not sure here. DAC mute feature was not implemented because I don't know how
exactly do that. The public documentation is very weak for my taste.
This call added here to be sure that override flag is
not set (override feature replaces the output by setting it to constant
value and ignoring the input, so it is some kind of mute from my understanding.
So ensuring this off is needed be sure that DAC will output our I2S data).
What do you think will be better to do here?
I'm sure that is needed, but may be better to move
it to some early stages, like probe function.