From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C57923ADBA4 for ; Sat, 17 Oct 2026 16:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792255171; cv=none; b=j6axtci7Gx0Cdq/GhAXMWqwCo0OAej59yKHoFuegXJaB060ZWNv+6+HBaWDRoQlKKp/7jHoWboJzrJ6bKKSEb8VEx6b9BQDvndqAacyj0n16IwMTDnzRQeQkIRWj6HET+zQAdxJye9hToMO1XSi091nheWo7GpeniDKIhoQ9OWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792255171; c=relaxed/simple; bh=VjJXPVvJ28GFo5oaYh5V0N4OmfzYXgOo11M2D9Ou1Sw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iaPlv/662VrPQy/rUP68T3l6M2gm93zs6u6xn5o+FbxxCkVKmmX6/D53aEqn/ibQaXE6EGc4bumJKQG5gg5X4jU74dqOuVoFo79nhPQs6imxr1Hm3BcithiazDeNwnKGk15Is9b6mWjpNwUoHZZCihzzNHs5MvUe4ybRDyK+BXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iqcI3njC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K72FGrTF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iqcI3njC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K72FGrTF" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HGAEhQ1179625 for ; Sat, 17 Oct 2026 16:39:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=hz4iIDuDhHEcy2mIuGeKuord 9GLsrFZT6JV2X218PUA=; b=iqcI3njCDzM4e7mRHLw+YV3xmeKx13qdpNpYLO1c uKuJcnhcRz3rtqo+XqDGeMCZv2dURNY8sE4Up/wSPorj21shN+H4P4PvOUiE1k4f HrKJsV+TXCcL1K6rMrtrXUEtT4Vlu4w4TsY7ngl01CsdTZz1rKlYemGVmnu3eNHV +HjThJ6ViFeCJyAVpyHQYmZUV+RGbosOkNtCwmXNHB6OUn0sulMIxvCNKMz7qg71 VvhPs8OoWfwTc1Wwi9VbA8nr0EEah65QxY+qlhZZrIAZfY7QJDXrV6PujpiUFd11 LA1oKqK2zNAXkDqjMldYzsbUJ7V6A2GAOrlTldaC5GhPdA== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc0bghdw4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 16:39:28 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-3580c07911eso2499257eec.0 for ; Sat, 17 Oct 2026 09:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792255168; x=1792859968; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hz4iIDuDhHEcy2mIuGeKuord9GLsrFZT6JV2X218PUA=; b=K72FGrTFFHMaYLH/OtaguXu6tuxxYNo7SpGaHQCR7ZTRNsuka7xXxJ1UqQrzPRUrpU At7gjPjT0PlGYfI/Ghh2SkPFxjkb88P1C9vo0qXqpuKsWUpVWPOFnQcvk4Xz4djDlFmO KOkzvmRhbc/HH5hCjFJCkT27EBGdvSA8Rx6A+IBGK7fKzs2kDBfDTo3uVHT+hYg2IoZH AHueA5H6Fqlwol4NHSd7WQOU/YoKv1Q/4ZoMUCSmihrGwNpIK3z/5IGUB+2T+qaFx1JL 3Pur6Cvsj9X0b2aTHCgNpk2qPbjRe2K9r5/uu3BH0ydSci+QKM0CSJJN35U/E/lJNGbB h2Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792255168; x=1792859968; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hz4iIDuDhHEcy2mIuGeKuord9GLsrFZT6JV2X218PUA=; b=vjNkE1aH9jE8Bt2By15maYG3u9Jp2BvcCceY+Q5/hithPqrxL1G+lwkvS4K+dW/WhS A3WR/g2fTrojLwseyAHH/F4+C7KpQUuHx3FuEI9Hn7qaTaJdrk8y7WWGso46JSJpt+qA ct9al61VgB3csgrXvDstBGte6YjeIF/3lhAc5Nh+jyZK3hcUL/edyyLDE7HT102f8kpD DtJoPGUeIdB+dhectrMmjosLTxbfndegwmffvnbenm1xs2XOdow7Ahlw20K7bF3qMo4r okl1XCxD76qm91qAFUz7HRQKnaR0W3p1l5zIOCsogzfbSOU4yYvCxL77lYo1l5vFbgCx OIPw== X-Forwarded-Encrypted: i=1; AKwUvBwK7exSlBqrplhGA/YL6Js3aPeafXQi9WhE3oJHAOC5N1wlIp8aGMrRww/H51oOpMQq4vlAYO8=@lists.linux.dev X-Gm-Message-State: AFq9FYI/LfBVaBtOrGw3eqsfuW7BhqO8Pz3S9YfFo6emNyqeScnRkYRS pvQA/WldLjFyp1Ouer0NvVlVJIofFYuGLnvBL1kunklDCpAI0rNnZUfsBGxyb8J34wlKzGtghSL WGuuJH0QXq6036H8XMcq9ybwCKV17jtXoevbJl23+0DkuhOjmhnRkaRrZVhg= X-Gm-Gg: AYBFou16p00ux2WNtnK+zUAAl1KoJzNmDhpYGOs6xykhJ2FdExt41BNeFZYzInypPbh 7undGQDO5ZYymn165SZwAjLHSHBjyF63UTkUOjrbxmtElJ9xGdzy+nUC+9hOd5ndTjsWU1O6x0I atR4RR0n2aBvoeZKXpQEtSHGUoovG6jLQcE4w/qiYa3NnjXhy0o7W2u7xR1vAFVvwjvjY6i4PNd lL+Md9Zj4YjZMIvL/bAo7MlKCphOeA/MyH2KdwUdgicLhQYYGK2PUaoZ0MlaPprQti/bj5JQhUJ pb2FHAECSiXcgn9DYHBKtHc/c5C/xmmNZ6xDg9d0uPihUDH32ftq8GhOYUU01vKUhG2BTo0dKr9 78qgAGK+fC/bC X-Received: by 2002:a05:7300:2406:b0:360:5f7e:2eb9 with SMTP id 5a478bee46e88-361a254da08mr4629962eec.32.1792255167316; Sat, 17 Oct 2026 09:39:27 -0700 (PDT) X-Received: by 2002:a05:7300:2406:b0:360:5f7e:2eb9 with SMTP id 5a478bee46e88-361a254da08mr4629905eec.32.1792255166648; Sat, 17 Oct 2026 09:39:26 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-360813b6e33sm17691508eec.7.2026.10.17.09.39.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 09:39:26 -0700 (PDT) Date: Sat, 17 Oct 2026 22:09:10 +0530 From: Mohd Ayaan Anwar To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v16 4/7] net: stmmac: qcom-ethqos: update phy_mode to the resolved interface in mac_finish() Message-ID: References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> <20261014-qcom-sa8255p-emac-v16-4-0266c2ead980@oss.qualcomm.com> Precedence: bulk X-Mailing-List: sophgo@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261014-qcom-sa8255p-emac-v16-4-0266c2ead980@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX89gziQiVfiV0 BoSsAEWy22KSUqlaQo7tWrA8c1heQr0lj4c/rFk9bE+aHmdiqtE9YgUM/KkDqqncPpx24Qf6Krs L+cC/Mb7gcAKw/fSPyDdqkrxNhwnEBM= X-Authority-Analysis: v=2.4 cv=FayiV5+6 c=1 sm=1 tr=0 ts=6ad3a4c0 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=K33ZUWoUxhUzfzW7EYwA:9 a=CjuIK1q_8ugA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX9ENow5nTgI/I hLs7sBILcGwGWVg97xnR4+zsmzlQDQWGsdtcquTRde1ryw5m/5U3c/ZQ6lB3mlbhWHbP7z+YpGh b+Kvb3MBo2+a92aYDQbPUbTc7PyEdvMvmiq9JI3IRg0VewboKESjHLird5xBLnk/XaSqds5Ov8D joygctYMNyVUm5EecoptQcPbaAICO9NIt9iezxqPiNRjOwMG0V9IQ2Td+kUE4pNZlORZKHtl4F1 nhhx+T60D9r9bJ3E1Z9cfwyssFfU/TiituoD0aOCD1GmBVdoEUy9fb+GwVT/LPn67XHIZVvsH4V i3tDqPKM+8XpzCWjlxDYQ/5JdPYxs/8bW1TNCqJFGMjFwlE1g5WZRBlzmIAG3U63tAGEb+PEP8s Cg4bl4eEXwo4R7diCbTxMn3HnU4OAEMrKkO3WLo1fsvGMd3Esn43YMT35fHI6R2Z26ZzCyr9yws +pMurcwSSn9XwvWlKCQ== X-Proofpoint-ORIG-GUID: hhQNWdp5sCat6TSg6LMkNofHAdVtpmsc X-Proofpoint-GUID: hhQNWdp5sCat6TSg6LMkNofHAdVtpmsc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_05,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 clxscore=1011 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170066 On Wed, Oct 14, 2026 at 02:36:43PM +0200, Bartosz Golaszewski wrote: > ethqos->phy_mode is read by serdes_powerup() and > qcom_ethqos_set_sgmii_loopback() to configure the SerDes and its > wrapper for the correct interface. It is set once at probe from the DT > phy-mode property and never updated. > > phylink resolves the actual runtime interface and passes it to the > mac_finish() callback. On platforms that only ever operate at one speed > these two values are always the same, but when the interface changes > at runtime - for example switching between SGMII and 2500BASE-X - the > stored value becomes stale. The next serdes_powerup() call, on > a subsequent link cycle, then reinitializes the SerDes to the wrong mode. > > Update ethqos->phy_mode from the interface argument in > ethqos_mac_finish_serdes() so that it always reflects the last > resolved interface. > > With that, we now update the phy_mode to the runtime-resolved interface, > so any subsequent resume with a 1G SGMII link skips the loopback setup > and the DMA reset hangs. To remedy this, extend the guard to include > PHY_INTERFACE_MODE_SGMII. > > Signed-off-by: Bartosz Golaszewski > --- I am not sure but should this have a Fixes: tag? Reviewed-by: Mohd Ayaan Anwar Ayaan