From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B739242D78 for ; Mon, 27 Oct 2025 13:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761571824; cv=none; b=k2yDbsgGkWL20CPiC+SXIsxWh637SzlUk7tQFcoPcX365FE8OxohwHQfafvxOSyUIBxh2Z8ka6a77Ri0tUdPt3dNq++IBo+pXcA8bfdhFt4BXFlIDS/6ifibTVfNxXshq+9OuqYTZxQO9sZJ8kkNrcS95K8U5KWrpvIQLJzEngU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761571824; c=relaxed/simple; bh=vPwr/+nlNs0manNxtZHH/pbOcpE14vc/oDM+DidS90Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IsGUGykEyKIj1OIhEd3OfUpp9kRYf7taYUgmyzJ6MpSMD0NrwAxbgriik+ut3HF2PUp3rsF6c9xYxUELxkf9HtjqK8TRqS+1NjQe8OQQB7ROgqIFef58v3j+Qm/E6i7ObOsaIsqwuf1ga8vrquqzZ4bK8EbUKZckfGow6Qx67A0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=dKvVFafw; arc=none smtp.client-ip=209.85.166.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="dKvVFafw" Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-945a4bfd8c6so141044739f.0 for ; Mon, 27 Oct 2025 06:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1761571820; x=1762176620; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=59JPfJxdtbZVN0/1a3YIl7OOO3eshWQJw5UtvH1ggXo=; b=dKvVFafwRHBcdzzgKYAtCs2bhE27hjEU+d2eXa4WWLw6uFkghq8GuYI7Aret2CTq2J TRh7LSCEZtrjNuau+Otu8GkePmC9GjruMBjRGgFTaZwOhXzo0M4w+ebPxKQaHVhS7YaV K9L3VFAqmeNP2gFfZtgry3zCCJs+z4GtbmY4ftZMporWMUPSgBv0iUX6md+WX+kHyF1K 0NRDdTHnV5IJWcn2LWBuwJknw0IctbB5f5ASNDj2l1bxSaF4xnmi+aGa0dbjlwprbyBE K5hYjKx4VcIOnyaLDYAPJ7s0sOgz+5BJwf159MkEG6bVwCS50GmdyXReSImCEym0SgEG c0hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761571820; x=1762176620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=59JPfJxdtbZVN0/1a3YIl7OOO3eshWQJw5UtvH1ggXo=; b=YJ7jtPc7RgXLfDr4lMJzgjdzhFD6ILl9kjuZ7+GzBS4Mr2vdMPvnIPF1s7KHSoYH9Q 1TbQhpGWgUgcj6s8l5H1nSZ2sAJBqFGQ1pCYD8l7mpkan1inZt4zBpIgn9Oro//v3X/F 7I+g9LtihuZpeSA3+O3IQ8KS+aodfZK5yHeJhxOjrvSYMQOpYXu8irs+vI2rAtpsYPf1 KkzuSglX3yP52ItoDSuuQThJEmhcQ7K2qkQ5fArkAapiRjvQwAaZInThRkCzTZuWnu4F TaJ7IRYWyQrfPTBisd1MBZn4BgFfuH1FJlcDJbxw6ZcfD3IGP+qbJg405TbVpz3RufAm FtiQ== X-Forwarded-Encrypted: i=1; AJvYcCVed9gW3he/Sp8HaPJpZrYwPMa4v02FmnbO6zDMfCBhiIix7X7H0RxPFOQTRIT1N+9LG/yVYfazRQ==@lists.linux.dev X-Gm-Message-State: AOJu0YwgPjJXw6kkWpyTEnm2lukkIHshZhxkoSO/yzmGMN7bSNG8quAi 41JwHSIxV5h++D4MGM1nyC5N3HhAC3V5pqGtErgzV/EDfIObWEQRDs+FbKCXKP/mL8M= X-Gm-Gg: ASbGncs0krfQT8bDWVqzc+wcXIatOAzjkmUsu3ocHcpMJAOy/ym5MEk5JVKQHkrOUM4 vgJjLwuiqAF9hE9/DLrzVKTsm3Fdt2QwFIAJUdRhY79a3wx9sqe5ahBpUp3hV+nZAdviXRus6+1 7s0q1ZiPN40fTyaCB/08EJrhFUxhk3PDrw/9lRwEJZD4nhALZm1hlcsNAPYkKbpr9Y0DPU0IEB4 xgZU7gWaRQiv7PA2eSIoNYd/hgs0twO3Z4bZFD8UP7jtjM455xIxwJQfTaOQualYo9FJrf5/jZo hOm82SyBd2HUTeJIbCxo32gwHw26+eKshul+vZgq7Xc17S2kd02zAjN+oMgxKaMfjsckv7R1now uc3mhb9SnwYjkxpYGZld0Im6cd5CsC2umsE5O7oYYH320sKPDvfOWMkau64cOSxnEBRghXrM3Dq sshx+A98CTDie1O/ZWpFdyagQNnzCprVFRGaC7bl6oC6orDCjTbyNuLQ== X-Google-Smtp-Source: AGHT+IEOMq9HwQy8lmaiH8m2VohckOU5pzhBNmgtnKE6agpQoWegyJcP4IEG3hVlkqulKDQU9Y3jXA== X-Received: by 2002:a05:6602:29d0:b0:943:5c52:f802 with SMTP id ca18e2360f4ac-945b7d9fd42mr24171239f.0.1761571820080; Mon, 27 Oct 2025 06:30:20 -0700 (PDT) Received: from zippy.localdomain (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5aea78e2fd4sm3093057173.26.2025.10.27.06.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 06:30:19 -0700 (PDT) From: Alex Elder To: han.xu@nxp.com, broonie@kernel.org Cc: dlan@gentoo.org, Frank.li@nxp.com, guodong@riscstar.com, linux-spi@vger.kernel.org, imx@lists.linux.dev, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li Subject: [PATCH v4 4/9] spi: fsl-qspi: switch predicates to bool Date: Mon, 27 Oct 2025 08:30:02 -0500 Message-ID: <20251027133008.360237-5-elder@riscstar.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251027133008.360237-1-elder@riscstar.com> References: <20251027133008.360237-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: spacemit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Change all the needs_*() functions so they are no longer inline, and return bool rather than int. Reviewed-by: Frank Li Signed-off-by: Alex Elder --- v4: - Added Frank Li's Reviewed-by drivers/spi/spi-fsl-qspi.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c index 1e27647dd2a09..1944e63169d36 100644 --- a/drivers/spi/spi-fsl-qspi.c +++ b/drivers/spi/spi-fsl-qspi.c @@ -276,34 +276,34 @@ struct fsl_qspi { u32 memmap_phy; }; -static inline int needs_swap_endian(struct fsl_qspi *q) +static bool needs_swap_endian(struct fsl_qspi *q) { - return q->devtype_data->quirks & QUADSPI_QUIRK_SWAP_ENDIAN; + return !!(q->devtype_data->quirks & QUADSPI_QUIRK_SWAP_ENDIAN); } -static inline int needs_4x_clock(struct fsl_qspi *q) +static bool needs_4x_clock(struct fsl_qspi *q) { - return q->devtype_data->quirks & QUADSPI_QUIRK_4X_INT_CLK; + return !!(q->devtype_data->quirks & QUADSPI_QUIRK_4X_INT_CLK); } -static inline int needs_fill_txfifo(struct fsl_qspi *q) +static bool needs_fill_txfifo(struct fsl_qspi *q) { - return q->devtype_data->quirks & QUADSPI_QUIRK_TKT253890; + return !!(q->devtype_data->quirks & QUADSPI_QUIRK_TKT253890); } -static inline int needs_wakeup_wait_mode(struct fsl_qspi *q) +static bool needs_wakeup_wait_mode(struct fsl_qspi *q) { - return q->devtype_data->quirks & QUADSPI_QUIRK_TKT245618; + return !!(q->devtype_data->quirks & QUADSPI_QUIRK_TKT245618); } -static inline int needs_amba_base_offset(struct fsl_qspi *q) +static bool needs_amba_base_offset(struct fsl_qspi *q) { return !(q->devtype_data->quirks & QUADSPI_QUIRK_BASE_INTERNAL); } -static inline int needs_tdh_setting(struct fsl_qspi *q) +static bool needs_tdh_setting(struct fsl_qspi *q) { - return q->devtype_data->quirks & QUADSPI_QUIRK_USE_TDH_SETTING; + return !!(q->devtype_data->quirks & QUADSPI_QUIRK_USE_TDH_SETTING); } /* -- 2.48.1