From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B94A21CC44 for ; Fri, 2 Jan 2026 03:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767324065; cv=none; b=TsBCdddwZ1EwYZPUgWGkwrq3Pp7yb8/xxF3v6LfBhwlNu+bL8GIb4lxkBMYRNKeFuJL7+6wDqn9dFqvyctfeoWaN1MspSmjZnFL9vLa219nFGVIMKJ11OmJnrmVeDoUIl8o2MLNkyodgJX95ma/j8vXbSa2iskiH7629DvYFRhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767324065; c=relaxed/simple; bh=Gz8XmoS6pxomylJSYAzcfWQufpfdmjp276fRn1E1ZOg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CXEt/RI486kIpkMsNyAW8mwTv8iycQvgg2XjsbpC5txMhPj0MvW+HCWrvTKkfr94orR9pSHKtQrgnUEF2VLAVqkx1r8QqXEtHs3jkYLzyqSTDPQSTC0JKG/MmFhSvXIIFDdfgKyfHgcgELoQpDyfwPllC0IgDWGrfinhVZ6iOxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Received: from localhost (unknown [116.232.18.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 7FBAB341EDE; Fri, 02 Jan 2026 03:20:56 +0000 (UTC) Date: Fri, 2 Jan 2026 11:20:52 +0800 From: Yixun Lan To: Linus Walleij Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Troy Mitchell , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] pinctrl: spacemit: add support for K3 SoC Message-ID: <20260102032052-GYA2053787@gentoo.org> References: <20251226-02-k3-pinctrl-v2-0-5172397e6831@gentoo.org> Precedence: bulk X-Mailing-List: spacemit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Linus, Krzysztof, On 23:49 Thu 01 Jan , Linus Walleij wrote: > Hi Yixun, > > thanks for your patches! > > On Fri, Dec 26, 2025 at 1:58 PM Yixun Lan wrote: > > > This series attempt to add pinctrl support for SpacemiT K3 SoC, > > > > I've removed the RFC tag as the driver is tested on K3 SoC. > > > > The K3 pinctrl IP shares almost same logic with previous K1 SoC generation, > > but has different register offset and pin configuration, I've introduced > > a pin_to_offset() function to handle the difference of register offset. > > for the drive strength and schmitter trigger settings, they are also changed. > > > > The patch #1 try to add pin support which should handle pin mux, while patch #2 > > adjust drive strength and schmitter trigger settings accordingly for new SoC. > > > > Signed-off-by: Yixun Lan > > As Krzysztof mentioned, try to use an explicit device tree schema to > enforce the legal drive strength values as e.g. enums. > Ok, I will address this in v3 > Other than this the code looks fine so once the bindings are > ACK:ed I'm ready to merge this. > Thanks -- Yixun Lan (dlan)