Re: [PATCH 1/2] riscv: dts: spacemit: add common board dtsi for OrangePi

[Yixun Lan <dlan@gentoo.org>]

Hi Chukun,

On 18:00 Fri 16 Jan     , Chukun Pan wrote:
> The OrangePi R2S and OrangePi RV2 boards share many similarities, the
> difference being that the RV2 board has more peripherals, such as HDMI
> and Wi-Fi. Create a dtsi for shared parts to reduce duplication.
no, as I checked these two boards having too many differences that
I don't think it's worth trying to create a shared dtsi file

> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>  .../boot/dts/spacemit/k1-orangepi-r2s.dts     | 69 +----------------
>  .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 69 +----------------
>  arch/riscv/boot/dts/spacemit/k1-orangepi.dtsi | 76 +++++++++++++++++++
>  3 files changed, 78 insertions(+), 136 deletions(-)
>  create mode 100644 arch/riscv/boot/dts/spacemit/k1-orangepi.dtsi
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> index 58098c4a2aab..393270641b04 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
> @@ -5,22 +5,11 @@
>  
>  /dts-v1/;
>  
> -#include "k1.dtsi"
> -#include "k1-pinctrl.dtsi"
> +#include "k1-orangepi.dtsi"
>  
>  / {
>  	model = "OrangePi R2S";
>  	compatible = "xunlong,orangepi-r2s", "spacemit,k1";
> -
> -	aliases {
> -		serial0 = &uart0;
> -		ethernet0 = &eth0;
> -		ethernet1 = &eth1;
> -	};
> -
> -	chosen {
> -		stdout-path = "serial0";
> -	};
>  };
>  

-- 
Yixun Lan (dlan)