Re: [PATCH 2/2] riscv: dts: spacemit: add fixed regulators for OrangePi

[Yixun Lan <dlan@gentoo.org>]

Hi Chukun, 

On 18:00 Fri 16 Jan     , Chukun Pan wrote:
> Define the power input and the 4V / 3.3V power as fixed regulator
> supplies for the PMIC, PCIe and Wi-Fi.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>  arch/riscv/boot/dts/spacemit/k1-orangepi.dtsi | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi.dtsi b/arch/riscv/boot/dts/spacemit/k1-orangepi.dtsi
> index b4808f258adf..c71c5bc1d341 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi.dtsi
> @@ -17,6 +17,34 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0";
>  	};
> +
> +	pcie_vcc3v3: regulator-pcie-vcc3v3 {
can you follow the same name scheme with k1-bananapi-f3.dts?

also please add this regulator with explict consumer - pcie,
otherwise I see the patch isn't really useful

> +		compatible = "regulator-fixed";
> +		regulator-name = "pcie_vcc3v3";
> +		regulator-always-on;
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&vcc_5v0>;
> +	};
> +
> +	vcc_5v0: regulator-vcc-5v0 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_5v0";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +	};
> +
> +	vcc4v0: regulator-vcc4v0 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc4v0";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <4000000>;
> +		regulator-max-microvolt = <4000000>;
> +		vin-supply = <&vcc_5v0>;
> +	};
>  };
>  
>  &eth0 {
> -- 
> 2.25.1
> 

-- 
Yixun Lan (dlan)