From: Yixun Lan <dlan@gentoo.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: alex@ghiti.fr, aou@eecs.berkeley.edu, conor+dt@kernel.org,
krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, palmer@dabbelt.com,
pjw@kernel.org, robh@kernel.org, spacemit@lists.linux.dev
Subject: Re: [PATCH 2/2] riscv: dts: spacemit: add fixed regulators for OrangePi
Date: Sat, 24 Jan 2026 07:58:11 +0800 [thread overview]
Message-ID: <20260123235811-GYB71302@gentoo.org> (raw)
In-Reply-To: <20260123145015.1926865-1-amadeus@jmu.edu.cn>
Hi Chunkun,
On 22:50 Fri 23 Jan , Chukun Pan wrote:
> Hi,
>
> > > + pcie_vcc3v3: regulator-pcie-vcc3v3 {
> > can you follow the same name scheme with k1-bananapi-f3.dts?
>
> Sorry, but I don't quite understand?
>
> From fixed-regulator.yaml:
> properties:
> $nodename:
> anyOf:
> - description: Preferred name is 'regulator-[0-9]v[0-9]'
> pattern: '^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$'
> - description: Any name allowed
> deprecated: true
>
> Using 'regulator-' as a prefix is correct.
> There are also some commits that changed regulator nodenames. [1]
Ok, good to know, then I'm fine with the prefix
>
> As for the regulator-name, it should be consistent with the name in
> the schematics so that people can look it up between the two.
> The BPI-F3 also seems to have some names [2] that need improvement:
>
> vcc_4v -> vcc4v0_sys
> USB30_HUB -> vcc5v0_hub
> USB30_VBUS -> 5v_vbus
> vin-supply vcc5v0_sys
I do not have strong preference to have label/node name *strictly* matched
with the schematics, IMO, keeping certain alignment is ok, you can still
make some adjustment as long as keep it clean and explicit..
also it's still helpful to give a high level abstract name in 'regulator-name'
for the end user to know what's the regulator connect to.. e.g. in
/sys/kernel/debug/regulator/regulator_summary
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-01-23 23:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 10:00 [PATCH 1/2] riscv: dts: spacemit: add common board dtsi for OrangePi Chukun Pan
2026-01-16 10:00 ` [PATCH 2/2] riscv: dts: spacemit: add fixed regulators " Chukun Pan
2026-01-19 3:02 ` Yixun Lan
2026-01-23 14:50 ` Chukun Pan
2026-01-23 23:58 ` Yixun Lan [this message]
2026-01-19 2:42 ` [PATCH 1/2] riscv: dts: spacemit: add common board dtsi " Yixun Lan
2026-01-23 14:06 ` Chukun Pan
2026-01-24 0:04 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123235811-GYB71302@gentoo.org \
--to=dlan@gentoo.org \
--cc=alex@ghiti.fr \
--cc=amadeus@jmu.edu.cn \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox