* [PATCH 0/3] usb: misc: Add Terminus FE1.1 USB2.0 Hub support
@ 2026-03-17 8:55 Yixun Lan
2026-03-17 8:55 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Terminus Yixun Lan
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Yixun Lan @ 2026-03-17 8:55 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Greg Kroah-Hartman, Matthias Kaehlcke
Cc: Junzhong Pan, Inochi Amaoto, spacemit, devicetree, linux-kernel,
linux-usb, Yixun Lan
This series try to add support for Terminus FE1.1 USB2.0 Hub.
The FE1.1 Hub provide interesting choice of selecting power supply from
either 3.3V or 5V, if need to use integrated 5V to 3.3v regulator, the 5V
supply should be used. Otherwise, 5V pin can be set to NO-Connection,
and use the 3.3v external supply source.
Link: https://terminus-usa.com/wp-content/uploads/2024/06/FE1.1s-Product-Brief-Rev.-2.0-2023.pdf [1]
Signed-off-by: Yixun Lan <dlan@kernel.org>
---
Yixun Lan (3):
dt-bindings: vendor-prefixes: Add Terminus
dt-bindings: usb: Add support for Terminus FE1.1s USB2.0 Hub controller
usb: misc: onboard_usb_dev: Add Terminus FE1.1s USB2.0 Hub (1a40:0101)
.../devicetree/bindings/usb/terminus,fe11.yaml | 61 ++++++++++++++++++++++
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
drivers/usb/misc/onboard_usb_dev.c | 2 +
drivers/usb/misc/onboard_usb_dev.h | 8 +++
4 files changed, 73 insertions(+)
---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260317-03-usb-hub-fe1-356aea478a5b
Best regards,
--
Yixun Lan <dlan@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] dt-bindings: vendor-prefixes: Add Terminus
2026-03-17 8:55 [PATCH 0/3] usb: misc: Add Terminus FE1.1 USB2.0 Hub support Yixun Lan
@ 2026-03-17 8:55 ` Yixun Lan
2026-03-18 8:27 ` Krzysztof Kozlowski
2026-03-17 8:55 ` [PATCH 2/3] dt-bindings: usb: Add support for Terminus FE1.1s USB2.0 Hub controller Yixun Lan
2026-03-17 8:55 ` [PATCH 3/3] usb: misc: onboard_usb_dev: Add Terminus FE1.1s USB2.0 Hub (1a40:0101) Yixun Lan
2 siblings, 1 reply; 8+ messages in thread
From: Yixun Lan @ 2026-03-17 8:55 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Greg Kroah-Hartman, Matthias Kaehlcke
Cc: Junzhong Pan, Inochi Amaoto, spacemit, devicetree, linux-kernel,
linux-usb, Yixun Lan
Terminus is a Taiwanese fabless chip company specialized in high-speed
serial-bus based, IC products for PC peripheral, consumer electronics.
Signed-off-by: Yixun Lan <dlan@kernel.org>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index ee7fd3cfe203..cd2df06cdc1f 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1648,6 +1648,8 @@ patternProperties:
description: Tenstorrent AI ULC
"^terasic,.*":
description: Terasic Inc.
+ "^terminus,.*":
+ description: Terminus Technology Inc.
"^tesla,.*":
description: Tesla, Inc.
"^test,.*":
--
2.53.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] dt-bindings: usb: Add support for Terminus FE1.1s USB2.0 Hub controller
2026-03-17 8:55 [PATCH 0/3] usb: misc: Add Terminus FE1.1 USB2.0 Hub support Yixun Lan
2026-03-17 8:55 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Terminus Yixun Lan
@ 2026-03-17 8:55 ` Yixun Lan
2026-03-18 8:36 ` Krzysztof Kozlowski
2026-03-17 8:55 ` [PATCH 3/3] usb: misc: onboard_usb_dev: Add Terminus FE1.1s USB2.0 Hub (1a40:0101) Yixun Lan
2 siblings, 1 reply; 8+ messages in thread
From: Yixun Lan @ 2026-03-17 8:55 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Greg Kroah-Hartman, Matthias Kaehlcke
Cc: Junzhong Pan, Inochi Amaoto, spacemit, devicetree, linux-kernel,
linux-usb, Yixun Lan
Terminus FE1.1s is USB2.0 protocol compliant 4-port USB HUB, It support
MTT (Multiple Transaction Translator) mode, the upstream port supports
high-speed 480MHz and full-speed 12MHz modes, also has integrated 5V to
3.3V, 1.8V regulator and Power-On-Reset circuit.
Introduce the DT binding for it.
Link: https://terminus-usa.com/wp-content/uploads/2024/06/FE1.1s-Product-Brief-Rev.-2.0-2023.pdf [1]
Signed-off-by: Yixun Lan <dlan@kernel.org>
---
.../devicetree/bindings/usb/terminus,fe11.yaml | 61 ++++++++++++++++++++++
1 file changed, 61 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/terminus,fe11.yaml b/Documentation/devicetree/bindings/usb/terminus,fe11.yaml
new file mode 100644
index 000000000000..93bb4066f851
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/terminus,fe11.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/terminus,fe11.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Terminus FE1.1/1.1S USB 2.0 Hub Controller
+
+maintainers:
+ - Yixun Lan <dlan@kernel.org>
+
+allOf:
+ - $ref: usb-hub.yaml#
+
+properties:
+ compatible:
+ enum:
+ - usb1a40,0101
+
+ reg: true
+
+ reset-gpios:
+ description:
+ GPIO controlling the RESET#, but the reset line can be optional.
+
+ vdd-supply:
+ description:
+ Regulator supply to the hub, one of 3.3V or 5V can be chosen.
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ patternProperties:
+ '^port@':
+ $ref: /schemas/graph.yaml#/properties/port
+
+ properties:
+ reg:
+ minimum: 1
+ maximum: 4
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ usb {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hub: hub@1 {
+ compatible = "usb1a40,0101";
+ reg = <1>;
+ reset-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&vcc_5v>;
+ };
+ };
--
2.53.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] usb: misc: onboard_usb_dev: Add Terminus FE1.1s USB2.0 Hub (1a40:0101)
2026-03-17 8:55 [PATCH 0/3] usb: misc: Add Terminus FE1.1 USB2.0 Hub support Yixun Lan
2026-03-17 8:55 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Terminus Yixun Lan
2026-03-17 8:55 ` [PATCH 2/3] dt-bindings: usb: Add support for Terminus FE1.1s USB2.0 Hub controller Yixun Lan
@ 2026-03-17 8:55 ` Yixun Lan
2026-03-18 8:40 ` Krzysztof Kozlowski
2 siblings, 1 reply; 8+ messages in thread
From: Yixun Lan @ 2026-03-17 8:55 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Greg Kroah-Hartman, Matthias Kaehlcke
Cc: Junzhong Pan, Inochi Amaoto, spacemit, devicetree, linux-kernel,
linux-usb, Yixun Lan
Terminus FE1.1s is USB2.0 protocol compliant 4-port USB HUB, It support
MTT (Multiple Transaction Translator) mode, the upstream port supports
high-speed 480MHz and full-speed 12MHz modes, also it has integrated 5V
to 3.3V/1.8V regulator and Power-On-Reset circuit.
Link: https://terminus-usa.com/wp-content/uploads/2024/06/FE1.1s-Product-Brief-Rev.-2.0-2023.pdf [1]
Signed-off-by: Yixun Lan <dlan@kernel.org>
---
drivers/usb/misc/onboard_usb_dev.c | 2 ++
drivers/usb/misc/onboard_usb_dev.h | 8 ++++++++
2 files changed, 10 insertions(+)
diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c
index ba37eb99efba..5732843c6687 100644
--- a/drivers/usb/misc/onboard_usb_dev.c
+++ b/drivers/usb/misc/onboard_usb_dev.c
@@ -570,6 +570,7 @@ static struct platform_driver onboard_dev_driver = {
#define VENDOR_ID_MICROCHIP 0x0424
#define VENDOR_ID_PARADE 0x1da0
#define VENDOR_ID_REALTEK 0x0bda
+#define VENDOR_ID_TERMINUS 0x1a40
#define VENDOR_ID_TI 0x0451
#define VENDOR_ID_VIA 0x2109
#define VENDOR_ID_XMOS 0x20B1
@@ -673,6 +674,7 @@ static const struct usb_device_id onboard_dev_id_table[] = {
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x0414) }, /* RTS5414 USB 3.2 HUB */
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x5414) }, /* RTS5414 USB 2.1 HUB */
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x0179) }, /* RTL8188ETV 2.4GHz WiFi */
+ { USB_DEVICE(VENDOR_ID_TERMINUS, 0x0101) }, /* Terminus FE1.1s 2.0 HUB */
{ USB_DEVICE(VENDOR_ID_TI, 0x8025) }, /* TI USB8020B 3.0 HUB */
{ USB_DEVICE(VENDOR_ID_TI, 0x8027) }, /* TI USB8020B 2.0 HUB */
{ USB_DEVICE(VENDOR_ID_TI, 0x8140) }, /* TI USB8041 3.0 HUB */
diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h
index 1a1e86e60e04..4efc5f44c4ee 100644
--- a/drivers/usb/misc/onboard_usb_dev.h
+++ b/drivers/usb/misc/onboard_usb_dev.h
@@ -108,6 +108,13 @@ static const struct onboard_dev_pdata genesys_gl852g_data = {
.is_hub = true,
};
+static const struct onboard_dev_pdata terminus_fe11s_data = {
+ .reset_us = 10,
+ .num_supplies = 1,
+ .supply_names = { "vdd" },
+ .is_hub = true,
+};
+
static const struct onboard_dev_pdata vialab_vl817_data = {
.reset_us = 10,
.num_supplies = 1,
@@ -153,6 +160,7 @@ static const struct of_device_id onboard_dev_match[] = {
{ .compatible = "usbbda,5411", .data = &realtek_rts5411_data, },
{ .compatible = "usbbda,414", .data = &realtek_rts5411_data, },
{ .compatible = "usbbda,5414", .data = &realtek_rts5411_data, },
+ { .compatible = "usb1a40,0101", .data = &terminus_fe11s_data, },
{ .compatible = "usb1a86,8091", .data = &wch_ch334_data, },
{ .compatible = "usb1da0,5511", .data = ¶de_ps5511_data, },
{ .compatible = "usb1da0,55a1", .data = ¶de_ps5511_data, },
--
2.53.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] dt-bindings: vendor-prefixes: Add Terminus
2026-03-17 8:55 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Terminus Yixun Lan
@ 2026-03-18 8:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-18 8:27 UTC (permalink / raw)
To: Yixun Lan
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Greg Kroah-Hartman, Matthias Kaehlcke, Junzhong Pan,
Inochi Amaoto, spacemit, devicetree, linux-kernel, linux-usb
On Tue, Mar 17, 2026 at 08:55:02AM +0000, Yixun Lan wrote:
> Terminus is a Taiwanese fabless chip company specialized in high-speed
> serial-bus based, IC products for PC peripheral, consumer electronics.
>
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] dt-bindings: usb: Add support for Terminus FE1.1s USB2.0 Hub controller
2026-03-17 8:55 ` [PATCH 2/3] dt-bindings: usb: Add support for Terminus FE1.1s USB2.0 Hub controller Yixun Lan
@ 2026-03-18 8:36 ` Krzysztof Kozlowski
2026-03-19 3:43 ` Yixun Lan
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-18 8:36 UTC (permalink / raw)
To: Yixun Lan
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Greg Kroah-Hartman, Matthias Kaehlcke, Junzhong Pan,
Inochi Amaoto, spacemit, devicetree, linux-kernel, linux-usb
On Tue, Mar 17, 2026 at 08:55:03AM +0000, Yixun Lan wrote:
> Terminus FE1.1s is USB2.0 protocol compliant 4-port USB HUB, It support
> MTT (Multiple Transaction Translator) mode, the upstream port supports
> high-speed 480MHz and full-speed 12MHz modes, also has integrated 5V to
> 3.3V, 1.8V regulator and Power-On-Reset circuit.
>
> Introduce the DT binding for it.
>
> Link: https://terminus-usa.com/wp-content/uploads/2024/06/FE1.1s-Product-Brief-Rev.-2.0-2023.pdf [1]
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
> .../devicetree/bindings/usb/terminus,fe11.yaml | 61 ++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/terminus,fe11.yaml b/Documentation/devicetree/bindings/usb/terminus,fe11.yaml
> new file mode 100644
> index 000000000000..93bb4066f851
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/terminus,fe11.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/terminus,fe11.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Terminus FE1.1/1.1S USB 2.0 Hub Controller
> +
> +maintainers:
> + - Yixun Lan <dlan@kernel.org>
> +
> +allOf:
> + - $ref: usb-hub.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - usb1a40,0101
I do not see vendor prefix used anywhere. Drop that patch, because I
think we do not reserve them for file names or schema IDs.
> +
> + reg: true
> +
> + reset-gpios:
> + description:
> + GPIO controlling the RESET#, but the reset line can be optional.
Don't repeat constraints in free form text. Schema tells what can be
optional by not requiring it.
> +
> + vdd-supply:
> + description:
> + Regulator supply to the hub, one of 3.3V or 5V can be chosen.
And this cannot be optional.
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + patternProperties:
> + '^port@':
> + $ref: /schemas/graph.yaml#/properties/port
> +
> + properties:
> + reg:
> + minimum: 1
> + maximum: 4
> +
> +required:
> + - compatible
> + - reg
Missing supply.
> +
> +additionalProperties: false
First, radxa never built tested the DTS when posted it. Yeah, why would
they care...
Second, now you added schema which is nice, but you still did not verify
it with the DTS.
That's the point of DT schema. To verify the DTS. You MUST do it when
you post the binding. Why? To see the errors you have here. See other
hub schemas, like genesys, what goes above - unevaluated.
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + usb {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hub: hub@1 {
Drop unused label
> + compatible = "usb1a40,0101";
> + reg = <1>;
> + reset-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>;
> + vdd-supply = <&vcc_5v>;
> + };
> + };
>
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] usb: misc: onboard_usb_dev: Add Terminus FE1.1s USB2.0 Hub (1a40:0101)
2026-03-17 8:55 ` [PATCH 3/3] usb: misc: onboard_usb_dev: Add Terminus FE1.1s USB2.0 Hub (1a40:0101) Yixun Lan
@ 2026-03-18 8:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-18 8:40 UTC (permalink / raw)
To: Yixun Lan
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Greg Kroah-Hartman, Matthias Kaehlcke, Junzhong Pan,
Inochi Amaoto, spacemit, devicetree, linux-kernel, linux-usb
On Tue, Mar 17, 2026 at 08:55:04AM +0000, Yixun Lan wrote:
> Terminus FE1.1s is USB2.0 protocol compliant 4-port USB HUB, It support
> MTT (Multiple Transaction Translator) mode, the upstream port supports
> high-speed 480MHz and full-speed 12MHz modes, also it has integrated 5V
> to 3.3V/1.8V regulator and Power-On-Reset circuit.
>
> Link: https://terminus-usa.com/wp-content/uploads/2024/06/FE1.1s-Product-Brief-Rev.-2.0-2023.pdf [1]
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
> drivers/usb/misc/onboard_usb_dev.c | 2 ++
> drivers/usb/misc/onboard_usb_dev.h | 8 ++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c
> index ba37eb99efba..5732843c6687 100644
> --- a/drivers/usb/misc/onboard_usb_dev.c
> +++ b/drivers/usb/misc/onboard_usb_dev.c
> @@ -570,6 +570,7 @@ static struct platform_driver onboard_dev_driver = {
> #define VENDOR_ID_MICROCHIP 0x0424
> #define VENDOR_ID_PARADE 0x1da0
> #define VENDOR_ID_REALTEK 0x0bda
> +#define VENDOR_ID_TERMINUS 0x1a40
> #define VENDOR_ID_TI 0x0451
> #define VENDOR_ID_VIA 0x2109
> #define VENDOR_ID_XMOS 0x20B1
> @@ -673,6 +674,7 @@ static const struct usb_device_id onboard_dev_id_table[] = {
> { USB_DEVICE(VENDOR_ID_REALTEK, 0x0414) }, /* RTS5414 USB 3.2 HUB */
> { USB_DEVICE(VENDOR_ID_REALTEK, 0x5414) }, /* RTS5414 USB 2.1 HUB */
> { USB_DEVICE(VENDOR_ID_REALTEK, 0x0179) }, /* RTL8188ETV 2.4GHz WiFi */
> + { USB_DEVICE(VENDOR_ID_TERMINUS, 0x0101) }, /* Terminus FE1.1s 2.0 HUB */
> { USB_DEVICE(VENDOR_ID_TI, 0x8025) }, /* TI USB8020B 3.0 HUB */
> { USB_DEVICE(VENDOR_ID_TI, 0x8027) }, /* TI USB8020B 2.0 HUB */
> { USB_DEVICE(VENDOR_ID_TI, 0x8140) }, /* TI USB8041 3.0 HUB */
> diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h
> index 1a1e86e60e04..4efc5f44c4ee 100644
> --- a/drivers/usb/misc/onboard_usb_dev.h
> +++ b/drivers/usb/misc/onboard_usb_dev.h
> @@ -108,6 +108,13 @@ static const struct onboard_dev_pdata genesys_gl852g_data = {
> .is_hub = true,
> };
>
> +static const struct onboard_dev_pdata terminus_fe11s_data = {
> + .reset_us = 10,
> + .num_supplies = 1,
> + .supply_names = { "vdd" },
> + .is_hub = true,
> +};
So same as vialab_vl817_data, use that one.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] dt-bindings: usb: Add support for Terminus FE1.1s USB2.0 Hub controller
2026-03-18 8:36 ` Krzysztof Kozlowski
@ 2026-03-19 3:43 ` Yixun Lan
0 siblings, 0 replies; 8+ messages in thread
From: Yixun Lan @ 2026-03-19 3:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Greg Kroah-Hartman, Matthias Kaehlcke, Junzhong Pan,
Inochi Amaoto, spacemit, devicetree, linux-kernel, linux-usb
Hi Krzysztof,
I will address all comments for other patches in this series, so no reply
to all of them..
On 09:36 Wed 18 Mar , Krzysztof Kozlowski wrote:
> On Tue, Mar 17, 2026 at 08:55:03AM +0000, Yixun Lan wrote:
> > Terminus FE1.1s is USB2.0 protocol compliant 4-port USB HUB, It support
> > MTT (Multiple Transaction Translator) mode, the upstream port supports
> > high-speed 480MHz and full-speed 12MHz modes, also has integrated 5V to
> > 3.3V, 1.8V regulator and Power-On-Reset circuit.
> >
> > Introduce the DT binding for it.
> >
> > Link: https://terminus-usa.com/wp-content/uploads/2024/06/FE1.1s-Product-Brief-Rev.-2.0-2023.pdf [1]
> > Signed-off-by: Yixun Lan <dlan@kernel.org>
> > ---
> > .../devicetree/bindings/usb/terminus,fe11.yaml | 61 ++++++++++++++++++++++
> > 1 file changed, 61 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/terminus,fe11.yaml b/Documentation/devicetree/bindings/usb/terminus,fe11.yaml
> > new file mode 100644
> > index 000000000000..93bb4066f851
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/terminus,fe11.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/usb/terminus,fe11.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Terminus FE1.1/1.1S USB 2.0 Hub Controller
> > +
> > +maintainers:
> > + - Yixun Lan <dlan@kernel.org>
> > +
> > +allOf:
> > + - $ref: usb-hub.yaml#
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - usb1a40,0101
>
> I do not see vendor prefix used anywhere. Drop that patch, because I
> think we do not reserve them for file names or schema IDs.
>
Ok, will drop
> > +
> > + reg: true
> > +
> > + reset-gpios:
> > + description:
> > + GPIO controlling the RESET#, but the reset line can be optional.
>
> Don't repeat constraints in free form text. Schema tells what can be
> optional by not requiring it.
>
Ok
> > +
> > + vdd-supply:
> > + description:
> > + Regulator supply to the hub, one of 3.3V or 5V can be chosen.
>
> And this cannot be optional.
>
Ok, will add it to 'required' section
> > +
> > + ports:
> > + $ref: /schemas/graph.yaml#/properties/ports
> > +
> > + patternProperties:
> > + '^port@':
> > + $ref: /schemas/graph.yaml#/properties/port
> > +
> > + properties:
> > + reg:
> > + minimum: 1
> > + maximum: 4
> > +
> > +required:
> > + - compatible
> > + - reg
>
> Missing supply.
>
ditto
> > +
> > +additionalProperties: false
>
> First, radxa never built tested the DTS when posted it. Yeah, why would
> they care...
>
> Second, now you added schema which is nice, but you still did not verify
> it with the DTS.
>
> That's the point of DT schema. To verify the DTS. You MUST do it when
> you post the binding. Why? To see the errors you have here. See other
> hub schemas, like genesys, what goes above - unevaluated.
>
Ok, I did the binding check but only for arch/riscv/, will cover all in
future..
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > + usb {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + hub: hub@1 {
>
> Drop unused label
>
Ok
> > + compatible = "usb1a40,0101";
> > + reg = <1>;
> > + reset-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>;
> > + vdd-supply = <&vcc_5v>;
> > + };
> > + };
> >
> > --
> > 2.53.0
> >
>
--
Yixun Lan (dlan)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-03-19 3:44 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17 8:55 [PATCH 0/3] usb: misc: Add Terminus FE1.1 USB2.0 Hub support Yixun Lan
2026-03-17 8:55 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Terminus Yixun Lan
2026-03-18 8:27 ` Krzysztof Kozlowski
2026-03-17 8:55 ` [PATCH 2/3] dt-bindings: usb: Add support for Terminus FE1.1s USB2.0 Hub controller Yixun Lan
2026-03-18 8:36 ` Krzysztof Kozlowski
2026-03-19 3:43 ` Yixun Lan
2026-03-17 8:55 ` [PATCH 3/3] usb: misc: onboard_usb_dev: Add Terminus FE1.1s USB2.0 Hub (1a40:0101) Yixun Lan
2026-03-18 8:40 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox