From: Yixun Lan <dlan@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Troy Mitchell <troy.mitchell@linux.spacemit.com>,
soc@kernel.org, spacemit@lists.linux.dev,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] RISC-V SpacemiT Devicetrees for v7.3
Date: Tue, 11 Aug 2026 10:03:27 +0000 [thread overview]
Message-ID: <20260811100327-GKA277506@kernel.org> (raw)
In-Reply-To: <cec87950-f0e1-49f8-9a2c-f8b87b460da2@app.fastmail.com>
hi Arnd,
On 09:22 Tue 11 Aug , Arnd Bergmann wrote:
> On Tue, Aug 11, 2026, at 04:49, Troy Mitchell wrote:
> > On Tue Aug 11, 2026 at 12:45 AM +08, Arnd Bergmann wrote:
> >> On Sun, Aug 2, 2026, at 04:42, Yixun Lan wrote:
> >>
> >>> Troy Mitchell (1):
> >>> riscv: dts: spacemit: k3: add i2s0-i2s5 nodes
> >>
> >> This commit caused a build failure, so I reverted it for the 7.3
> >> merge window:
> >>
> >> Lexical error: ../arch/riscv/boot/dts/spacemit/k3.dtsi:1181.20-39 Unexpected 'CLK_MPMU_I2S_SYSCLK'
> >>
> >> Please make sure that each pull request you send is free of
> >> build failures and warnings and works on its own.
> >>
Ok, Learned
> >
> > The missing macro has been merged here [1].
> >
> > Link:
> > https://lore.kernel.org/all/20260717-k3-clk-fix-i2s-v1-1-e95001a692ee@linux.spacemit.com/
> > [1]
>
> Right, the problem was that your patch to use the macro was
> applied on a different branch that caused the build to
> fail. Yixun Lan should have caught this problem and rejected
> your patch before sending the pull request when doing
> a 'make dtbs_check'.
>
Sorry, I didn't catch this problem due to test DT together with the
clock patches.. I'll be more careful next time to send a PR without
unmerged cross-tree dependency, thanks for taking care of this..
> This is a common problem with unstructured SoC devices:
> If you can't just use the number from a datasheet, you
> have to wait until the binding has been agreed and merged.
>
> Earlier in the cycle this could have been resolved by
> ensuring the binding change is used as the base for both
> the clk driver and the dts branch, but now you'll have
> to wait until after -rc1 is out to resend.
>
--
Yixun Lan (dlan)
prev parent reply other threads:[~2026-08-11 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 2:42 [GIT PULL] RISC-V SpacemiT Devicetrees for v7.3 Yixun Lan
2026-08-10 16:45 ` Arnd Bergmann
2026-08-11 2:49 ` Troy Mitchell
2026-08-11 7:22 ` Arnd Bergmann
2026-08-11 10:03 ` Yixun Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811100327-GKA277506@kernel.org \
--to=dlan@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=soc@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox