Re: [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support

[Yixun Lan <dlan@kernel.org>]

Hi Sandie,

On 11:33 Mon 09 Nov     , Sandie Cao wrote:
> Add USB device node (b, c, d) to DeepComputing FML13V05 board.
..
> USB A works on otg mode, it isn't configured currently.
Drop it, not really useful to mention there, irrelevant to this patch.

Currently, No USB A port support is merged in mainline code.
FYI, Chunyan submitted a patch for adding peripheral support of USB A.
https://lore.kernel.org/all/20261105103125.2727341-1-chunyan.zhang@linux.spacemit.com/


> - 4 USB-C Ports
      ~~~~~ USB Type-C? less confusing
>      - Port 1: PD 3.0 (65W Max), USB 3.2 Gen 1
>      - Port 2: PD 3.0 (65W Max), USB 3.2 Gen 1, DP 1.4 (4K@60Hz)
>      - Port 3 & 4: USB 3.2 Gen 1

For "Port X" here, is it a naming from FML13V05's schematic?
would be great to mention which specific USB 3.0 controller (Port B, C, D)
 of the SoC it connect to..

> 
> Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
> ---
>  .../spacemit/k3-deepcomputing-fml13v05.dts    | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> index e061233c15a3..bcd533484a73 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> @@ -172,8 +172,58 @@ dldo7: dldo7 {
>  	};
>  };
>  
> +&combophy {
> +	spacemit,apmu = <&syscon_apmu 0x17>;
> +	status = "okay";
> +};
> +
>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_0_cfg>;
>  	status = "okay";
>  };
> +
> +&usb2_host {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +
> +	hub@1 {
> +		compatible = "usb5e3,608";
> +		reg = <1>;
> +	};
> +};
> +
> +&usb2_phy {
> +	status = "okay";
> +};
> +
> +&usb3b_u2phy {
> +	status = "okay";
> +};
> +
> +&usb3b {
> +	phys = <&usb3b_u2phy>, <&combophy 2 PHY_TYPE_USB3>;
> +	phy-names = "usb2-phy", "usb3-phy";
> +	status = "okay";
> +};
> +
> +&usb3c_u2phy {
> +	status = "okay";
> +};
> +
> +&usb3c {
> +	phys = <&usb3c_u2phy>, <&combophy 3 PHY_TYPE_USB3>;
> +	phy-names = "usb2-phy", "usb3-phy";
> +	status = "okay";
> +};
> +
> +&usb3d_u2phy {
> +	status = "okay";
> +};
> +
> +&usb3d {
> +	phys = <&usb3d_u2phy>, <&combophy 4 PHY_TYPE_USB3>;
> +	phy-names = "usb2-phy", "usb3-phy";
> +	status = "okay";
> +};
> -- 
> 2.43.0

-- 
Yixun Lan (dlan)