From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD0EC29B0; Mon, 18 Aug 2025 12:14:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755519298; cv=none; b=pUSRvJn+GLWiCpcBZLug8OIviyADl9ZIzyymS/QwrwZH2rZOTcRXI9tsgCbCjg4hKs4EqrZmxEEDstnisFq85+RX8bYzewoqdIg48Zp43cF9idBOOZdYK3cvibYq/hY3gEJoonecpt9z8NZ3iCGDNOWbnELcST+MKWi9L3hHoNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755519298; c=relaxed/simple; bh=mD40O8ELAQZNuLx/Q1w5PsWpc3asVslfYsz2e2ICqJs=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=euIQXdGvryW25nDWlhC5PKZxWw7/8iftD+ga3VmlttFptfQfrb6NLvPo2q23pwRYIww28BfoT8lbThovezl5FfFEnCsCV8QzoUADGufQ4CBPlkVtxv5eyBgEFexu0yPqJ5XdhNLv8xjP0P3icLspqCEbOSgXXe5pkyR5lK7Hqio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=1hz90Qtb; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="1hz90Qtb" Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57IBFYxq016305; Mon, 18 Aug 2025 14:14:22 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= Di2sJMGDTfc2gFtc34a6qY4519gtg5sAUPBz5vhubF0=; b=1hz90Qtb072d/lZA y9NnyHsNccVQIbaFxcx7E7yMN9BVd6YWYCKylGEN0e+OTGXy865/O0Gbf3dEl9Z1 +pyjnZtqZmY2hzn9RxRMNrPWlLtWLnBzv9SpI7iBuZ/YBnTIyzd+BxQeYYhkAnBf lX0UbccWrDFNhEjef3I/A05Gy8if96eAhsYMdQYBIYX+g0MMFq0OgbfziCesFdFl nXQ1MgcAlJriBhvCSa3kyLIDJFZiBSDm3BbHyZUB9/jrK0ro6YbspzGy9IWCI7bL FHgHd+KEt/UAXCrUnRbJH4HCqt+6p5voVSZk9OWqBUOTtwg3MAsd6wUIGVvnupeu MGwV9Q== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 48jf47p5mr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Aug 2025 14:14:22 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 2B43640058; Mon, 18 Aug 2025 14:11:18 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 5BF7971CEFF; Mon, 18 Aug 2025 14:09:58 +0200 (CEST) Received: from [10.48.87.121] (10.48.87.121) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 18 Aug 2025 14:09:53 +0200 Message-ID: <836b8be6-ec6a-413d-8657-ee02025ebc24@foss.st.com> Date: Mon, 18 Aug 2025 14:09:52 +0200 Precedence: bulk X-Mailing-List: spacemit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 059/114] clk: stm32: stm32mp1: convert from round_rate() to determine_rate() To: , Michael Turquette , "Stephen Boyd" , Sudeep Holla , "Cristian Marussi" , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , "Takao Orito" , Shawn Guo , "Sascha Hauer" , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , "Vladimir Zapolskiy" , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , , Orson Zhai , Baolin Wang , Chunyan Zhang , "Maxime Coquelin" , Alexandre Torgue , Michal Simek , "Maxime Ripard" , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , "Krzysztof Kozlowski" , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , "Ulf Hansson" , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , "Lorenzo Pieralisi" , Nobuhiro Iwamatsu CC: , , , , , , , , , , , , , , , , , , References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-59-b3bf97b038dc@redhat.com> Content-Language: en-US From: Gabriel FERNANDEZ In-Reply-To: <20250811-clk-for-stephen-round-rate-v1-59-b3bf97b038dc@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-18_05,2025-08-14_01,2025-03-28_01 On 8/11/25 17:18, Brian Masney via B4 Relay wrote: > From: Brian Masney > > The round_rate() clk ops is deprecated, so migrate this driver from > round_rate() to determine_rate() using the Coccinelle semantic patch > on the cover letter of this series. > > Signed-off-by: Brian Masney Reviewed-by: Gabriel Fernandez > --- > drivers/clk/stm32/clk-stm32mp1.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/stm32/clk-stm32mp1.c b/drivers/clk/stm32/clk-stm32mp1.c > index b8b45ed22f981df580506f3d4ca801ba11d2bab2..2d9ccd96ec98c05eb836d632bfd9903de60ba1bb 100644 > --- a/drivers/clk/stm32/clk-stm32mp1.c > +++ b/drivers/clk/stm32/clk-stm32mp1.c > @@ -970,12 +970,15 @@ static unsigned long __bestmult(struct clk_hw *hw, unsigned long rate, > return mult; > } > > -static long timer_ker_round_rate(struct clk_hw *hw, unsigned long rate, > - unsigned long *parent_rate) > +static int timer_ker_determine_rate(struct clk_hw *hw, > + struct clk_rate_request *req) > { > - unsigned long factor = __bestmult(hw, rate, *parent_rate); > + unsigned long factor = __bestmult(hw, req->rate, > + req->best_parent_rate); > > - return *parent_rate * factor; > + req->rate = req->best_parent_rate * factor; > + > + return 0; > } > > static int timer_ker_set_rate(struct clk_hw *hw, unsigned long rate, > @@ -1026,7 +1029,7 @@ static unsigned long timer_ker_recalc_rate(struct clk_hw *hw, > > static const struct clk_ops timer_ker_ops = { > .recalc_rate = timer_ker_recalc_rate, > - .round_rate = timer_ker_round_rate, > + .determine_rate = timer_ker_determine_rate, > .set_rate = timer_ker_set_rate, > > }; >