From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E0322E88A8; Mon, 11 Aug 2025 15:38:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754926686; cv=none; b=EKpGrIzWlly3yYbNBmnkWNPgx2uESfGxg5f5ycuLHvfzNIFZZweGd7ybgsX4nIJUQ+xO4Ihil48zMbUP6zvE1eoNORjd42ueMwDb5Qa/ziyMyzVaCYgNAW7ZewgEHDaPkSASPHmSLMItQE/Mv7rHP67byd7KhUmMpgD3qwaYUOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754926686; c=relaxed/simple; bh=CqlyMujMU6ydNDStKnts5DDKJU1MVb00JtDeW/Rdvt0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=lrTeczh9ZsmJyye0BbhS9wu9QZWB+jw0awrxn66XrdSHkznC1M8hYkYflPSkmmd/FXEo/41y0k15X2W6P41GidOpTHXq19ndeQu0FWcpMwL1+Zt83+v++htt/3o7CVhD1TdkUDDjvQsVW6Hh8ksdaG9xvcbzGQnVPOILxgRv7eM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Uo5E0zpz; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uo5E0zpz" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-af95b919093so664720666b.2; Mon, 11 Aug 2025 08:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754926682; x=1755531482; darn=lists.linux.dev; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=2HmgB4i0ef6G9gBd9c3iPtpa4z8Vmw9rM+uJkjjYMMg=; b=Uo5E0zpz9uTDRyAHh2vtBLUgyfOS83eV51Zs76TmX5C1ZECNVX2srYKOcXY5+wYsRx U6JyF4kzB94rTyac1jXJ2QT1U9UdepGVPd9DLy97hJ7/vmPH6NKeY3qJ4uRhckPDItd+ kD8Y6eFsW49IfpWexHuQXcF/ofWr4o0ODWYQTx2qXQ6YCLeYZiQZwIU24QcVLgduA8Pr YqwcvkXvP1c+fgpUdmFGclFuPlqlg4h3djv+lsSQCi6OIsqzhU99IVRKvRdlCrsJ1Ele HP/JaITM+Mc4Ak6z6rGn9T+ABjcDq9m+/XMieOIBGT9OTk1opgAeAQCl81riexQA2Op6 Pj/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754926682; x=1755531482; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2HmgB4i0ef6G9gBd9c3iPtpa4z8Vmw9rM+uJkjjYMMg=; b=KuGq68H3u1aeaWXdjZK0Y6PynCDA2QIIK4W+4R+EEmzaR5Mg2h+tR4M3b83tMg+ZZe ZX4M5VPgiNmn657WLcVJa5avOjzusr3mjCUS7X+NvVxTCdVGDxPf16YY9WsoNStdhWos JkD9eYG17Ohbc4JSvKKY+u60Kf3SmuNWO2YT32vq0HcP61Q3kim4slkcEg+jYOxxF1WV 0rax9D+rNuk8YCRKTxyZjKD6xeoBQuY00AFkgG65agxDkz/n5aUEz0AHS0NBl8Q63ssL 8Ce5UgJmXW5QN7oZz8HKnJ4nUqomXzfsfBvg3IdrBB5P0DlkHZFisuzNl1WTy2JjHbrf 6KeA== X-Forwarded-Encrypted: i=1; AJvYcCVOqNp/LASpbyVyT/2a1O0sFRHyuieA8CCxNv5Vbpgj9U8c6U++CEHiXnzrMyhr+zdWC1oC5A==@lists.linux.dev, AJvYcCVQvXv7K6LPQ94LHQsmkXag45eDj1rKVDXpJmDwPCidge4DPNHzCZjQEnnxc3qNJpQ9+HAWg0s1KKs=@lists.linux.dev, AJvYcCVeVj4L5eV29X1JS6OMCPMwkQTUdIgzerssYxZO1R/Mx0FR/lbzbGxbWifk1dE3epmJvcI3@lists.linux.dev, AJvYcCW4J1SLJA2w4vtcQythvc2S3HUgeYA4N0lOl1abWSGdnYMcBGrI1JAlILCj9ZHKflXgRPpsGYma@lists.linux.dev, AJvYcCX2XCDyQePDTH0SZ8/+jvcmOlHZiWQgQgnpvkL5+r2JorxvL9frAfKskGlDG+CRT8NXRR9l@lists.linux.dev X-Gm-Message-State: AOJu0YwMYkR4tUuEfEwYFy2rbLhVLUpAkAFwU/XiCLIzjaeBLtqmUe0F WfukpU54/w+LRwi2aR+fC6pBanZSsX/yjmKeWocWysCPyRbbm6Y2OV/j X-Gm-Gg: ASbGncuD2zzgqn+9nPpLMU+tqRa6nOzbHpEu3bgUehffb2uYHfdJyxjiFf1thT+R9yS yECTQgd+ThQ97ZwHnrxxVLYwYz7yg/16JVI+jXR6VdsfoPeSdxFHuPcR9k1fHwUmU899LuyX4Ez t37PPjOMnrSBaP+42Ur1IHwoKyxNdzYv+fx7zCJ8yez79BN8Gd9uZ4Tnhbfd9ct4PqTPpZtmI/s +GEVIV1Z9uBVotZ1JnalZaJkSv8P2h17HW1kcq2vvbtcHfFbYfi3EroQxQgjqTr+mY43PTUM2aw fIi/9fs7frSLSMsEkU8StSDn8RyB6LMCo+gScqSG5n2ZYEQ+FPaFJ9tNWleoLYIexlwfKvuQv2n Tz1O06EM4ISUCda1qjAmyjziHPjz9hfX79+y8sRY= X-Google-Smtp-Source: AGHT+IHSK7yv3/D8orY0Pvy2Zzp8DcIZ6EslOLXmLH2atPhWs8y14U6F2aebL6rKGw4mDoY3DumHmw== X-Received: by 2002:a17:907:7ea8:b0:af9:8c1c:b9be with SMTP id a640c23a62f3a-af9c645d565mr1274686466b.14.1754926682117; Mon, 11 Aug 2025 08:38:02 -0700 (PDT) Received: from giga-mm.home ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a21c0afsm2032301266b.117.2025.08.11.08.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 08:38:01 -0700 (PDT) Message-ID: <84788b3be1d340f7a085c0d2a5903fd1032dd9eb.camel@gmail.com> Subject: Re: [PATCH 114/114] clk: fixed-factor: drop round_rate() clk ops From: Alexander Sverdlin To: bmasney@redhat.com, Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?ISO-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Date: Mon, 11 Aug 2025 17:37:58 +0200 In-Reply-To: <20250811-clk-for-stephen-round-rate-v1-114-b3bf97b038dc@redhat.com> References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-114-b3bf97b038dc@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1 Precedence: bulk X-Mailing-List: spacemit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Brian! On Mon, 2025-08-11 at 11:19 -0400, Brian Masney via B4 Relay wrote: > From: Brian Masney >=20 > This driver implements both the determine_rate() and round_rate() clk > ops, and the round_rate() clk ops is deprecated. When both are defined, > clk_core_determine_round_nolock() from the clk core will only use the > determine_rate() clk ops. Also all clk drivers that directly calls > fixed-factor's round_rate() have been migrated over to determine_rate(). > So let's remove the round_rate() clk ops. >=20 > Signed-off-by: Brian Masney Reviewed-by: Alexander Sverdlin > --- > =C2=A0drivers/clk/clk-fixed-factor.c | 16 ---------------- > =C2=A01 file changed, 16 deletions(-) >=20 > diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-facto= r.c > index 79b9a8c57d4b84be990955d8bc3159b818f38d50..de658c9e4c5386a7a8d220743= 22577e0e9efd2b8 100644 > --- a/drivers/clk/clk-fixed-factor.c > +++ b/drivers/clk/clk-fixed-factor.c > @@ -47,21 +47,6 @@ static int clk_factor_determine_rate(struct clk_hw *hw= , > =C2=A0 return 0; > =C2=A0} > =C2=A0 > -static long clk_factor_round_rate(struct clk_hw *hw, unsigned long rate, > - unsigned long *prate) > -{ > - struct clk_fixed_factor *fix =3D to_clk_fixed_factor(hw); > - > - if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) { > - unsigned long best_parent; > - > - best_parent =3D (rate / fix->mult) * fix->div; > - *prate =3D clk_hw_round_rate(clk_hw_get_parent(hw), best_parent); > - } > - > - return (*prate / fix->div) * fix->mult; > -} > - > =C2=A0static int clk_factor_set_rate(struct clk_hw *hw, unsigned long rat= e, > =C2=A0 unsigned long parent_rate) > =C2=A0{ > @@ -87,7 +72,6 @@ static unsigned long clk_factor_recalc_accuracy(struct = clk_hw *hw, > =C2=A0 > =C2=A0const struct clk_ops clk_fixed_factor_ops =3D { > =C2=A0 .determine_rate =3D clk_factor_determine_rate, > - .round_rate =3D clk_factor_round_rate, > =C2=A0 .set_rate =3D clk_factor_set_rate, > =C2=A0 .recalc_rate =3D clk_factor_recalc_rate, > =C2=A0 .recalc_accuracy =3D clk_factor_recalc_accuracy, --=20 Alexander Sverdlin.