From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f196.google.com (mail-dy1-f196.google.com [74.125.82.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BE13199FB0 for ; Sat, 7 Feb 2026 13:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770472191; cv=none; b=Pmo2xc08zNkZbe5PVPAxu6HzuJFL/ZWItfJT3ZKO7uGfZR4KOr9HzmAkftGUsorFKbAQZ5fbD2gy2XkD0mVBfw78jZzFOQDZdFh6l+JcGULWGzlRCuNWrn0TokFq5BT3d7zrtAAM2sMsDSjcSLcz4qDZN+JBqKGKiY+BKC2Re1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770472191; c=relaxed/simple; bh=awClsDQAoaWle+97AQpre6aIGBed3gUQvbTapQ/ZDjA=; h=From:Mime-Version:Content-Type:Date:Message-Id:Subject:To:Cc: References:In-Reply-To; b=nCmSSPnFIx1PTLfl7vIrrB1+4ge9MaEWE+sUNZIw5g+zbzL1RnRPwpOJf4Prhr+g7BeacTaCJcZ56+UbQoSXR2V9pyQP3X/2lZm3jIyjS1clfksfv1sZQukqQJXcInNDIH7BPApz18RhITlqJXeNBxVdZdu0b6ApCBoVXGidITM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ewSAo71V; arc=none smtp.client-ip=74.125.82.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ewSAo71V" Received: by mail-dy1-f196.google.com with SMTP id 5a478bee46e88-2b86d39cd50so182474eec.0 for ; Sat, 07 Feb 2026 05:49:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770472190; x=1771076990; darn=lists.linux.dev; h=in-reply-to:references:cc:to:subject:message-id:date :content-transfer-encoding:mime-version:from:from:to:cc:subject:date :message-id:reply-to; bh=9IzXDpLFwSkLNbwyD+8cYCZma/FvcMBgne+jWBUI0S0=; b=ewSAo71VB0uj5r68f11VIKJKW8kWMXuXO5F+eQtZ+iYJvfqvGLi/LJ/+XW0Dd00NtS Eq/SBiCQKbkdr1YilGXsO5qLRhxiN/AdADQRP0EpkFIzFGfWG/O4e+Fkh6J4bZUkjWil nIeWBZXOzA73381XD8E0/dijKtxpvd8x1S6BDtFAxAKATHrJvtR6VC2VaslImR8egxdX LFY/1pIGpNWnS50fEXVJBE2bOPGG9ASmsBjMIvXkff2YDwthtGXKrvrW2gmhkMmmb1n8 ZH4QjyJy2aQXMHKiC0ZH9sMgGRcOfMT38194Wvi3EjRiiAsB+B9fqxQy3gwoklFUb7ru 7pxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770472190; x=1771076990; h=in-reply-to:references:cc:to:subject:message-id:date :content-transfer-encoding:mime-version:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9IzXDpLFwSkLNbwyD+8cYCZma/FvcMBgne+jWBUI0S0=; b=DfTEy9QyEVHaM1IgRw8eO5c0KoIQI3FAZ+GILAQBHJAmxzUTGR8qw0LhdODWpSa36T IxDYieJYDmSiJJ/7f+mP+t0XzEkwFoqUeSPrYSzPXRVkXi/Mc3K3jlI/osDwx4ZnYJnl knmiDwgoLoNRohDnGrRrLhyyPQdRQ+WMF/OKBMVzLbG7IqvWrfrvIRo2JKeQIT9NheDG jYzQnw4jcUQcv44e2izHkdu4CZ4ESW6vsNMWfV4HQfPZ44Rkq4gSVmBSD73/x+0ttVB+ c7BJMIPumb14V+C9Zs36/XOp5qUYnrD3py7bEicsl5Z42ibDQH+2RZexvVdB6RlGDn0z dxDg== X-Forwarded-Encrypted: i=1; AJvYcCWbpGZ0VPlMsPOEpWwD9EknleqorHNbgh0pM//29t31h6kEWJO6GIal6gxZQzy/5vJ37nQ4nR7UAA==@lists.linux.dev X-Gm-Message-State: AOJu0YwnBFJKUwYMFe6BJd6atnL10kMINjLacw9/XklyVqzqH5CDFU4H wY0UmiyVFqCk05b1g6AKpy0iNFj1omakYXit7JX3vLcmbFZAeSu4coK2 X-Gm-Gg: AZuq6aKHAvkVhnV8xlgJ6CutlyTG17iQeps4rtVb983//j9jrzVYiKA4MkwzJGGAZI3 03fuO7Qm0ou4CEpzSkHcVC22YsoeO9jiorvWGVxT/ICVXzjpwQs/WXTjh4fvXc9yb849jvoHhbV l1n+bWGSpZn28Q51fvkk9ozKVzj4Tea1oAaazbY7y82FoElyiaHTUf7ddC61vxBkyt9Co4CpSV9 9LeGGCBi6ET8HA8zOQQp8j8in3FE4bKH/3WWMnBbmyFREQGgNU33XI9HYxQG3hW/dx8OsvThrkC jSLygfXFUDNcTNBudrbvWCSRkTCpIaGEllQR7cHIzoMH6Cj+sDPBVRqgbq6fitdSGZqfXeBrcb8 YyLnHXpfcJ77rjprPnJAW5nYS1ZRifwE0Desb8jPyasyVw6zTI+skHlloe2oAk7a2vSMfyChAyd 8YCBIfLKhgP9njaQ== X-Received: by 2002:a05:7301:3d19:b0:2b7:f809:9c38 with SMTP id 5a478bee46e88-2b85642b483mr3550098eec.18.1770472190215; Sat, 07 Feb 2026 05:49:50 -0800 (PST) Received: from localhost ([72.11.140.113]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b855c3db30sm3684099eec.21.2026.02.07.05.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 05:49:49 -0800 (PST) From: Troy Mitchell X-Google-Original-From: "Troy Mitchell" Precedence: bulk X-Mailing-List: spacemit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 07 Feb 2026 21:49:47 +0800 Message-Id: Subject: Re: [PATCH v6 2/2] i2c: spacemit: introduce pio for k1 To: "Andi Shyti" , "Troy Mitchell" Cc: "Yixun Lan" , "Alex Elder" , "Aurelien Jarno" , "Michael Opdenacker" , "Troy Mitchell" , , , , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260108-k1-i2c-atomic-v6-0-41b132b70f68@linux.spacemit.com> <20260108-k1-i2c-atomic-v6-2-41b132b70f68@linux.spacemit.com> In-Reply-To: On Wed Jan 14, 2026 at 11:47 PM CST, Andi Shyti wrote: > Hi Troy, > > ... > >> @@ -171,6 +176,16 @@ static int spacemit_i2c_handle_err(struct spacemit_= i2c_dev *i2c) >> return i2c->status & SPACEMIT_SR_ACKNAK ? -ENXIO : -EIO; >> } >> =20 >> +static inline void spacemit_i2c_delay(struct spacemit_i2c_dev *i2c, >> + unsigned int min_us, >> + unsigned int max_us) >> +{ >> + if (i2c->use_pio) >> + udelay(max_us); > > We need some control on how much we want to sleep in atomic. This > can have effects on the whole system. > >> + else >> + usleep_range(min_us, max_us); > > If we assume that max_us =3D min_us * 2 we don't need to pass it as > a parameter. Even better you can use fsleep here which does it > for you. Thanks. I'll use fsleep here and remove max_us. > ... >> +} > > ... > >> + >> + if (i2c->state !=3D SPACEMIT_STATE_IDLE) { >> + val |=3D SPACEMIT_CR_TB; >> + if (i2c->use_pio) >> + val |=3D SPACEMIT_CR_ALDIE; > > Why are we enabling ALDIE here? Should be: if (!i2c->use_pio) > >> + >> + > > please drop one blank line here > >> + if (spacemit_i2c_is_last_msg(i2c)) { >> + /* trigger next byte with stop */ >> + val |=3D SPACEMIT_CR_STOP; >> + >> + if (i2c->read) >> + val |=3D SPACEMIT_CR_ACKNAK; >> + } >> + writel(val, i2c->base + SPACEMIT_ICR); >> + } > > ... > >> @@ -431,41 +605,8 @@ static irqreturn_t spacemit_i2c_irq_handler(int irq= , void *devid) >> =20 >> spacemit_i2c_clear_int_status(i2c, status); >> =20 >> - if (i2c->status & SPACEMIT_SR_ERR) >> - goto err_out; >> - >> - val =3D readl(i2c->base + SPACEMIT_ICR); >> - val &=3D ~(SPACEMIT_CR_TB | SPACEMIT_CR_ACKNAK | SPACEMIT_CR_STOP | SP= ACEMIT_CR_START); >> - >> - switch (i2c->state) { >> - case SPACEMIT_STATE_START: >> - spacemit_i2c_handle_start(i2c); >> - break; >> - case SPACEMIT_STATE_READ: >> - spacemit_i2c_handle_read(i2c); >> - break; >> - case SPACEMIT_STATE_WRITE: >> - spacemit_i2c_handle_write(i2c); >> - break; >> - default: >> - break; >> - } >> - >> - if (i2c->state !=3D SPACEMIT_STATE_IDLE) { >> - val |=3D SPACEMIT_CR_TB | SPACEMIT_CR_ALDIE; >> - >> - if (spacemit_i2c_is_last_msg(i2c)) { >> - /* trigger next byte with stop */ >> - val |=3D SPACEMIT_CR_STOP; >> - >> - if (i2c->read) >> - val |=3D SPACEMIT_CR_ACKNAK; >> - } >> - writel(val, i2c->base + SPACEMIT_ICR); >> - } >> + spacemit_i2c_handle_state(i2c); > > Next time this can be on a separate patch as a preparatory patch > to make the review of this one a bit easier. Thanks. I'll do that. - Troy > >> =20 >> -err_out: >> - spacemit_i2c_err_check(i2c); >> return IRQ_HANDLED; >> } > > Thanks, > Andi