From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5899C1DE4CA for ; Tue, 29 Jul 2025 01:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753753289; cv=none; b=RqULLtAbapyRsIVLlIGUKr18tiAclXCvf14ayJ0yUy8Fpppad0FpedrYzJ2yMCFakLuVIZqC39QSXbSRA/cqA/mQHlVo9uTjxnyfCSD0r/cBfICOmjHck+O6ITGmvk6syXGf8W3IA57VpPeu/GuE899RaROXj/HjyM+CppFHlqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753753289; c=relaxed/simple; bh=7jL0NE4cF4xqYnGuVecwCuQthPBG5AwQZhJM7XTG5Ek=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sSrzh1tQ3Zdu/wRGK9XNrQqCJfw2cwLey1f76B0rnECcHRPxK04baGhpdTp7jQy/O0NBQ0twGDuNeWGsZxQAeJtLVmJj8n51IpCQx1yqpaIGuoDhWwaaPGDkG5lXQZ4v0Y966Z5DdhFUtXh5d1xf/YEOA83oMjUPRrhoAiGTOIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=B9KloKMh; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="B9KloKMh" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 4A82325D07; Tue, 29 Jul 2025 03:41:23 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Ckl6WRtZjqNd; Tue, 29 Jul 2025 03:41:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1753753282; bh=7jL0NE4cF4xqYnGuVecwCuQthPBG5AwQZhJM7XTG5Ek=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=B9KloKMhlJyyRh81m9m/G3F+TnYK+unb5HmSIcZYXv9skznThsPV7h/WJffNlxaJj GgelXZd6oZyPw3DHn2h5K07c7MdBLXmnkcXFhOCDK/lbxmgM2JtehkiPcayyUeZLPA CxOt4PLcDLpw7MfjzJ569Yu1jHgXTqSh42zh47HsACMyiVQg/6sJJZnjh1TTSjYhfZ AFWr+MskYiXsSrZT2kLjXuenqSzj67q532Gvy79Xvk/YwuvxoUDyTLwAXRg6ZCfZEk KOov8Z0BmgN26+ZXXUU1EY2M2Go+57hXmXtLODAkruVnsjzMIf4llmKPDmKGsCh0Pb Sn3Y0xyX8GMMw== Date: Tue, 29 Jul 2025 01:41:01 +0000 From: Yao Zi To: Ze Huang , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Thinh Nguyen , Philipp Zabel Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v7 1/2] dt-bindings: usb: dwc3: add support for SpacemiT K1 Message-ID: References: <20250729-dwc3_generic-v7-0-5c791bba826f@linux.dev> <20250729-dwc3_generic-v7-1-5c791bba826f@linux.dev> Precedence: bulk X-Mailing-List: spacemit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250729-dwc3_generic-v7-1-5c791bba826f@linux.dev> On Tue, Jul 29, 2025 at 12:33:55AM +0800, Ze Huang wrote: > Add support for the USB 3.0 Dual-Role Device (DRD) controller embedded > in the SpacemiT K1 SoC. The controller is based on the Synopsys > DesignWare Core USB 3 (DWC3) IP, supporting USB3.0 host mode and USB 2.0 > DRD mode. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Ze Huang > --- > .../devicetree/bindings/usb/spacemit,k1-dwc3.yaml | 124 +++++++++++++++++++++ > 1 file changed, 124 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/spacemit,k1-dwc3.yaml b/Documentation/devicetree/bindings/usb/spacemit,k1-dwc3.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..7007e2bd42016ae0e50c4007e75d26bada34d983 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/spacemit,k1-dwc3.yaml > @@ -0,0 +1,124 @@ ... > + resets: > + items: > + - description: USB3.0 AHB reset > + - description: USB3.0 VCC reset > + - description: USB3.0 PHY reset > + - description: PCIE0 global reset (for combo phy) Why should the USB driver takes care of the PCIe stuff? This sounds strange to me. > + reset-names: > + items: > + - const: ahb > + - const: vcc > + - const: phy > + - const: pcie0 Best regards, Yao Zi