From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92C072877EF for ; Tue, 12 Aug 2025 13:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755006846; cv=none; b=tAnC5v+cvugFebojXOML79ALMUpX5UBrO5AB5+EvbmJSGYApjGYZqCddSQ+R76r9Rln7JPMIUdBFlUFFAEb31brhCRiQjaezhWANKgxlQYr2/8iVUpZh/DSSdFUjlVTzstrly46p1Pt2QlRkK3LlD8S20ghrdVpptdrfAJ5XrFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755006846; c=relaxed/simple; bh=Q//s+/zCNBEzjNslOllCQGV4nFuLBeOueQxvALXBZS0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=c0H7sBwLOB8dkLUo+m88dmGRKGMphlpecy+4AdjjuHKen7IaoSDLXTA8x/LRoWYCvRf9nG6BwHW+RuX2ukMZHJWO4lzOexHGFQYec8MH/AY1K7hPpfb9v0NkjbbK6jNUWZxu3mPaCkaH1jesBHRBJCsuKtDsyWNQcAcLP8Q4qYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FsOBs53M; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FsOBs53M" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755006843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q//s+/zCNBEzjNslOllCQGV4nFuLBeOueQxvALXBZS0=; b=FsOBs53MFI0jFR+2T3HZfYzHe/dHKoSUNhMoSBaobcr77iFZmWKEnd7i6AAHdtzlJkdBEl kp7lVaUVT/jutIpiaJi7eRiEJ/BYN98gGLoS98vppqx/GdDiuudGJ/ktsycbezuDgVmln4 U0xYXm5hHSNNh9lA4cylY+S9O8F7nT4= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-xKQOfDO1NayTesM9NVM5-w-1; Tue, 12 Aug 2025 09:54:02 -0400 X-MC-Unique: xKQOfDO1NayTesM9NVM5-w-1 X-Mimecast-MFC-AGG-ID: xKQOfDO1NayTesM9NVM5-w_1755006842 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4b0a3557d05so117958651cf.2 for ; Tue, 12 Aug 2025 06:54:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755006842; x=1755611642; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q//s+/zCNBEzjNslOllCQGV4nFuLBeOueQxvALXBZS0=; b=UL/GGk0NPH3OqPpiSeCSYqhNUu/a98x94YDM8yaBJFjHGe6du62WDKQ5LEQ6GfSFPh /KYsosNlHLDYBK5lccFqlIfLZbLVJ9s67tUtc3HaPxWR0M4OsSMBu4LYi6qOMC6qo6Jt zgICyKUBytA84HJe09Q3BMD/253+KnDD6DeseYbcbT26pXc2KC1ljpPWvKtqLEj87CQP uak74HjCDc3HUfwm5phRXkwnEHUfC58L5sL69UXKH1ciJ04BMVUpMrNb/sfEsnj631wT 6pvrmlPjEkpeUW4/Ssw40fY93pzyI+NxNPuVSNdG1eV6R60dpfOx34P7f9MdneREt6Re 0UVw== X-Forwarded-Encrypted: i=1; AJvYcCWv8vUtcbyC2x4AGlXGBQQyYS/zS0a+RgWCdtIQ0wzIP5JC4NoXFgNbQ9TecL8OyNIFUE2Jm2w7cA==@lists.linux.dev X-Gm-Message-State: AOJu0YzMthmpOSY8BRnG01LTx5bYU7gjrBrrBzP0k0JZtEI2j+XVdTgi D/4FB+wz0ZmGlFpCXZRuk9LeIP4THfopziCRYzT+mIJGKMF/pxTiAdKh899lTz/CU5vWhCrqvwf X+rhdvijCmjAZDblgd04WcnytXEBNDVsOq0Dt9mvqKlbMzCZZ/hUuoJ9IVxLJ X-Gm-Gg: ASbGncsA8pNDI3HMEibmw3/0dKG12ee4lvAj6VvXMeQjdzVkgzBuIWzA9GEBgBCeItI FMjJRZ5tSLgzJjxlzDfzxicVovq1xadqFEicOG56bKHsC46n+IoSFBn3oUT/DxvSCsPD9YWHDAP 2rRPyv4tFCf5x4DCJcwt/CS9w+DNxV+jkBwrOPw7RmIzOg8pBdaST20Zxz4nn3mPsIUrDaPKiDN 5AKydcuRbDODIXf7epGuaGdVAOyw/zx5/apmxxoF44INcBEdNMuoyPM2XxyXz1qrpwrGFSugvwi w3DW6+kZXHKJxA09j3eo3pJbasjFJKjYbDt7y4rv0LcpQk44+u9sMmenNv4yzLc= X-Received: by 2002:a05:622a:30c:b0:4a4:2c4c:ccb3 with SMTP id d75a77b69052e-4b0aed36723mr265510491cf.38.1755006841717; Tue, 12 Aug 2025 06:54:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHL0wdDdlaxY3Jk0TgFfLYMOMEPwCaVnL7cxWLBN3HaRHoOlakRNGI4PvbhwBJNSUpcz9s5eQ== X-Received: by 2002:a05:622a:30c:b0:4a4:2c4c:ccb3 with SMTP id d75a77b69052e-4b0aed36723mr265508911cf.38.1755006840909; Tue, 12 Aug 2025 06:54:00 -0700 (PDT) Received: from x1 (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4b0aa1efe78sm75493211cf.8.2025.08.12.06.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 06:54:00 -0700 (PDT) Date: Tue, 12 Aug 2025 09:53:54 -0400 From: Brian Masney To: Icenowy Zheng Cc: Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Subject: Re: [PATCH 000/114] clk: convert drivers from deprecated round_rate() to determine_rate() Message-ID: References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> Precedence: bulk X-Mailing-List: spacemit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: G3gQdOiLXhyzpATG4XS_yKUcBuUPgamo48kAMSRnjow_1755006842 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 12, 2025 at 09:39:45PM +0800, Icenowy Zheng wrote: > I was doing a patch to add divider setting support to clk-th1520-ap > driver and sent patch now, should I remove round_rate from the next > revision and just keep determine_rate? Is it safe to do this even if > this patchset is not merged? Yes, you only need to implement the determine_rate() clk op. Please remove any references to the round_rate() clk op from your driver. If you implement both, then only the determine_rate() clk op is actually used by the clk core. > In addition, will the clk_round_rate() API exported to other subsystems > be affected? No, that will stay as is, and with the same name. The underlying implementation in the clk core uses the determine_rate() clk op. Brian