Re: [PATCH net-next 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac

Inochi Amaoto
2026-01-20T11:40:01Z

On Tue, Jan 20, 2026 at 10:55:43AM +0000, Yao Zi wrote:
> On Tue, Jan 20, 2026 at 12:36:06PM +0800, Inochi Amaoto wrote:
> > The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare
> > MAC (version 5.40a) with some extra clock.
> >
> > Add necessary compatible string for this device.
> >
> > Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> > ---
> > .../devicetree/bindings/net/snps,dwmac.yaml | 3 +
> > .../bindings/net/spacemit,k3-dwmac.yaml | 107 ++++++++++++++++++
> > 2 files changed, 110 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
>
> ...
>
> > diff --git a/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
> > new file mode 100644
> > index 000000000000..58dd98f79e8a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
>
> ...
>
> > + clocks:
> > + minItems: 3
> > + items:
> > + - description: GMAC main clock
> > + - description: PTP clock
> > + - description: TX clock
> > + - description: PHY clock
>
> Why does the MAC require "phy" clock? Shouldn't this be handled in PHY
> driver instead, or I get its meaning wrong?
>

IIRC, the "phy" clock is used to pass the phy from the mac core, I will
double check if it is possible to connect to the phy directly.

> Also, I don't see "phy" clock is acquired anywhere in the driver. Is it
> really necessary for the MAC?
>

This is a mistake, I remove this by accident, if it is necessary, I
will add this in the next version.

Regards,
Inochi