Re: [PATCH v5 1/9] dt-bindings: mmc: spacemit,sdhci: add pinctrl support for voltage switching

Krzysztof Kozlowski
2026-03-31T11:11:58Z

On 31/03/2026 12:58, Ulf Hansson wrote:
>>> + - default
>>> + - state_uhs
>>
>> Instead: uhs
>
> While I agree that "uhs" would be better, we have tried to stick with
> "state_uhs" for legacy and consistency reasons with other mmc
> controllers.
>
> No strong opinion though, what do you think?
>

I missed that it is already present in other places. Is the name coming
from any other referenced schema like mmc-controller? Does the existing
common driver code expect state_uhs?

If yes, then go with state_uhs, if not then let's switch to new name.
Old conventions in the bindings can be changed, we already do many
things differently than 10 years ago (e.g. no underscores in node and
property names).

But followup question - the binding is called sdhci, so maybe sdhci
common schema should be referenced?

Best regards,
Krzysztof