Re: [PATCH v5 1/9] dt-bindings: mmc: spacemit,sdhci: add pinctrl support for voltage switching

Ulf Hansson
2026-03-31T11:26:56Z

On Tue, 31 Mar 2026 at 13:11, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 31/03/2026 12:58, Ulf Hansson wrote:
> >>> + - default
> >>> + - state_uhs
> >>
> >> Instead: uhs
> >
> > While I agree that "uhs" would be better, we have tried to stick with
> > "state_uhs" for legacy and consistency reasons with other mmc
> > controllers.
> >
> > No strong opinion though, what do you think?
> >
>
> I missed that it is already present in other places. Is the name coming
> from any other referenced schema like mmc-controller? Does the existing
> common driver code expect state_uhs?

No common schema or binding states that it must be "state_uhs".

It's all described on a per-controller basis, but I was thinking we
should perhaps make it common at some point.

>
> If yes, then go with state_uhs, if not then let's switch to new name.
> Old conventions in the bindings can be changed, we already do many
> things differently than 10 years ago (e.g. no underscores in node and
> property names).

Okay, let's go with solely "uhs" then.

At some point we should make this part of the common mmc-controller
bindings too.

>
> But followup question - the binding is called sdhci, so maybe sdhci
> common schema should be referenced?

Yes, that seems reasonable.

Kind regards
Uffe