From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6A43311C0E; Mon, 11 Aug 2025 16:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754928161; cv=none; b=RqO4mj5f0cw52EGseR9koThzZLtI/0iqzKFy/tEExs3N7LxwmlVBJY6ARWaRo5lVcZSd6xQxFQfP/WdCcCmgsyfPaqqnvEjk9Bu0OS0Ac4PAIhchQMpXcEnJnPtHQWKGLuvN6GwiSPjmlJstD1e/xal3i+zqPhPGFSUcHT58dYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754928161; c=relaxed/simple; bh=M33qPuWnVVgzCedegGUFoIha4X57RIz2xTh8sZTNpAA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ijY0ZualkxFFbD5VHbPBO//P889jQNhS32nwJUAnebKijshnGjEcPP2Dc3gGPeq74bmIqT7DundrnKAluzsbUBceClYTXTgUUVS5zhhlds5SdXyKlLkAzlMmiHbi5LFzmd49gWErm4ugSo+5qBpb6twCQQMjvSMVo2XVLQb4Y9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e1pCFoNH; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e1pCFoNH" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-af98b77d2f0so842556566b.3; Mon, 11 Aug 2025 09:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754928158; x=1755532958; darn=lists.linux.dev; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=qaouqb4fO7JIvY1JD8PEt300KWG5mGmc4W0R7yQs6hc=; b=e1pCFoNHR5vsfr1dciZ+Oe8TAZc9btceS8Im6lswYXTwgOeiMdrAvE42+4JLKQNVzq +Hm3L5PO15KLMd1F89TDotzhqVIOlW13YXdsY0usTJFVd+MRlnfZjLui/1PHQCnPCJwm PNkA1xn1zJOpR18QdsylBOl/w86pdYFAl89hr8tJmulrn7sJ7vFCV1nsM577ACFLtAY6 hBWStqHiplY7bpRAw3Oi85xjKCBF6qG939O2AT9WOxNqs8ghtoRIlH3VVhFdmN82Ey0h HmpRAS9IjGgihdyQgRVtB2gutL8E06B9ym4ExCwK/KS8EDKAf5BGDRj5SjSxCAwbnQqy EoZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754928158; x=1755532958; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qaouqb4fO7JIvY1JD8PEt300KWG5mGmc4W0R7yQs6hc=; b=cluXZjklD/XEXVgEsi8BxeuXhljFUwViWwPRSgZPfUvSMzOo9LkN6l+WlWocQfgGgJ SC6k8MIzPmDMAC4mpvLbCQIf3j+SoNvVYI3p/SH79jO/dEUgYrBJUEfSKp9p8NHZdi2X x5j66cM3dDOr7PZ7ODE+TWE4JcAJYjIsoFdw89sTwmscEfPy6UZD5g3yne4zO4pyQSoY /qGXLxQsgLPY67InbxIvbUf5dpq/4Uyp1GPooho6AhY12tAQuQYgRKS9pDv7OjLbnJl6 ETd/tqzEKstK40Mho6Tw2xw28NS1aw45TquhQRx+KHOkLZciP+xURaSgtCxaNKPSgRD3 8y8A== X-Forwarded-Encrypted: i=1; AJvYcCVMEn90Kx3+yj5NVVcrEbTUqbNVY4IS5nKulzG1nVl2KvKMq5eViUjOjoweXCz9yD3sbQIXLQ==@lists.linux.dev, AJvYcCVQp/1Cyqt+10FU37j3U6az05abdr9xeMUiwkQtaSsXYfcb4NB69idk3UlDPEtHb6KORALI@lists.linux.dev, AJvYcCVRjiZ2nt6lA0hjDUVaxA3vZ1L+cmyvSZ957FUlNI4wRPjZ9Q4BqG0LRkhE3dXzlzIaOB6lka0C@lists.linux.dev, AJvYcCW2p/VC0jD72/yQDSgeqe7tXEJsUScCa4RHtatZfcSoFHadGtzs1eeYR6oLVkcDwcuLpWbFXHY8/Mw=@lists.linux.dev, AJvYcCWZXBwOiAiHaMKSNv/Si3tcqn10zPJIuiw690ohUrPBQgwnE6LPqVmcX/dkukj2o107BI5Z@lists.linux.dev X-Gm-Message-State: AOJu0YxtwUdCuyHtWDayGdRaonhRyuqhhI/0ZubaIjGd+SHZq4FNPWgn S02KmN+oshKCLKZsg2Xp4hrgKyLjRHMcQ19MelXod5I0hlv5nHuNTeHp X-Gm-Gg: ASbGncsJytQjQQjC63iTs6PZhueoChjEUEg4/TxdGO7WyjOZ0MXdworkVHOCsSeWI6g eRWEE2u0rsaFwCPL7vXLNqSB+k7IJoSMUmOiMHav97MUZFaXYp4wAXarBp0ua/y2rvPtylObVid j4TY4wDGpp75jpPpN9lIaRrHodSEtZYWmNEgKb+1c5gf9S05lqcH7CeMQxsn2gyVqQ4uDnVoLhK pZ0GLNUJUC7qtqGwMdewvcpj8l7MKdO1S0YV0g/x4bktnX5ICuHGmHIM3hA+/SVUEpRfADwxH/Z hhuSmEB1bsCukqZCwtwse4v7u3BqxbTe1HmaAPipEVpfDGImmTmCje6IFDCNlOGwUPq2+bXJCvz dUtozOWGk6EPPE7EB+Ki4m3SrCI6e3Z6MhJA1EPw= X-Google-Smtp-Source: AGHT+IFlPGC8RqUZcNmE1sb0v/JytUS2YpnMYnX0fy/68mQiQooD3eH6nJnAu7hadMRuF3cZL/qgqg== X-Received: by 2002:a17:907:7f1a:b0:ae0:d78a:2366 with SMTP id a640c23a62f3a-af9c63b0a5bmr1282562266b.4.1754928157418; Mon, 11 Aug 2025 09:02:37 -0700 (PDT) Received: from giga-mm.home ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a1e6cecsm2050387666b.70.2025.08.11.09.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 09:02:36 -0700 (PDT) Message-ID: Subject: Re: [PATCH 111/114] clk: divider: remove round_rate() in favor of determine_rate() From: Alexander Sverdlin To: bmasney@redhat.com, Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?ISO-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Date: Mon, 11 Aug 2025 18:02:33 +0200 In-Reply-To: <20250811-clk-for-stephen-round-rate-v1-111-b3bf97b038dc@redhat.com> References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-111-b3bf97b038dc@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1 Precedence: bulk X-Mailing-List: spacemit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2025-08-11 at 11:19 -0400, Brian Masney via B4 Relay wrote: > From: Brian Masney >=20 > This driver implements both the determine_rate() and round_rate() clk > ops, and the round_rate() clk ops is deprecated. When both are defined, > clk_core_determine_round_nolock() from the clk core will only use the > determine_rate() clk ops. Also all clk drivers that directly calls > divider's round_rate() have been migrated over to determine_rate(). So > let's remove the round_rate() clk ops. >=20 > Signed-off-by: Brian Masney Reviewed-by: Alexander Sverdlin > --- > =C2=A0drivers/clk/clk-divider.c | 23 ----------------------- > =C2=A01 file changed, 23 deletions(-) >=20 > diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c > index c1f426b8a5043cb5a1de08e1da385928ec54a2ed..2601b6155afb7391c6a0ffb91= c58fa66cde98197 100644 > --- a/drivers/clk/clk-divider.c > +++ b/drivers/clk/clk-divider.c > @@ -431,27 +431,6 @@ long divider_ro_round_rate_parent(struct clk_hw *hw,= struct clk_hw *parent, > =C2=A0} > =C2=A0EXPORT_SYMBOL_GPL(divider_ro_round_rate_parent); > =C2=A0 > -static long clk_divider_round_rate(struct clk_hw *hw, unsigned long rate= , > - unsigned long *prate) > -{ > - struct clk_divider *divider =3D to_clk_divider(hw); > - > - /* if read only, just return current value */ > - if (divider->flags & CLK_DIVIDER_READ_ONLY) { > - u32 val; > - > - val =3D clk_div_readl(divider) >> divider->shift; > - val &=3D clk_div_mask(divider->width); > - > - return divider_ro_round_rate(hw, rate, prate, divider->table, > - =C2=A0=C2=A0=C2=A0=C2=A0 divider->width, divider->flags, > - =C2=A0=C2=A0=C2=A0=C2=A0 val); > - } > - > - return divider_round_rate(hw, rate, prate, divider->table, > - =C2=A0 divider->width, divider->flags); > -} > - > =C2=A0static int clk_divider_determine_rate(struct clk_hw *hw, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct clk_rate_request *req) > =C2=A0{ > @@ -527,7 +506,6 @@ static int clk_divider_set_rate(struct clk_hw *hw, un= signed long rate, > =C2=A0 > =C2=A0const struct clk_ops clk_divider_ops =3D { > =C2=A0 .recalc_rate =3D clk_divider_recalc_rate, > - .round_rate =3D clk_divider_round_rate, > =C2=A0 .determine_rate =3D clk_divider_determine_rate, > =C2=A0 .set_rate =3D clk_divider_set_rate, > =C2=A0}; > @@ -535,7 +513,6 @@ EXPORT_SYMBOL_GPL(clk_divider_ops); > =C2=A0 > =C2=A0const struct clk_ops clk_divider_ro_ops =3D { > =C2=A0 .recalc_rate =3D clk_divider_recalc_rate, > - .round_rate =3D clk_divider_round_rate, > =C2=A0 .determine_rate =3D clk_divider_determine_rate, > =C2=A0}; > =C2=A0EXPORT_SYMBOL_GPL(clk_divider_ro_ops); --=20 Alexander Sverdlin.