From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Guodong Xu" <guodong@riscstar.com>,
"Vinod Koul" <vkoul@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Yixun Lan" <dlan@gentoo.org>,
"Duje Mihanović" <duje.mihanovic@skole.hr>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>
Cc: Alex Elder <elder@riscstar.com>,
Vivian Wang <wangruikang@iscas.ac.cn>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev
Subject: Re: [PATCH v2 7/8] riscv: dts: spacemit: Enable PDMA0 on Banana Pi F3 and Milkv Jupiter
Date: Tue, 1 Jul 2025 09:36:30 +0200 [thread overview]
Message-ID: <ebc16dbe-2405-4956-91a0-bcce9f199326@kernel.org> (raw)
In-Reply-To: <20250701-working_dma_0701_v2-v2-7-ab6ee9171d26@riscstar.com>
On 01/07/2025 07:37, Guodong Xu wrote:
> Enable the PDMA0 on the SpacemiT K1-based Banana Pi F3 and Milkv Jupiter
> boards by setting its status to "okay".
>
> Signed-off-by: Guodong Xu <guodong@riscstar.com>
> ---
> v2: added pdma0 enablement on Milkv Jupiter
> ---
> arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 4 ++++
> arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> index fe22c747c5012fe56d42ac8a7efdbbdb694f31b6..39133450e07f2cb9cb2247dc0284851f8c55031b 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> @@ -45,3 +45,7 @@ &uart0 {
> pinctrl-0 = <&uart0_2_cfg>;
> status = "okay";
> };
> +
> +&pdma0 {
Does not look like placed according to DTS coding style. What sort of
ordering Spacemit follows?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-01 7:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 5:36 [PATCH v2 0/8] dmaengine: mmp_pdma: Add SpacemiT K1 SoC support with 64-bit addressing Guodong Xu
2025-07-01 5:36 ` [PATCH v2 1/8] dt-bindings: dma: marvell,mmp-dma: Add SpacemiT K1 PDMA support Guodong Xu
2025-07-01 7:35 ` Krzysztof Kozlowski
2025-07-01 9:52 ` Guodong Xu
2025-07-02 20:38 ` Krzysztof Kozlowski
2025-07-01 5:36 ` [PATCH v2 2/8] dmaengine: mmp_pdma: Add optional clock support Guodong Xu
2025-07-01 5:36 ` [PATCH v2 3/8] dmaengine: mmp_pdma: Add optional reset controller support Guodong Xu
2025-07-01 5:36 ` [PATCH v2 4/8] dmaengine: mmp_pdma: Add operations structure for controller abstraction Guodong Xu
2025-07-01 5:36 ` [PATCH v2 5/8] dmaengine: mmp_pdma: Add SpacemiT K1 PDMA support with 64-bit addressing Guodong Xu
2025-07-01 5:37 ` [PATCH v2 6/8] riscv: dts: spacemit: Add PDMA0 node for K1 SoC Guodong Xu
2025-07-01 7:37 ` Krzysztof Kozlowski
2025-07-01 8:19 ` Guodong Xu
2025-07-01 5:37 ` [PATCH v2 7/8] riscv: dts: spacemit: Enable PDMA0 on Banana Pi F3 and Milkv Jupiter Guodong Xu
2025-07-01 7:36 ` Krzysztof Kozlowski [this message]
2025-07-01 8:48 ` Guodong Xu
2025-07-01 9:02 ` Krzysztof Kozlowski
2025-07-01 10:04 ` Guodong Xu
2025-07-01 5:37 ` [PATCH v2 8/8] riscv: defconfig: Enable MMP_PDMA support for SpacemiT K1 SoC Guodong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebc16dbe-2405-4956-91a0-bcce9f199326@kernel.org \
--to=krzk@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=dmaengine@vger.kernel.org \
--cc=duje.mihanovic@skole.hr \
--cc=elder@riscstar.com \
--cc=guodong@riscstar.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=vkoul@kernel.org \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox