From: Dwight Engen <dwight.engen@oracle.com>
To: sparclinux@vger.kernel.org
Subject: [PATCH] sunvdc: don't dereference port->disk before disk probe finishes
Date: Tue, 27 Jan 2015 17:51:52 +0000 [thread overview]
Message-ID: <1422381112-21571-1-git-send-email-dwight.engen@oracle.com> (raw)
If the backing file for a vdisk is not present in the service domain an
ldc reset can occur during the initial port/disk probing. The ldc reset
logic was dereferencing port->disk, which may not have been setup yet.
Guard against this case.
Orabug: 20362258
Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
---
drivers/block/sunvdc.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c
index 4b911ed..7587a8c 100644
--- a/drivers/block/sunvdc.c
+++ b/drivers/block/sunvdc.c
@@ -938,6 +938,8 @@ err_out_free_tx_ring:
vdc_free_tx_ring(port);
err_out_free_ldc:
+ flush_work(&port->ldc_reset_work);
+ del_timer_sync(&port->ldc_reset_timer);
vio_ldc_free(&port->vio);
err_out_free_port:
@@ -1017,6 +1019,9 @@ static void vdc_ldc_reset_timer(unsigned long _arg)
struct vio_driver_state *vio = &port->vio;
unsigned long flags;
+ if (!port->disk)
+ return;
+
spin_lock_irqsave(&vio->lock, flags);
if (!(port->vio.hs_state & VIO_HS_COMPLETE)) {
pr_warn(PFX "%s ldc down %llu seconds, draining queue\n",
@@ -1048,6 +1053,9 @@ static void vdc_ldc_reset(struct vdc_port *port)
assert_spin_locked(&port->vio.lock);
pr_warn(PFX "%s ldc link reset\n", port->disk_name);
+ if (!port->disk)
+ return;
+
blk_stop_queue(port->disk->queue);
vdc_requeue_inflight(port);
vdc_port_down(port);
--
1.7.1
next reply other threads:[~2015-01-27 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 17:51 Dwight Engen [this message]
2015-03-02 5:46 ` [PATCH] sunvdc: don't dereference port->disk before disk probe finishes David Miller
2015-03-30 16:42 ` chris hyser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422381112-21571-1-git-send-email-dwight.engen@oracle.com \
--to=dwight.engen@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).