From: Andreas Larsson <andreas@gaisler.com>
To: Thorsten Blum <thorsten.blum@linux.dev>,
"David S. Miller" <davem@davemloft.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Dawei Li <dawei.li@shingroup.cn>, Sam Ravnborg <sam@ravnborg.org>,
Randy Dunlap <rdunlap@infradead.org>
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparc/irq: Use str_enabled_disabled() helper function
Date: Fri, 17 Jan 2025 16:10:50 +0100 [thread overview]
Message-ID: <19acced3-1935-4eb0-9410-e19bd4196f5a@gaisler.com> (raw)
In-Reply-To: <20250115090344.918290-2-thorsten.blum@linux.dev>
On 2025-01-15 10:03, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> arch/sparc/kernel/irq_64.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/sparc/kernel/irq_64.c b/arch/sparc/kernel/irq_64.c
> index 01ee800efde3..aff0d24f8c6f 100644
> --- a/arch/sparc/kernel/irq_64.c
> +++ b/arch/sparc/kernel/irq_64.c
> @@ -22,6 +22,7 @@
> #include <linux/seq_file.h>
> #include <linux/ftrace.h>
> #include <linux/irq.h>
> +#include <linux/string_choices.h>
>
> #include <asm/ptrace.h>
> #include <asm/processor.h>
> @@ -170,7 +171,7 @@ static void __init irq_init_hv(void)
>
> pr_info("SUN4V: Using IRQ API major %d, cookie only virqs %s\n",
> hv_irq_version,
> - sun4v_cookie_only_virqs() ? "enabled" : "disabled");
> + str_enabled_disabled(sun4v_cookie_only_virqs()));
> }
>
> /* This function is for the timer interrupt.*/
Reviewed-by: Andreas Larsson <andreas@gaisler.com>
Picking this up to my for-next.
Thanks,
Andreas
prev parent reply other threads:[~2025-01-17 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 9:03 [PATCH] sparc/irq: Use str_enabled_disabled() helper function Thorsten Blum
2025-01-17 15:10 ` Andreas Larsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19acced3-1935-4eb0-9410-e19bd4196f5a@gaisler.com \
--to=andreas@gaisler.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=dawei.li@shingroup.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).