From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowmini Varadhan Date: Sat, 04 Apr 2015 11:27:14 +0000 Subject: Re: [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Message-Id: <20150404112714.GA2117@oracle.com> List-Id: References: <8406d119fb885255387a400551de994cb4a4c331.1427761300.git.sowmini.varadhan@oracle.com> <1428008044.20500.272.camel@kernel.crashing.org> <20150403182852.GI26158@oracle.com> <1428095210.20500.291.camel@kernel.crashing.org> In-Reply-To: <1428095210.20500.291.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Benjamin Herrenschmidt Cc: aik@au1.ibm.com, anton@au1.ibm.com, paulus@samba.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net One last question before I spin out v9.. the dma_mask code is a bit confusing to me, so I want to make sure... the code is > if (limit + tbl->it_offset > mask) { > limit = mask - tbl->it_offset + 1; > /* If we're constrained on address range, first try > * at the masked hint to avoid O(n) search complexity, > * but on second pass, start at 0 in pool 0. > */ > if ((start & mask) >= limit || pass > 0) { > spin_unlock(&(pool->lock)); > pool = &(tbl->pools[0]); > spin_lock(&(pool->lock)); > start = pool->start; So here I would need to mark need_flush to true, right? --Sowmini