From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C369A80631; Tue, 10 Sep 2024 01:56:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725933380; cv=none; b=j+GmlGUUR/Wtbu+1mnfVYRI+TfoZA9WsMalanRMD6yipFjZUW9b104u99ukZn6If6bMkQInZQ/4B4lm+zChkHry7v0iMKbtajEy43PqCkssepNvsIwnGNkbHBtc97xixJwSfrW5/RsU/ucIRClIRgv/HD6QBnHJ/WZOWyd8Ns6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725933380; c=relaxed/simple; bh=hQIohTpGoGCWnimJ1WTILi++IMB0fJOotB8xmPurEMY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gMBWHGyDo5n0FCzFJ4PGCr4W1F+xNXXtakeJIOHhNG3bhueEbx1WJbCamSYEN7NEOYcg6/AUbVSbswMtji1wS9tkS70WXZAR6apkOHWThd8h8Bf4yZsAPjQbXC8Z3qlfQycEIMI+HF+ALNTvkKjwYgApvDHbbnPmaqb2ASHFdpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LsjAGTQM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LsjAGTQM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D09B3C4CEC5; Tue, 10 Sep 2024 01:56:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725933379; bh=hQIohTpGoGCWnimJ1WTILi++IMB0fJOotB8xmPurEMY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LsjAGTQMGnJ6P2MG1V7Cg14/mW7M47zCU3SUxtCsppTwztGealCF8izjpQT2zu61A wYHXnyY4N0r09fOMnUWI5YC3b4HmKxm+Ay0HQTYrk+Dm1IEMe0T8CAGnDfTpmaTgdb WBrDLGImIhSrlix8oxBiFCHVhhDVCkXVX3PGTjURUIgLMdPDjJ3b7BwdShJQ4BfDaj GnnwTU0+HMb7C05k51WOPUbMUik7MLxyhB5Buwf1hXG0dLn9zUHLsMTQJsQ/D3cb/i h+uqGxW9xZ5PAiQLKeH5dZLeHwdme2LgmmdAPBg0rfO8+OcOXh7k+PNEZcNV0ansmm /T+2TYSXw2xIw== Date: Mon, 9 Sep 2024 18:56:17 -0700 From: Jakub Kicinski To: Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , "=?UTF-8?B?QmrDtnJuIFTDtnBl?= =?UTF-8?B?bA==?=" , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Sumit Semwal , "Christian =?UTF-8?B?S8O2bmln?=" , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Taehee Yoo , Willem de Bruijn , Kaiyuan Zhang Subject: Re: [PATCH net-next v25 06/13] memory-provider: dmabuf devmem memory provider Message-ID: <20240909185617.79b0d3fa@kernel.org> In-Reply-To: <20240909054318.1809580-7-almasrymina@google.com> References: <20240909054318.1809580-1-almasrymina@google.com> <20240909054318.1809580-7-almasrymina@google.com> Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 9 Sep 2024 05:43:11 +0000 Mina Almasry wrote: > diff --git a/include/net/netmem.h b/include/net/netmem.h > index 5eccc40df92d..8a6e20be4b9d 100644 > --- a/include/net/netmem.h > +++ b/include/net/netmem.h > @@ -8,6 +8,7 @@ > #ifndef _NET_NETMEM_H > #define _NET_NETMEM_H > > +#include > #include This should be in the previous patch, I think. page_address() etc. > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 52659db2d765..c737200f4fac 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -11,6 +11,7 @@ > #include > #include > > +#include > #include > #include > > @@ -24,8 +25,10 @@ > > #include > > +#include "mp_dmabuf_devmem.h" > #include "netmem_priv.h" > #include "page_pool_priv.h" > +#include "mp_dmabuf_devmem.h" nit: duplicate include With that: Reviewed-by: Jakub Kicinski -- pw-bot: cr