sparclinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zijun Hu <zijun_hu@icloud.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"James Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Thomas Weißschuh" <thomas@t-8ch.de>,
	"Zijun Hu" <zijun_hu@icloud.com>,
	linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev,
	linux-sound@vger.kernel.org, sparclinux@vger.kernel.org,
	linux-block@vger.kernel.org, linux-cxl@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net, arm-scmi@vger.kernel.org,
	linux-efi@vger.kernel.org, linux-gpio@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org, linux-hwmon@vger.kernel.org,
	linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-serial@vger.kernel.org,
	netdev@vger.kernel.org, "Zijun Hu" <quic_zijuhu@quicinc.com>,
	"Alison Schofield" <alison.schofield@intel.com>,
	"Takashi Sakamoto" <o-takashi@sakamocchi.jp>
Subject: [PATCH v4 00/11] driver core: Constify API device_find_child()
Date: Wed, 11 Dec 2024 08:08:02 +0800	[thread overview]
Message-ID: <20241211-const_dfc_done-v4-0-583cc60329df@quicinc.com> (raw)

This patch series is to constify the following API:
struct device *device_find_child(struct device *dev, void *data,
		int (*match)(struct device *dev, void *data));
To :
struct device *device_find_child(struct device *dev, const void *data,
				 device_match_t match);
typedef int (*device_match_t)(struct device *dev, const void *data);

Why to constify the API?

- Protect caller's match data @*data which is for comparison and lookup
  and the API does not actually need to modify @*data.

- Make the API's parameters (@match)() and @data have the same type as
  all of other device finding APIs (bus|class|driver)_find_device().

- All kinds of existing device matching functions can be directly taken
  as the API's argument, they were exported by driver core.

What to do?

- Patches [1/11, 3/11] prepare for constifying the API.

- Patch 4/11 constifies the API and adapt for its various subsystem usages.

- Remaining do cleanup for several usages with benefits brought above.

---
Changes in v4:
- Correct title and commit messages according to review comments
- Link to v3: https://lore.kernel.org/r/20241205-const_dfc_done-v3-0-1611f1486b5a@quicinc.com

Changes in v3:
- Solve build broken issue by squashing changes of various subsystem.
- Reduce recipients to try to send out full patch serial.
- Correct tiles and commit messages.
- Link to v2: https://lore.kernel.org/all/20241203-const_dfc_done-v2-0-7436a98c497f@quicinc.com

Changes in v2:
- Series v1 have no code review comments and are posted a long time ago, so may ignore differences.
- Link to v1: https://lore.kernel.org/r/20240811-const_dfc_done-v1-0-9d85e3f943cb@quicinc.com
- Motivation link: https://lore.kernel.org/lkml/917359cc-a421-41dd-93f4-d28937fe2325@icloud.com

---
Zijun Hu (11):
      libnvdimm: Replace namespace_match() with device_find_child_by_name()
      slimbus: core: Constify slim_eaddr_equal()
      bus: fsl-mc: Constify fsl_mc_device_match()
      driver core: Constify API device_find_child() then adapt for various usages
      driver core: Simplify API device_find_child_by_name() implementation
      driver core: Remove match_any()
      slimbus: core: Remove of_slim_match_dev()
      gpio: sim: Remove gpio_sim_dev_match_fwnode()
      driver core: Introduce an device matching API device_match_type()
      cxl/pmem: Replace match_nvdimm_bridge() with API device_match_type()
      usb: typec: class: Remove both cable_match() and partner_match()

 arch/sparc/kernel/vio.c                |  6 +++---
 drivers/base/core.c                    | 30 ++++++++++--------------------
 drivers/block/sunvdc.c                 |  6 +++---
 drivers/bus/fsl-mc/dprc-driver.c       |  8 ++++----
 drivers/cxl/core/pci.c                 |  4 ++--
 drivers/cxl/core/pmem.c                |  9 +++------
 drivers/cxl/core/region.c              | 21 ++++++++++++---------
 drivers/firewire/core-device.c         |  4 ++--
 drivers/firmware/arm_scmi/bus.c        |  4 ++--
 drivers/firmware/efi/dev-path-parser.c |  4 ++--
 drivers/gpio/gpio-sim.c                |  7 +------
 drivers/gpu/drm/mediatek/mtk_drm_drv.c |  2 +-
 drivers/hwmon/hwmon.c                  |  2 +-
 drivers/media/pci/mgb4/mgb4_core.c     |  4 ++--
 drivers/nvdimm/bus.c                   |  2 +-
 drivers/nvdimm/claim.c                 |  9 +--------
 drivers/pwm/core.c                     |  2 +-
 drivers/rpmsg/rpmsg_core.c             |  4 ++--
 drivers/scsi/qla4xxx/ql4_os.c          |  3 ++-
 drivers/scsi/scsi_transport_iscsi.c    | 10 +++++-----
 drivers/slimbus/core.c                 | 17 +++++------------
 drivers/thunderbolt/retimer.c          |  2 +-
 drivers/thunderbolt/xdomain.c          |  2 +-
 drivers/tty/serial/serial_core.c       |  4 ++--
 drivers/usb/typec/class.c              | 31 ++++++++++++++-----------------
 include/linux/device.h                 |  4 ++--
 include/linux/device/bus.h             |  1 +
 include/scsi/scsi_transport_iscsi.h    |  4 ++--
 net/dsa/dsa.c                          |  2 +-
 tools/testing/cxl/test/cxl.c           |  2 +-
 30 files changed, 90 insertions(+), 120 deletions(-)
---
base-commit: cdd30ebb1b9f36159d66f088b61aee264e649d7a
change-id: 20241201-const_dfc_done-aaec71e3bbea

Best regards,
-- 
Zijun Hu <quic_zijuhu@quicinc.com>


             reply	other threads:[~2024-12-11  0:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11  0:08 Zijun Hu [this message]
2024-12-11  0:08 ` [PATCH v4 01/11] libnvdimm: Replace namespace_match() with device_find_child_by_name() Zijun Hu
2024-12-23 20:23   ` Jonathan Cameron
2025-01-02 18:17   ` Fan Ni
2025-01-03  0:29     ` Zijun Hu
2024-12-11  0:08 ` [PATCH v4 02/11] slimbus: core: Constify slim_eaddr_equal() Zijun Hu
2024-12-23 20:25   ` Jonathan Cameron
2024-12-11  0:08 ` [PATCH v4 03/11] bus: fsl-mc: Constify fsl_mc_device_match() Zijun Hu
2024-12-23 20:26   ` Jonathan Cameron
2024-12-24 12:36     ` Zijun Hu
2024-12-11  0:08 ` [PATCH v4 04/11] driver core: Constify API device_find_child() then adapt for various usages Zijun Hu
2024-12-23  7:30   ` Uwe Kleine-König
2024-12-23 20:33   ` Jonathan Cameron
2024-12-24 12:47     ` Zijun Hu
2025-01-02 17:07   ` Mathieu Poirier
2024-12-11  0:08 ` [PATCH v4 05/11] driver core: Simplify API device_find_child_by_name() implementation Zijun Hu
2024-12-23 20:39   ` Jonathan Cameron
2024-12-24 12:55     ` Zijun Hu
2024-12-11  0:08 ` [PATCH v4 06/11] driver core: Remove match_any() Zijun Hu
2024-12-23 20:40   ` Jonathan Cameron
2024-12-11  0:08 ` [PATCH v4 07/11] slimbus: core: Remove of_slim_match_dev() Zijun Hu
2024-12-23 20:44   ` Jonathan Cameron
2024-12-11  0:08 ` [PATCH v4 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode() Zijun Hu
2024-12-11  8:18   ` Bartosz Golaszewski
2024-12-23 20:45   ` Jonathan Cameron
2024-12-11  0:08 ` [PATCH v4 09/11] driver core: Introduce an device matching API device_match_type() Zijun Hu
2024-12-23 20:46   ` Jonathan Cameron
2024-12-11  0:08 ` [PATCH v4 10/11] cxl/pmem: Replace match_nvdimm_bridge() with " Zijun Hu
2024-12-23 20:48   ` Jonathan Cameron
2024-12-24 12:58     ` Zijun Hu
2024-12-11  0:08 ` [PATCH v4 11/11] usb: typec: class: Remove both cable_match() and partner_match() Zijun Hu
2024-12-23 20:52   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241211-const_dfc_done-v4-0-583cc60329df@quicinc.com \
    --to=zijun_hu@icloud.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alison.schofield@intel.com \
    --cc=arm-scmi@vger.kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=o-takashi@sakamocchi.jp \
    --cc=quic_zijuhu@quicinc.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=thomas@t-8ch.de \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).