* [PATCH] oradax: fix typo in dax_dbg message
@ 2025-01-23 20:17 Andrew Kreimer
2025-01-23 20:23 ` Rob Gardner
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Kreimer @ 2025-01-23 20:17 UTC (permalink / raw)
To: David S . Miller, Andreas Larsson
Cc: sparclinux, linux-kernel, kernel-janitors, Andrew Kreimer
There is a typo in a printk message: copyin -> copying.
Fix it via codespell.
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
drivers/sbus/char/oradax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sbus/char/oradax.c b/drivers/sbus/char/oradax.c
index a536dd6f4f7c..3f93208b616a 100644
--- a/drivers/sbus/char/oradax.c
+++ b/drivers/sbus/char/oradax.c
@@ -874,7 +874,7 @@ static int dax_ccb_exec(struct dax_ctx *ctx, const char __user *buf,
* user in between validation and submission.
*/
if (copy_from_user(ctx->ccb_buf, buf, count)) {
- dax_dbg("copyin of user CCB buffer failed");
+ dax_dbg("copying of user CCB buffer failed");
ctx->result.exec.status = DAX_SUBMIT_ERR_CCB_ARR_MMU_MISS;
return 0;
}
--
2.47.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] oradax: fix typo in dax_dbg message
2025-01-23 20:17 [PATCH] oradax: fix typo in dax_dbg message Andrew Kreimer
@ 2025-01-23 20:23 ` Rob Gardner
2025-01-26 18:07 ` Andrew Kreimer
2025-01-26 18:32 ` John Paul Adrian Glaubitz
0 siblings, 2 replies; 5+ messages in thread
From: Rob Gardner @ 2025-01-23 20:23 UTC (permalink / raw)
To: Andrew Kreimer, David S . Miller, Andreas Larsson
Cc: sparclinux, linux-kernel, kernel-janitors
That is not a typo. "Copyin" is correct as it refers to copying data in
from user space.
Rob
On 1/23/25 13:17, Andrew Kreimer wrote:
> There is a typo in a printk message: copyin -> copying.
>
> Fix it via codespell.
>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> ---
> drivers/sbus/char/oradax.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/sbus/char/oradax.c b/drivers/sbus/char/oradax.c
> index a536dd6f4f7c..3f93208b616a 100644
> --- a/drivers/sbus/char/oradax.c
> +++ b/drivers/sbus/char/oradax.c
> @@ -874,7 +874,7 @@ static int dax_ccb_exec(struct dax_ctx *ctx, const char __user *buf,
> * user in between validation and submission.
> */
> if (copy_from_user(ctx->ccb_buf, buf, count)) {
> - dax_dbg("copyin of user CCB buffer failed");
> + dax_dbg("copying of user CCB buffer failed");
> ctx->result.exec.status = DAX_SUBMIT_ERR_CCB_ARR_MMU_MISS;
> return 0;
> }
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] oradax: fix typo in dax_dbg message
2025-01-23 20:23 ` Rob Gardner
@ 2025-01-26 18:07 ` Andrew Kreimer
2025-01-26 18:32 ` John Paul Adrian Glaubitz
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Kreimer @ 2025-01-26 18:07 UTC (permalink / raw)
To: Rob Gardner
Cc: David S . Miller, Andreas Larsson, sparclinux, linux-kernel,
kernel-janitors
On Thu, Jan 23, 2025 at 01:23:20PM -0700, Rob Gardner wrote:
> That is not a typo. "Copyin" is correct as it refers to copying data in from
> user space.
My bad!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] oradax: fix typo in dax_dbg message
2025-01-23 20:23 ` Rob Gardner
2025-01-26 18:07 ` Andrew Kreimer
@ 2025-01-26 18:32 ` John Paul Adrian Glaubitz
2025-01-27 4:44 ` Rob Gardner
1 sibling, 1 reply; 5+ messages in thread
From: John Paul Adrian Glaubitz @ 2025-01-26 18:32 UTC (permalink / raw)
To: Rob Gardner, Andrew Kreimer, David S . Miller, Andreas Larsson
Cc: sparclinux, linux-kernel, kernel-janitors
Hi Rob,
On Thu, 2025-01-23 at 13:23 -0700, Rob Gardner wrote:
> That is not a typo. "Copyin" is correct as it refers to copying data in
> from user space.
If it's "copying in" data from user space, it should be spelled "copy in"
and not "copyin" unless my English grammar skills are failing me.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] oradax: fix typo in dax_dbg message
2025-01-26 18:32 ` John Paul Adrian Glaubitz
@ 2025-01-27 4:44 ` Rob Gardner
0 siblings, 0 replies; 5+ messages in thread
From: Rob Gardner @ 2025-01-27 4:44 UTC (permalink / raw)
To: John Paul Adrian Glaubitz, Andrew Kreimer, David S . Miller,
Andreas Larsson
Cc: sparclinux, linux-kernel, kernel-janitors
On 1/26/25 11:32, John Paul Adrian Glaubitz wrote:
> Hi Rob,
>
> On Thu, 2025-01-23 at 13:23 -0700, Rob Gardner wrote:
>> That is not a typo. "Copyin" is correct as it refers to copying data in
>> from user space.
> If it's "copying in" data from user space, it should be spelled "copy in"
> and not "copyin" unless my English grammar skills are failing me.
>
The resulting phrase "copy in of user CCB buffer" would contain two
consecutive prepositions, which is poor English grammar. ;)
There used to be a kernel function called copyin() that was changed to
copy_from_user() in the dim past. But I think "copyin" is still widely
understood as an /operation/, not an English word, kind of like "ccb".
Apologies to all for cluttering up multiple lists with this trivia.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-01-27 4:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-23 20:17 [PATCH] oradax: fix typo in dax_dbg message Andrew Kreimer
2025-01-23 20:23 ` Rob Gardner
2025-01-26 18:07 ` Andrew Kreimer
2025-01-26 18:32 ` John Paul Adrian Glaubitz
2025-01-27 4:44 ` Rob Gardner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).