From: Heiko Carstens <hca@linux.ibm.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 5/7] s390/crc: drop "glue" from filenames
Date: Fri, 25 Apr 2025 11:22:27 +0200 [thread overview]
Message-ID: <20250425092227.7180Bda-hca@linux.ibm.com> (raw)
In-Reply-To: <20250424002038.179114-6-ebiggers@kernel.org>
On Wed, Apr 23, 2025 at 05:20:36PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The use of the term "glue" in filenames is a Crypto API-ism that does
> not show up elsewhere in lib/. I think adopting it there was a mistake.
> The library just uses standard functions, so the amount of code that
> could be considered "glue" is quite small. And while often the C
> functions just wrap the assembly functions, there are also cases like
> crc32c_arch() in arch/x86/lib/crc32-glue.c that blur the line by
> in-lining the actual implementation into the C function. That's not
> "glue code", but rather the actual code.
>
> Therefore, let's drop "glue" from the filenames and instead use e.g.
> crc32.c instead of crc32-glue.c.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> arch/s390/lib/Makefile | 2 +-
> arch/s390/lib/{crc32-glue.c => crc32.c} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename arch/s390/lib/{crc32-glue.c => crc32.c} (100%)
Acked-by: Heiko Carstens <hca@linux.ibm.com>
next prev parent reply other threads:[~2025-04-25 9:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 0:20 [PATCH 0/7] lib/crc: drop "glue" from filenames Eric Biggers
2025-04-24 0:20 ` [PATCH 1/7] arm/crc: " Eric Biggers
2025-04-24 0:20 ` [PATCH 2/7] arm64/crc: " Eric Biggers
2025-04-24 0:20 ` [PATCH 3/7] powerpc/crc: " Eric Biggers
2025-04-24 0:20 ` [PATCH 4/7] powerpc/crc: rename crc32-vpmsum_core.S to crc-vpmsum-template.S Eric Biggers
2025-04-24 0:20 ` [PATCH 5/7] s390/crc: drop "glue" from filenames Eric Biggers
2025-04-25 9:22 ` Heiko Carstens [this message]
2025-04-24 0:20 ` [PATCH 6/7] sparc/crc: " Eric Biggers
2025-04-24 0:20 ` [PATCH 7/7] x86/crc: " Eric Biggers
2025-04-24 6:22 ` [PATCH 0/7] lib/crc: " Ard Biesheuvel
2025-04-25 0:51 ` Martin K. Petersen
2025-04-25 0:52 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425092227.7180Bda-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).