sparclinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zijun Hu <zijun_hu@icloud.com>
To: Arnd Bergmann <arnd@arndb.de>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	 Helge Deller <deller@gmx.de>,
	"David S. Miller" <davem@davemloft.net>,
	 Andreas Larsson <andreas@gaisler.com>
Cc: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>,
	 Zijun Hu <zijun_hu@icloud.com>,
	linux-kernel@vger.kernel.org,  linux-parisc@vger.kernel.org,
	sparclinux@vger.kernel.org,  Zijun Hu <zijun.hu@oss.qualcomm.com>
Subject: [PATCH v5 5/8] char: misc: Fix kunit test case miscdev_test_dynamic_reentry() failure
Date: Thu, 10 Jul 2025 19:56:48 +0800	[thread overview]
Message-ID: <20250710-rfc_miscdev-v5-5-b3940297db16@oss.qualcomm.com> (raw)
In-Reply-To: <20250710-rfc_miscdev-v5-0-b3940297db16@oss.qualcomm.com>

From: Zijun Hu <zijun.hu@oss.qualcomm.com>

misc_deregister() frees dynamic minor @misc->minor but does not
reset it to macro MISC_DYNAMIC_MINOR, so cause kunit test case
miscdev_test_dynamic_reentry() failure:

Invalid fixed minor 257 for miscdevice 'miscdyn_a'
\#miscdev_test_dynamic_reentry: ASSERTION FAILED at misc_minor_kunit.c:639
Expected ret == 0, but
ret == -22 (0xffffffffffffffea)
[FAILED] miscdev_test_dynamic_reentry

Fix by resetting @misc->minor to MISC_DYNAMIC_MINOR in misc_deregister()
as error handling of misc_register() does.

Signed-off-by: Zijun Hu <zijun.hu@oss.qualcomm.com>
---
 drivers/char/misc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index b8e66466184fa21fb66d968db7950e0b5669ac43..96ed343cf5c8509a09855020049a9af82a3ede95 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -288,6 +288,8 @@ void misc_deregister(struct miscdevice *misc)
 	list_del(&misc->list);
 	device_destroy(&misc_class, MKDEV(MISC_MAJOR, misc->minor));
 	misc_minor_free(misc->minor);
+	if (misc->minor > MISC_DYNAMIC_MINOR)
+		misc->minor = MISC_DYNAMIC_MINOR;
 	mutex_unlock(&misc_mtx);
 }
 EXPORT_SYMBOL(misc_deregister);

-- 
2.34.1


  parent reply	other threads:[~2025-07-10 11:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 11:56 [PATCH v5 0/8] char: misc: Various cleanup for miscdevice Zijun Hu
2025-07-10 11:56 ` [PATCH v5 1/8] char: misc: Move drivers/misc/misc_minor_kunit.c to drivers/char/ Zijun Hu
2025-07-10 11:56 ` [PATCH v5 2/8] char: misc: Adapt and add test cases for simple minor space division Zijun Hu
2025-07-10 14:34   ` Thadeu Lima de Souza Cascardo
2025-07-14  0:42     ` Zijun Hu
2025-07-10 11:56 ` [PATCH v5 3/8] char: misc: Disallow registering miscdevice whose minor > MISC_DYNAMIC_MINOR Zijun Hu
2025-07-10 11:56 ` [PATCH v5 4/8] char: misc: Add a case to test registering miscdevice again without reinitialization Zijun Hu
2025-07-10 11:56 ` Zijun Hu [this message]
2025-07-10 18:15   ` [PATCH v5 5/8] char: misc: Fix kunit test case miscdev_test_dynamic_reentry() failure Thadeu Lima de Souza Cascardo
2025-07-14  1:02     ` Zijun Hu
2025-07-14 11:26       ` Thadeu Lima de Souza Cascardo
2025-07-10 11:56 ` [PATCH v5 6/8] char: misc: Does not request module for miscdevice with dynamic minor Zijun Hu
2025-07-10 18:22   ` Thadeu Lima de Souza Cascardo
2025-07-10 11:56 ` [PATCH v5 7/8] char: misc: Register fixed minor EISA_EEPROM_MINOR in linux/miscdevice.h Zijun Hu
2025-07-10 11:56 ` [PATCH v5 8/8] sparc: kernel: apc: Remove macro APC_MINOR definition Zijun Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250710-rfc_miscdev-v5-5-b3940297db16@oss.qualcomm.com \
    --to=zijun_hu@icloud.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=andreas@gaisler.com \
    --cc=arnd@arndb.de \
    --cc=cascardo@igalia.com \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=zijun.hu@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).