From: Max Kellermann <max.kellermann@ionos.com>
To: akpm@linux-foundation.org, david@redhat.com,
axelrasmussen@google.com, yuanchu@google.com,
willy@infradead.org, hughd@google.com, mhocko@suse.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
vishal.moola@gmail.com, linux@armlinux.org.uk,
James.Bottomley@HansenPartnership.com, deller@gmx.de,
agordeev@linux.ibm.com, gerald.schaefer@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, davem@davemloft.net, andreas@gaisler.com,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com, chris@zankel.net,
jcmvbkbc@gmail.com, viro@zeniv.linux.org.uk, brauner@kernel.org,
jack@suse.cz, weixugc@google.com, baolin.wang@linux.alibaba.com,
rientjes@google.com, shakeel.butt@linux.dev,
max.kellermann@ionos.com, thuth@redhat.com, broonie@kernel.org,
osalvador@suse.de, jfalempe@redhat.com, mpe@ellerman.id.au,
nysal@linux.ibm.com, linux-arm-kernel@lists.infradead.org,
linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH v6 00/12] mm: establish const-correctness for pointer parameters
Date: Mon, 1 Sep 2025 22:50:09 +0200 [thread overview]
Message-ID: <20250901205021.3573313-1-max.kellermann@ionos.com> (raw)
For improved const-correctness in the low-level memory-management
subsystem, which provides a basis for further const-ification further
up the call stack (e.g. filesystems).
This patch series splitted into smaller patches was initially posted
as a single large patch:
https://lore.kernel.org/lkml/20250827192233.447920-1-max.kellermann@ionos.com/
I started this work when I tried to constify the Ceph filesystem code,
but found that to be impossible because many "mm" functions accept
non-const pointer, even though they modify nothing.
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
---
v1 -> v2:
- made several parameter values const (i.e. the pointer address, not
just the pointed-to memory), as suggested by Andrew Morton and
Yuanchu Xie
- drop existing+obsolete "extern" keywords on lines modified by these
patches (suggested by Vishal Moola)
- add missing parameter names on lines modified by these patches
(suggested by Vishal Moola)
- more "const" pointers (e.g. the task_struct passed to
process_shares_mm())
- add missing "const" to s390, fixing s390 build failure
- moved the mmap_is_legacy() change in arch/s390/mm/mmap.c from 08/12
to 06/12 (suggested by Vishal Moola)
v2 -> v3:
- remove garbage from 06/12
- changed tags on subject line (suggested by Matthew Wilcox)
v3 -> v4:
- more verbose commit messages including a listing of function names
(suggested by David Hildenbrand and Lorenzo Stoakes)
v4 -> v5:
- back to shorter commit messages after an agreement between David
Hildenbrand and Lorenzo Stoakes was found
v5 -> v6:
- fix inconsistent constness of assert_fault_locked()
- revert the const parameter value change from v2 (requested by
Lorenzo Stoakes)
- revert the long cover letter, removing long explanations again
(requested by Lorenzo Stoakes)
Max Kellermann (12):
mm: constify shmem related test functions for improved
const-correctness
mm: constify pagemap related test/getter functions
mm: constify zone related test/getter functions
fs: constify mapping related test functions for improved
const-correctness
mm: constify process_shares_mm() for improved const-correctness
mm, s390: constify mapping related test/getter functions
parisc: constify mmap_upper_limit() parameter
mm: constify arch_pick_mmap_layout() for improved const-correctness
mm: constify ptdesc_pmd_pts_count() and folio_get_private()
mm: constify various inline functions for improved const-correctness
mm: constify assert/test functions in mm.h
mm: constify highmem related functions for improved const-correctness
arch/arm/include/asm/highmem.h | 6 +--
arch/parisc/include/asm/processor.h | 2 +-
arch/parisc/kernel/sys_parisc.c | 2 +-
arch/s390/mm/mmap.c | 6 +--
arch/sparc/kernel/sys_sparc_64.c | 2 +-
arch/x86/mm/mmap.c | 6 +--
arch/xtensa/include/asm/highmem.h | 2 +-
include/linux/fs.h | 6 +--
include/linux/highmem-internal.h | 36 +++++++++---------
include/linux/highmem.h | 8 ++--
include/linux/mm.h | 56 +++++++++++++--------------
include/linux/mm_inline.h | 25 ++++++------
include/linux/mm_types.h | 4 +-
include/linux/mmzone.h | 42 ++++++++++----------
include/linux/pagemap.h | 59 +++++++++++++++--------------
include/linux/sched/mm.h | 4 +-
include/linux/shmem_fs.h | 4 +-
mm/highmem.c | 10 ++---
mm/oom_kill.c | 6 +--
mm/shmem.c | 6 +--
mm/util.c | 16 ++++----
21 files changed, 155 insertions(+), 153 deletions(-)
--
2.47.2
next reply other threads:[~2025-09-01 20:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 20:50 Max Kellermann [this message]
2025-09-01 20:50 ` [PATCH v6 01/12] mm: constify shmem related test functions for improved const-correctness Max Kellermann
2025-09-01 20:50 ` [PATCH v6 02/12] mm: constify pagemap related test/getter functions Max Kellermann
2025-09-01 20:50 ` [PATCH v6 03/12] mm: constify zone " Max Kellermann
2025-09-01 20:50 ` [PATCH v6 04/12] fs: constify mapping related test functions for improved const-correctness Max Kellermann
2025-09-02 10:42 ` Jan Kara
2025-09-02 10:57 ` Christian Brauner
2025-09-01 20:50 ` [PATCH v6 05/12] mm: constify process_shares_mm() " Max Kellermann
2025-09-02 8:03 ` David Hildenbrand
2025-09-01 20:50 ` [PATCH v6 06/12] mm, s390: constify mapping related test/getter functions Max Kellermann
2025-09-02 6:13 ` Lorenzo Stoakes
2025-09-02 8:04 ` David Hildenbrand
2025-09-01 20:50 ` [PATCH v6 07/12] parisc: constify mmap_upper_limit() parameter Max Kellermann
2025-09-02 6:13 ` Lorenzo Stoakes
2025-09-02 8:04 ` David Hildenbrand
2025-09-01 20:50 ` [PATCH v6 08/12] mm: constify arch_pick_mmap_layout() for improved const-correctness Max Kellermann
2025-09-02 6:15 ` Lorenzo Stoakes
2025-09-02 8:05 ` David Hildenbrand
2025-09-01 20:50 ` [PATCH v6 09/12] mm: constify ptdesc_pmd_pts_count() and folio_get_private() Max Kellermann
2025-09-01 20:50 ` [PATCH v6 10/12] mm: constify various inline functions for improved const-correctness Max Kellermann
2025-09-02 6:16 ` Lorenzo Stoakes
2025-09-02 8:05 ` David Hildenbrand
2025-09-01 20:50 ` [PATCH v6 11/12] mm: constify assert/test functions in mm.h Max Kellermann
2025-09-02 6:17 ` Lorenzo Stoakes
2025-09-02 8:06 ` David Hildenbrand
2025-09-01 20:50 ` [PATCH v6 12/12] mm: constify highmem related functions for improved const-correctness Max Kellermann
2025-09-02 6:17 ` Lorenzo Stoakes
2025-09-02 8:11 ` David Hildenbrand
2025-09-01 21:34 ` [PATCH v6 00/12] mm: establish const-correctness for pointer parameters Vlastimil Babka
2025-09-02 6:19 ` Lorenzo Stoakes
2025-09-02 8:12 ` David Hildenbrand
2025-09-02 10:02 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901205021.3573313-1-max.kellermann@ionos.com \
--to=max.kellermann@ionos.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Liam.Howlett@oracle.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andreas@gaisler.com \
--cc=axelrasmussen@google.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=chris@zankel.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=deller@gmx.de \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jcmvbkbc@gmail.com \
--cc=jfalempe@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.stoakes@oracle.com \
--cc=luto@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=nysal@linux.ibm.com \
--cc=osalvador@suse.de \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=surenb@google.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=thuth@redhat.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.moola@gmail.com \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).