Re: [PATCH v5 08/12] mm: constify arch_pick_mmap_layout() for improved const-correctness

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Mon, Sep 01, 2025 at 03:58:14PM +0200, David Hildenbrand wrote:
> On 01.09.25 14:30, Max Kellermann wrote:
> > This function only reads from the rlimit pointer (but writes to the
> > mm_struct pointer which is kept without `const`).
> >
> > All callees are already const-ified or (internal functions) are being
> > constified by this patch.
> >
> > Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> > Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> > ---
>
> [...]
>
> > index 2201da0afecc..0232d983b715 100644
> > --- a/include/linux/sched/mm.h
> > +++ b/include/linux/sched/mm.h
> > @@ -178,7 +178,7 @@ static inline void mm_update_next_owner(struct mm_struct *mm)
> >   #endif
> >   extern void arch_pick_mmap_layout(struct mm_struct *mm,
> > -				  struct rlimit *rlim_stack);
> > +				  const struct rlimit *rlim_stack);
> >   unsigned long
> >   arch_get_unmapped_area(struct file *filp, unsigned long addr,
> > @@ -211,7 +211,7 @@ generic_get_unmapped_area_topdown(struct file *filp, unsigned long addr,
> >   				  unsigned long flags, vm_flags_t vm_flags);
> >   #else
> >   static inline void arch_pick_mmap_layout(struct mm_struct *mm,
> > -					 struct rlimit *rlim_stack) {}
> > +					 const struct rlimit *rlim_stack) {}
> >   #endif
>
> Should both these cases also use *const?
>
> (for the latter we probably don't care either, but maybe just to be
> consistent)

It'd be pretty hideous aesthetically. Really feel like we shouldn't be doing
it...

Imagine

static inline void foo(const struct mm_struct *const mm, const struct vm_area_struct *const vma,
			const struct rlimit *const rlim_stack);

I mean that's _just not readable_.

>
> --
> Cheers
>
> David / dhildenb
>