From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: David Hildenbrand <david@redhat.com>
Cc: Max Kellermann <max.kellermann@ionos.com>,
akpm@linux-foundation.org, axelrasmussen@google.com,
yuanchu@google.com, willy@infradead.org, hughd@google.com,
mhocko@suse.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Liam.Howlett@oracle.com, vbabka@suse.cz,
rppt@kernel.org, surenb@google.com, vishal.moola@gmail.com,
linux@armlinux.org.uk, James.Bottomley@hansenpartnership.com,
deller@gmx.de, agordeev@linux.ibm.com,
gerald.schaefer@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, davem@davemloft.net, andreas@gaisler.com,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com, chris@zankel.net,
jcmvbkbc@gmail.com, viro@zeniv.linux.org.uk, brauner@kernel.org,
jack@suse.cz, weixugc@google.com, baolin.wang@linux.alibaba.com,
rientjes@google.com, shakeel.butt@linux.dev, thuth@redhat.com,
broonie@kernel.org, osalvador@suse.de, jfalempe@redhat.com,
mpe@ellerman.id.au, nysal@linux.ibm.com,
linux-arm-kernel@lists.infradead.org,
linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org,
conduct@kernel.org
Subject: Re: [PATCH v4 00/12] mm: establish const-correctness for pointer parameters
Date: Mon, 1 Sep 2025 11:56:05 +0100 [thread overview]
Message-ID: <593bf6fc-bb12-42bb-b763-383ca16e3adb@lucifer.local> (raw)
In-Reply-To: <bfe1ae86-981a-4bd5-a96d-2879ef1b3af2@redhat.com>
On Mon, Sep 01, 2025 at 12:43:42PM +0200, David Hildenbrand wrote:
> Let's all calm down a bit.
I am guessing you are not contradicting what I'm saying here but instead
trying to find a solution as to the _series_.
However, and I'm sure you agree - I want to underline my view that treating
people with disrespect should not be tolerated in the kernel.
I don't always feel we emphasise that enough.
>
> Max, I think this series here is valuable, and you can see that from the
> engagement from reviewers (this is a *good* thing, I sometimes wish I would
> get feedback that would help me improve my submissions).
Right - absolutely - the entire point of my review was to allow the series
to land so I agree there's something valuable here.
In some subsystems you might be waiting days/weeks for a response. It's
important (for Max) to realise how valuable this is.
I for one have given as much constructive criticism as I could with thhis
aim in mind, as have you and Vlastimil and Mike.
>
> So if you don't want to follow-up on this series to polish the patch
> descriptions etc,, let me now and I (or someone else around here) can drag
> it over the finishing line.
I guess if Max sends a respin that addresses review correctly and in good
faith I'll give it one more try, but Max - please try to have empathy and
respect in your responses.
This is literally all that I ask.
Otherwise am fine with this coming from somebody else.
>
> --
> Cheers
>
> David / dhildenb
>
Thanks, Lorenzo
next prev parent reply other threads:[~2025-09-01 10:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 9:19 [PATCH v4 00/12] mm: establish const-correctness for pointer parameters Max Kellermann
2025-09-01 9:19 ` [PATCH v4 01/12] mm/shmem: add `const` to pointer parameters for improved const-correctness Max Kellermann
2025-09-01 9:19 ` [PATCH v4 02/12] mm/pagemap: " Max Kellermann
2025-09-01 9:19 ` [PATCH v4 03/12] mm/mmzone: add const " Max Kellermann
2025-09-01 9:19 ` [PATCH v4 04/12] fs: " Max Kellermann
2025-09-01 9:19 ` [PATCH v4 05/12] mm/oom_kill: add const to pointer parameter " Max Kellermann
2025-09-01 9:19 ` [PATCH v4 06/12] mm/util, s390: add const to pointer parameters " Max Kellermann
2025-09-01 9:19 ` [PATCH v4 07/12] parisc: add `const` to mmap_upper_limit() parameter Max Kellermann
2025-09-01 9:19 ` [PATCH v4 08/12] mm/util, s390, sparc, x86: add const to arch_pick_mmap_layout() parameter Max Kellermann
2025-09-01 9:19 ` [PATCH v4 09/12] mm/mm_types: add const to pointer parameters for improved const-correctness Max Kellermann
2025-09-01 9:19 ` [PATCH v4 10/12] mm/mm_inline: " Max Kellermann
2025-09-01 9:19 ` [PATCH v4 11/12] mm: " Max Kellermann
2025-09-01 9:19 ` [PATCH v4 12/12] mm/highmem: " Max Kellermann
2025-09-01 9:43 ` [PATCH v4 00/12] mm: establish const-correctness for pointer parameters Lorenzo Stoakes
2025-09-01 9:54 ` Max Kellermann
2025-09-01 10:04 ` Lorenzo Stoakes
2025-09-01 10:20 ` Max Kellermann
2025-09-01 10:43 ` David Hildenbrand
2025-09-01 10:54 ` Max Kellermann
2025-09-01 11:02 ` David Hildenbrand
2025-09-01 11:05 ` Lorenzo Stoakes
2025-09-01 11:15 ` David Hildenbrand
2025-09-01 10:56 ` Lorenzo Stoakes [this message]
2025-09-01 11:06 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593bf6fc-bb12-42bb-b763-383ca16e3adb@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Liam.Howlett@oracle.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andreas@gaisler.com \
--cc=axelrasmussen@google.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=chris@zankel.net \
--cc=conduct@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=deller@gmx.de \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jcmvbkbc@gmail.com \
--cc=jfalempe@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=max.kellermann@ionos.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=nysal@linux.ibm.com \
--cc=osalvador@suse.de \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=surenb@google.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=thuth@redhat.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.moola@gmail.com \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).