From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Date: Mon, 06 Apr 2015 13:05:33 +0000 Subject: Re: [PATCH 1/3] PCI: Introduce pci_bus_addr_t Message-Id: List-Id: References: <1427857069-6789-1-git-send-email-yinghai@kernel.org> <1427857069-6789-2-git-send-email-yinghai@kernel.org> <20150403193234.GD10892@google.com> <20150403205201.GF10892@google.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Sat, Apr 4, 2015 at 10:25 PM, Bjorn Helgaas wrote: > On Sat, Apr 4, 2015 at 2:48 PM, Rob Herring wrote: >> On Sat, Apr 4, 2015 at 7:46 AM, Bjorn Helgaas wrote: > >>> I think there's still an unresolved question about the OF parsing code. >> >> Got a pointer to what that is? I'll take a guess. Generally, we make >> the parsing code independent of the kernel addr sizes and use u64 >> types. The DT sizes and kernel sizes are not always aligned. For >> example, an LPAE capable platform running a non-LPAE kernel build. > > Yep: http://lkml.kernel.org/r/1427857069-6789-3-git-send-email-yinghai@kernel.org > > Yinghai made a change to the sparc OF parsing code. The question is > whether a similar change should be made to clones of that code (two > others in arch/sparc, one in arch/powerpc, and one in drivers/of). Yes, it appears to me that is needed. At least the drivers/of/ code does not distinguish 32 and 64 bit ATM. Rob