From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
To: Zijun Hu <zijun_hu@icloud.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
"David S. Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
sparclinux@vger.kernel.org, Zijun Hu <zijun.hu@oss.qualcomm.com>
Subject: Re: [PATCH v5 2/8] char: misc: Adapt and add test cases for simple minor space division
Date: Thu, 10 Jul 2025 11:34:54 -0300 [thread overview]
Message-ID: <aG_Pjl4Jl7QJxl8f@quatroqueijos.cascardo.eti.br> (raw)
In-Reply-To: <20250710-rfc_miscdev-v5-2-b3940297db16@oss.qualcomm.com>
On Thu, Jul 10, 2025 at 07:56:45PM +0800, Zijun Hu wrote:
> From: Zijun Hu <zijun.hu@oss.qualcomm.com>
>
> Adapt and add test cases for next change which regards minor whose
> value > macro MISC_DYNAMIC_MINOR as invalid parameter when register
> miscdevice, hence get a simple minor space division below:
>
> < MISC_DYNAMIC_MINOR: fixed minor code
> == MISC_DYNAMIC_MINOR: indicator to request dynamic minor code
> > MISC_DYNAMIC_MINOR: dynamic minor code requested
>
> Signed-off-by: Zijun Hu <zijun.hu@oss.qualcomm.com>
> ---
> drivers/char/misc_minor_kunit.c | 51 +++++++++++++++++------------------------
> 1 file changed, 21 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/char/misc_minor_kunit.c b/drivers/char/misc_minor_kunit.c
> index 30eceac5f1b6402b0f918af6f56602ed1a6c14ec..3184f383bea8c77cbca69ff5e315ea5de2d5512e 100644
> --- a/drivers/char/misc_minor_kunit.c
> +++ b/drivers/char/misc_minor_kunit.c
> @@ -7,12 +7,6 @@
> #include <linux/file.h>
> #include <linux/init_syscalls.h>
>
> -/* dynamic minor (2) */
> -static struct miscdevice dev_dynamic_minor = {
> - .minor = 2,
> - .name = "dev_dynamic_minor",
> -};
> -
> /* static minor (LCD_MINOR) */
> static struct miscdevice dev_static_minor = {
> .minor = LCD_MINOR,
> @@ -25,16 +19,6 @@ static struct miscdevice dev_misc_dynamic_minor = {
> .name = "dev_misc_dynamic_minor",
> };
>
> -static void kunit_dynamic_minor(struct kunit *test)
> -{
> - int ret;
> -
> - ret = misc_register(&dev_dynamic_minor);
> - KUNIT_EXPECT_EQ(test, 0, ret);
> - KUNIT_EXPECT_EQ(test, 2, dev_dynamic_minor.minor);
> - misc_deregister(&dev_dynamic_minor);
> -}
> -
> static void kunit_static_minor(struct kunit *test)
> {
> int ret;
> @@ -157,13 +141,7 @@ static bool is_valid_dynamic_minor(int minor)
> {
> if (minor < 0)
> return false;
> - if (minor == MISC_DYNAMIC_MINOR)
> - return false;
> - if (minor >= 0 && minor <= 15)
> - return false;
> - if (minor >= 128 && minor < MISC_DYNAMIC_MINOR)
> - return false;
> - return true;
> + return minor > MISC_DYNAMIC_MINOR;
> }
>
> static int miscdev_test_open(struct inode *inode, struct file *file)
> @@ -557,7 +535,7 @@ static void __init miscdev_test_conflict(struct kunit *test)
> */
> miscstat.minor = miscdyn.minor;
> ret = misc_register(&miscstat);
> - KUNIT_EXPECT_EQ(test, ret, -EBUSY);
> + KUNIT_EXPECT_EQ(test, ret, -EINVAL);
> if (ret == 0)
> misc_deregister(&miscstat);
>
> @@ -590,8 +568,9 @@ static void __init miscdev_test_conflict_reverse(struct kunit *test)
> misc_deregister(&miscdyn);
>
> ret = misc_register(&miscstat);
> - KUNIT_EXPECT_EQ(test, ret, 0);
> - KUNIT_EXPECT_EQ(test, miscstat.minor, miscdyn.minor);
> + KUNIT_EXPECT_EQ(test, ret, -EINVAL);
> + if (ret == 0)
> + misc_deregister(&miscstat);
>
> /*
> * Try to register a dynamic minor after registering a static minor
> @@ -601,20 +580,32 @@ static void __init miscdev_test_conflict_reverse(struct kunit *test)
> miscdyn.minor = MISC_DYNAMIC_MINOR;
> ret = misc_register(&miscdyn);
> KUNIT_EXPECT_EQ(test, ret, 0);
> - KUNIT_EXPECT_NE(test, miscdyn.minor, miscstat.minor);
> + KUNIT_EXPECT_EQ(test, miscdyn.minor, miscstat.minor);
> KUNIT_EXPECT_TRUE(test, is_valid_dynamic_minor(miscdyn.minor));
> if (ret == 0)
> misc_deregister(&miscdyn);
> +}
>
> - miscdev_test_can_open(test, &miscstat);
> +/* Take minor(> MISC_DYNAMIC_MINOR) as invalid when register miscdevice */
> +static void miscdev_test_invalid_input(struct kunit *test)
> +{
> + struct miscdevice misc_test = {
> + .minor = MISC_DYNAMIC_MINOR + 1,
> + .name = "misc_test",
> + .fops = &miscdev_test_fops,
> + };
> + int ret;
>
> - misc_deregister(&miscstat);
> + ret = misc_register(&misc_test);
> + KUNIT_EXPECT_EQ(test, ret, -EINVAL);
> + if (ret == 0)
> + misc_deregister(&misc_test);
> }
>
These tests will fail if applied before patch 3 "char: misc: Disallow registering miscdevice whose minor > MISC_DYNAMIC_MINOR".
One option is just merge the two commits.
I have worked on a different option, which would be the two patches above,
before applying patch 3. Then, we can either support the two different
behaviors in the test case, or remove the support for the old behavior
after patch 3 is applied.
> static struct kunit_case test_cases[] = {
> - KUNIT_CASE(kunit_dynamic_minor),
> KUNIT_CASE(kunit_static_minor),
> KUNIT_CASE(kunit_misc_dynamic_minor),
> + KUNIT_CASE(miscdev_test_invalid_input),
> KUNIT_CASE_PARAM(miscdev_test_twice, miscdev_gen_params),
> KUNIT_CASE_PARAM(miscdev_test_duplicate_minor, miscdev_gen_params),
> KUNIT_CASE(miscdev_test_duplicate_name),
>
> --
> 2.34.1
>
From 12e05f189745ce38bf792a448ff8d7117f20a3c0 Mon Sep 17 00:00:00 2001
From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Date: Thu, 26 Jun 2025 10:32:03 -0300
Subject: [PATCH 1/3] allow static register to fail
---
drivers/misc/misc_minor_kunit.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/misc_minor_kunit.c b/drivers/misc/misc_minor_kunit.c
index 30eceac5f1b6..2ef92ce3d053 100644
--- a/drivers/misc/misc_minor_kunit.c
+++ b/drivers/misc/misc_minor_kunit.c
@@ -569,6 +569,7 @@ static void __init miscdev_test_conflict(struct kunit *test)
static void __init miscdev_test_conflict_reverse(struct kunit *test)
{
int ret;
+ bool stat_registered = false;
struct miscdevice miscdyn = {
.name = "miscdyn",
.minor = MISC_DYNAMIC_MINOR,
@@ -592,6 +593,8 @@ static void __init miscdev_test_conflict_reverse(struct kunit *test)
ret = misc_register(&miscstat);
KUNIT_EXPECT_EQ(test, ret, 0);
KUNIT_EXPECT_EQ(test, miscstat.minor, miscdyn.minor);
+ if (ret == 0)
+ stat_registered = true;
/*
* Try to register a dynamic minor after registering a static minor
@@ -606,9 +609,10 @@ static void __init miscdev_test_conflict_reverse(struct kunit *test)
if (ret == 0)
misc_deregister(&miscdyn);
- miscdev_test_can_open(test, &miscstat);
-
- misc_deregister(&miscstat);
+ if (stat_registered) {
+ miscdev_test_can_open(test, &miscstat);
+ misc_deregister(&miscstat);
+ }
}
static struct kunit_case test_cases[] = {
--
2.47.2
From c9974a5b2cb59ad3ee5e371cb42c5969a46128b2 Mon Sep 17 00:00:00 2001
From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Date: Thu, 26 Jun 2025 15:43:31 -0300
Subject: [PATCH 2/3] support the case where registering on dynamic range is
not valid
---
drivers/misc/misc_minor_kunit.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/misc/misc_minor_kunit.c b/drivers/misc/misc_minor_kunit.c
index 2ef92ce3d053..18f477b18562 100644
--- a/drivers/misc/misc_minor_kunit.c
+++ b/drivers/misc/misc_minor_kunit.c
@@ -557,7 +557,7 @@ static void __init miscdev_test_conflict(struct kunit *test)
*/
miscstat.minor = miscdyn.minor;
ret = misc_register(&miscstat);
- KUNIT_EXPECT_EQ(test, ret, -EBUSY);
+ KUNIT_EXPECT_TRUE(test, ret == -EINVAL || ret == -EBUSY);
if (ret == 0)
misc_deregister(&miscstat);
@@ -591,10 +591,12 @@ static void __init miscdev_test_conflict_reverse(struct kunit *test)
misc_deregister(&miscdyn);
ret = misc_register(&miscstat);
- KUNIT_EXPECT_EQ(test, ret, 0);
- KUNIT_EXPECT_EQ(test, miscstat.minor, miscdyn.minor);
- if (ret == 0)
+ if (ret == 0) {
+ KUNIT_EXPECT_EQ(test, miscstat.minor, miscdyn.minor);
stat_registered = true;
+ } else {
+ KUNIT_EXPECT_EQ(test, ret, -EINVAL);
+ }
/*
* Try to register a dynamic minor after registering a static minor
@@ -604,7 +606,8 @@ static void __init miscdev_test_conflict_reverse(struct kunit *test)
miscdyn.minor = MISC_DYNAMIC_MINOR;
ret = misc_register(&miscdyn);
KUNIT_EXPECT_EQ(test, ret, 0);
- KUNIT_EXPECT_NE(test, miscdyn.minor, miscstat.minor);
+ if (stat_registered)
+ KUNIT_EXPECT_NE(test, miscdyn.minor, miscstat.minor);
KUNIT_EXPECT_TRUE(test, is_valid_dynamic_minor(miscdyn.minor));
if (ret == 0)
misc_deregister(&miscdyn);
--
2.47.2
next prev parent reply other threads:[~2025-07-10 14:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 11:56 [PATCH v5 0/8] char: misc: Various cleanup for miscdevice Zijun Hu
2025-07-10 11:56 ` [PATCH v5 1/8] char: misc: Move drivers/misc/misc_minor_kunit.c to drivers/char/ Zijun Hu
2025-07-10 11:56 ` [PATCH v5 2/8] char: misc: Adapt and add test cases for simple minor space division Zijun Hu
2025-07-10 14:34 ` Thadeu Lima de Souza Cascardo [this message]
2025-07-14 0:42 ` Zijun Hu
2025-07-10 11:56 ` [PATCH v5 3/8] char: misc: Disallow registering miscdevice whose minor > MISC_DYNAMIC_MINOR Zijun Hu
2025-07-10 11:56 ` [PATCH v5 4/8] char: misc: Add a case to test registering miscdevice again without reinitialization Zijun Hu
2025-07-10 11:56 ` [PATCH v5 5/8] char: misc: Fix kunit test case miscdev_test_dynamic_reentry() failure Zijun Hu
2025-07-10 18:15 ` Thadeu Lima de Souza Cascardo
2025-07-14 1:02 ` Zijun Hu
2025-07-14 11:26 ` Thadeu Lima de Souza Cascardo
2025-07-10 11:56 ` [PATCH v5 6/8] char: misc: Does not request module for miscdevice with dynamic minor Zijun Hu
2025-07-10 18:22 ` Thadeu Lima de Souza Cascardo
2025-07-10 11:56 ` [PATCH v5 7/8] char: misc: Register fixed minor EISA_EEPROM_MINOR in linux/miscdevice.h Zijun Hu
2025-07-10 11:56 ` [PATCH v5 8/8] sparc: kernel: apc: Remove macro APC_MINOR definition Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aG_Pjl4Jl7QJxl8f@quatroqueijos.cascardo.eti.br \
--to=cascardo@igalia.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andreas@gaisler.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=zijun.hu@oss.qualcomm.com \
--cc=zijun_hu@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).