From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B77892E7BB5; Thu, 14 Aug 2025 08:29:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755160195; cv=none; b=cR0SCsZw2qgyBWxkWPUHR2TVUe0ENsgWFQIxUYBMEjUlXsZzJSl1qlJCKoLjOCBeoibYUkHTuhvyy2QibiSz5VuoZfvK9R31DITCfUQFRK84GxeBr3ucFwuveTYSsafoNW2ye+l+UOlelPhfT3p1zzrd9P5O3ioey/RjxaPTJG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755160195; c=relaxed/simple; bh=KdLgrtVpCnwmqBeEbXly/JQKZu+/Bf7kGD89aJGLLrc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jJqt0+ktsyhnv5xiLQRFcSMbQ2fT/bhm8wwA/j4eRy0B6pGg+m2h5+rYsVW6qLixp+cJUl3zgMGiXI2OzFuwibRG2JBVNP9knikem9owpKOo/swgLBpI2y2zDTgMETdjDJ8ASM/JoC77S/VE/m/yCV4YdpW+bdq8tVXI7dQnZ6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LgnI8UJS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LgnI8UJS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1718BC4CEF5; Thu, 14 Aug 2025 08:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755160195; bh=KdLgrtVpCnwmqBeEbXly/JQKZu+/Bf7kGD89aJGLLrc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LgnI8UJSan+/NDSjk/Hl6AHksZNLCBmMyv7I6ottubTebiQRbsUfEbvIDnPI6gGb7 x6rD9peFnW3ZpIMR/9Sw0NCDT/TKaw9GCiZc5Tm55FyMr0EYl45K+764RG3cFz4fI/ AYu79A9WpUjtQRiQiYwZLHdOe36W/DJFoXdujFFfoxqO1zQwgTwyMW95wnwzWMRGVr 0ubAitkieacSV3z55Tv/q4eaRXLfMTuzFwh8g6rWiKGYF65msy96rF5AvL2JMO4N+f hg4dAgcVfmh7oQtvcI/niV+/kdkNa8Z2tAOU4/svTc/b8E/uoCdmMTFgfc2wSMzcYB qGs/EbpySPCPw== Date: Thu, 14 Aug 2025 11:29:28 +0300 From: Mike Rapoport To: Lorenzo Stoakes Cc: Andrew Morton , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S . Miller" , Andreas Larsson , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , David Rientjes , Shakeel Butt , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Masami Hiramatsu , Oleg Nesterov , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Jason Gunthorpe , John Hubbard , Peter Xu , Jann Horn , Pedro Falcato , Matthew Wilcox , Mateusz Guzik , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 03/10] mm: convert prctl to mm_flags_*() accessors Message-ID: References: Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Aug 12, 2025 at 04:44:12PM +0100, Lorenzo Stoakes wrote: > As part of the effort to move to mm->flags becoming a bitmap field, convert > existing users to making use of the mm_flags_*() accessors which will, when > the conversion is complete, be the only means of accessing mm_struct flags. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Mike Rapoport (Microsoft) > --- > kernel/sys.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/kernel/sys.c b/kernel/sys.c > index 1e28b40053ce..605f7fe9a143 100644 > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -2392,9 +2392,9 @@ static inline unsigned long get_current_mdwe(void) > { > unsigned long ret = 0; > > - if (test_bit(MMF_HAS_MDWE, ¤t->mm->flags)) > + if (mm_flags_test(MMF_HAS_MDWE, current->mm)) > ret |= PR_MDWE_REFUSE_EXEC_GAIN; > - if (test_bit(MMF_HAS_MDWE_NO_INHERIT, ¤t->mm->flags)) > + if (mm_flags_test(MMF_HAS_MDWE_NO_INHERIT, current->mm)) > ret |= PR_MDWE_NO_INHERIT; > > return ret; > @@ -2427,9 +2427,9 @@ static inline int prctl_set_mdwe(unsigned long bits, unsigned long arg3, > return -EPERM; /* Cannot unset the flags */ > > if (bits & PR_MDWE_NO_INHERIT) > - set_bit(MMF_HAS_MDWE_NO_INHERIT, ¤t->mm->flags); > + mm_flags_set(MMF_HAS_MDWE_NO_INHERIT, current->mm); > if (bits & PR_MDWE_REFUSE_EXEC_GAIN) > - set_bit(MMF_HAS_MDWE, ¤t->mm->flags); > + mm_flags_set(MMF_HAS_MDWE, current->mm); > > return 0; > } > @@ -2627,7 +2627,7 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3, > case PR_GET_THP_DISABLE: > if (arg2 || arg3 || arg4 || arg5) > return -EINVAL; > - error = !!test_bit(MMF_DISABLE_THP, &me->mm->flags); > + error = !!mm_flags_test(MMF_DISABLE_THP, me->mm); > break; > case PR_SET_THP_DISABLE: > if (arg3 || arg4 || arg5) > @@ -2635,9 +2635,9 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3, > if (mmap_write_lock_killable(me->mm)) > return -EINTR; > if (arg2) > - set_bit(MMF_DISABLE_THP, &me->mm->flags); > + mm_flags_set(MMF_DISABLE_THP, me->mm); > else > - clear_bit(MMF_DISABLE_THP, &me->mm->flags); > + mm_flags_clear(MMF_DISABLE_THP, me->mm); > mmap_write_unlock(me->mm); > break; > case PR_MPX_ENABLE_MANAGEMENT: > @@ -2770,7 +2770,7 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3, > if (arg2 || arg3 || arg4 || arg5) > return -EINVAL; > > - error = !!test_bit(MMF_VM_MERGE_ANY, &me->mm->flags); > + error = !!mm_flags_test(MMF_VM_MERGE_ANY, me->mm); > break; > #endif > case PR_RISCV_V_SET_CONTROL: > -- > 2.50.1 > -- Sincerely yours, Mike.