From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D2EF254873; Thu, 14 Aug 2025 08:31:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755160274; cv=none; b=P1vbtk3bQe+vMd8BEeGtV1810ilOgJJBBS26JyGLC3ZmJ4PsPpLHHsRUQndWb2YzxP/BTplwXSigUWidMJDl95AIZ9acKYkPyVWFhZb3ojamN1two0biYmLnZMs7iJtsV8I+TNw0QNuONyCl4M+SNaX/F9txVIjaUGejjffMvH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755160274; c=relaxed/simple; bh=VZwAT4nuFzlo6iiZ+ZB4KjdwEiWrPMXFBSLlSlymS54=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AIi3rkwH6AiGjVlZm9jzVubBQL33lN81UhU+eFMe+4D5FU4SEWAgAkzUo/d1A+GtYg6+Y4QhOW/GV4tDy/MWb3/9/RadFPKIUVATigPCPWiWtQOojsm65r6gNaGj2noWCoHk8fcuZi0p/GKrYCzFnCQVz+5DSyQQdWxG4VsraQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AX8cNCfp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AX8cNCfp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC3ABC4CEEF; Thu, 14 Aug 2025 08:30:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755160274; bh=VZwAT4nuFzlo6iiZ+ZB4KjdwEiWrPMXFBSLlSlymS54=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AX8cNCfpn1HESKoFuAmO+ofK0K08xD2ds6IMbbIAyUZ5G1opIHUqO/jfh0dnqTs1L i+9/9TDQqyuA59+2NNHVDTjjgM3kATsYfk15tvQgNWNLysM5awURk6yWoFT7xQc8Gk FaNfrd36A6c6CWsrMpb/KjIez7XstJ11dFK4CBHKy63X9yPF4p86KG7u/aWQt9onHW cODXDHoRGXmI2Xv/sApKf6oi2erN4CbM0DD8DpC72SsJdg5XdCkoeGqdAGzN9pK35k q4EpVl+/BsX4Pl1c9wfcSUumLoc2uJ8YjQVtcbpPVBRa/degA6woRCYDWZP+OL5XKt 6xP2evtyLgaAQ== Date: Thu, 14 Aug 2025 11:30:51 +0300 From: Mike Rapoport To: Lorenzo Stoakes Cc: Andrew Morton , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S . Miller" , Andreas Larsson , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , David Rientjes , Shakeel Butt , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Masami Hiramatsu , Oleg Nesterov , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Jason Gunthorpe , John Hubbard , Peter Xu , Jann Horn , Pedro Falcato , Matthew Wilcox , Mateusz Guzik , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 04/10] mm: convert arch-specific code to mm_flags_*() accessors Message-ID: References: <6e0a4563fcade8678d0fc99859b3998d4354e82f.1755012943.git.lorenzo.stoakes@oracle.com> Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e0a4563fcade8678d0fc99859b3998d4354e82f.1755012943.git.lorenzo.stoakes@oracle.com> On Tue, Aug 12, 2025 at 04:44:13PM +0100, Lorenzo Stoakes wrote: > As part of the effort to move to mm->flags becoming a bitmap field, convert > existing users to making use of the mm_flags_*() accessors which will, when > the conversion is complete, be the only means of accessing mm_struct flags. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Mike Rapoport (Microsoft) > --- > arch/s390/mm/mmap.c | 4 ++-- > arch/sparc/kernel/sys_sparc_64.c | 4 ++-- > arch/x86/mm/mmap.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/s390/mm/mmap.c b/arch/s390/mm/mmap.c > index 40a526d28184..c884b580eb5e 100644 > --- a/arch/s390/mm/mmap.c > +++ b/arch/s390/mm/mmap.c > @@ -182,10 +182,10 @@ void arch_pick_mmap_layout(struct mm_struct *mm, struct rlimit *rlim_stack) > */ > if (mmap_is_legacy(rlim_stack)) { > mm->mmap_base = mmap_base_legacy(random_factor); > - clear_bit(MMF_TOPDOWN, &mm->flags); > + mm_flags_clear(MMF_TOPDOWN, mm); > } else { > mm->mmap_base = mmap_base(random_factor, rlim_stack); > - set_bit(MMF_TOPDOWN, &mm->flags); > + mm_flag_set(MMF_TOPDOWN, mm); > } > } > > diff --git a/arch/sparc/kernel/sys_sparc_64.c b/arch/sparc/kernel/sys_sparc_64.c > index c5a284df7b41..785e9909340f 100644 > --- a/arch/sparc/kernel/sys_sparc_64.c > +++ b/arch/sparc/kernel/sys_sparc_64.c > @@ -309,7 +309,7 @@ void arch_pick_mmap_layout(struct mm_struct *mm, struct rlimit *rlim_stack) > gap == RLIM_INFINITY || > sysctl_legacy_va_layout) { > mm->mmap_base = TASK_UNMAPPED_BASE + random_factor; > - clear_bit(MMF_TOPDOWN, &mm->flags); > + mm_flags_clear(MMF_TOPDOWN, mm); > } else { > /* We know it's 32-bit */ > unsigned long task_size = STACK_TOP32; > @@ -320,7 +320,7 @@ void arch_pick_mmap_layout(struct mm_struct *mm, struct rlimit *rlim_stack) > gap = (task_size / 6 * 5); > > mm->mmap_base = PAGE_ALIGN(task_size - gap - random_factor); > - set_bit(MMF_TOPDOWN, &mm->flags); > + mm_flags_set(MMF_TOPDOWN, mm); > } > } > > diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c > index 5ed2109211da..708f85dc9380 100644 > --- a/arch/x86/mm/mmap.c > +++ b/arch/x86/mm/mmap.c > @@ -122,9 +122,9 @@ static void arch_pick_mmap_base(unsigned long *base, unsigned long *legacy_base, > void arch_pick_mmap_layout(struct mm_struct *mm, struct rlimit *rlim_stack) > { > if (mmap_is_legacy()) > - clear_bit(MMF_TOPDOWN, &mm->flags); > + mm_flags_clear(MMF_TOPDOWN, mm); > else > - set_bit(MMF_TOPDOWN, &mm->flags); > + mm_flags_set(MMF_TOPDOWN, mm); > > arch_pick_mmap_base(&mm->mmap_base, &mm->mmap_legacy_base, > arch_rnd(mmap64_rnd_bits), task_size_64bit(0), > -- > 2.50.1 > -- Sincerely yours, Mike.