From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78BE230DD1E for ; Mon, 8 Sep 2025 15:27:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757345270; cv=none; b=sZcdOIkLv1eOmMq8eUNeD2o+L+ZiwTlodyXARKZuUYVRrwtSv53y5b7KvHU0dPRJI2fVcpVrufFgftvFoNBPVlr0PlpIO90/yJmgc2Q+Io/HGw9SwapFSpUsEk7jAdRdtddS20wjWNP7yRlHR129kYU3dWy1nkmr+K9QJ/XeRsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757345270; c=relaxed/simple; bh=HVOIDFghFHAfAr3zHIhwiHqv9MxeJCaKUUT633vgvJU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aH1bLiw2O7/AoekWMIw3Zpd40db73JnTvzVAfAR7mFRHfeTqw3VUZE7Y45j+Bk+Q9O2xNnECVTeg5X2DXZoK+fxVAODGNJYUZj+OfqJDJEdSdkRfxAj9kTgbCYCTygh9n3dHPe0HI7qM511+MZ89AYoen4zK+UzKFG650Zvr/s8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=it7AVOP7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="it7AVOP7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757345267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AcVb4aGGb/PCSNKySt679yYA4SUgcrQuR3+AtlRJhW8=; b=it7AVOP700YP7sQU0xZQIpZzKnuluUcodI4I9cfBufWtKxwh6fm+S01rjgVP5NVJfwFjjM PuFPCGaDvL+d+2Jrpu/4UH4ZstoRS9X012V1oZEOoYKri45rH8wzjOI4VU8e+O4fWDVszi MmsJ3AC9TEssyCVixogGc5WMS7zDS1M= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-jEZUE0ncPGievEOS-_xJ3Q-1; Mon, 08 Sep 2025 11:27:43 -0400 X-MC-Unique: jEZUE0ncPGievEOS-_xJ3Q-1 X-Mimecast-MFC-AGG-ID: jEZUE0ncPGievEOS-_xJ3Q_1757345262 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45dd66e1971so30438875e9.2 for ; Mon, 08 Sep 2025 08:27:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757345262; x=1757950062; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AcVb4aGGb/PCSNKySt679yYA4SUgcrQuR3+AtlRJhW8=; b=dPTyLyXx+fRBTgc+M/bpV9RJ+vLNdVBuI8Dj74TcSwwHkV8mdtrZKq+IN8EspRbSo0 qOjAZvZgtMSMiPCEZPguPjS24oH8S3/3dNSrJc/6q+HSCF4NYvG2L2HivNz7LEdNFaql KerteM9qkafApDyIfvU0ih/2+YAawngnk55ThyIAai2n3ETkG5wbXUQsTFvAWg2VExrq jYd4sHXoFuKumnuteu+R7FvSW9sQ+Aty9lLE1Pojlh/Jb0E14ZyMPRYcvooxj0E40WLh z8Z/E97yZu0foVC6PdS4zvJW6f0PCuJ1lt6pRFYqR9PwWlPddRqnT94cxhI+6q+d2iwJ yuGg== X-Forwarded-Encrypted: i=1; AJvYcCWS8WIDwTjW7QmBkOGyeECPQ0fO9q0bPN9vBUIZouj6Rig9tu1B9ChhdLrHPSTSiBV9O5oEjMu5Cqel@vger.kernel.org X-Gm-Message-State: AOJu0YycbLS3nCSni77rHKQHbGDRYvxaeWItsJrI6RvIMOLHVEvduOZD 9cC7ZWYLGHGx2Yh7KOnQv1ZLiuqm2+Oru/Z2CB2jfXM0RPlVRD3Fkm+ooMJF744ks52IO4bfimn zz7MKUQFqLhnFZJdzKHIxvaf9VIZTkHtuhAb4dGiGjjTHhBUkdvcdFoHtPkkCoNE= X-Gm-Gg: ASbGncuQu4ExqVUSUaIFI+MDpo7OwzjtiD0sOrBY7oWO5gcrP1N2OnjLAV3z4HAFGyl g0i/FEDaegnXXb3eqAS2IaNQo+8Lly4trIQtwSQheb3IVJtYYyTfHrqpYrRTwc0n9jT3lq27Tk9 qEDQ0/Quk1QEqYY0NeA0VckzLw4xH39t3uX0485liy//Qm4SNde6xLXt8TPI788hOwPikVEeEYw zzhv20WkI2qMEyKIMRxxJeuKAqS3bI6ApdxAZKPmpeTNgzJ174kazRoIREQ+gooka7S2UINELqx uwHY35qf6wui8khmyyD4fqHnBXbHVldUiG2uTDZUX6DvbnEIrzXeaS1ScKGRpBIFXjjFFu2z/Q1 Z2bgD919Qo/B+HucV3UL2hVuviQw6zzO+0cjQbaDAzm5K6XrkALK5Q9rKe464AbDx X-Received: by 2002:a05:600c:1547:b0:459:dde3:1a56 with SMTP id 5b1f17b1804b1-45dddeda169mr71401925e9.28.1757345261610; Mon, 08 Sep 2025 08:27:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEFqHRAU8/Ayw6xHlY2Njo83Xv4mquQlEJe0L5F6BJtpt3Rw+E9lidjU1mHw6Po2oKE6ibJ0w== X-Received: by 2002:a05:600c:1547:b0:459:dde3:1a56 with SMTP id 5b1f17b1804b1-45dddeda169mr71401445e9.28.1757345261153; Mon, 08 Sep 2025 08:27:41 -0700 (PDT) Received: from ?IPV6:2003:d8:2f25:700:d846:15f3:6ca0:8029? (p200300d82f250700d84615f36ca08029.dip0.t-ipconnect.de. [2003:d8:2f25:700:d846:15f3:6ca0:8029]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b7e8ab14esm485746255e9.21.2025.09.08.08.27.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Sep 2025 08:27:40 -0700 (PDT) Message-ID: Date: Mon, 8 Sep 2025 17:27:37 +0200 Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/16] mm: introduce the f_op->mmap_complete, mmap_abort hooks To: Lorenzo Stoakes , Andrew Morton Cc: Jonathan Corbet , Matthew Wilcox , Guo Ren , Thomas Bogendoerfer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S . Miller" , Andreas Larsson , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Nicolas Pitre , Muchun Song , Oscar Salvador , Konstantin Komarov , Baoquan He , Vivek Goyal , Dave Young , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Uladzislau Rezki , Dmitry Vyukov , Andrey Konovalov , Jann Horn , Pedro Falcato , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-mm@kvack.org, ntfs3@lists.linux.dev, kexec@lists.infradead.org, kasan-dev@googlegroups.com, Jason Gunthorpe References: From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08.09.25 13:10, Lorenzo Stoakes wrote: > We have introduced the f_op->mmap_prepare hook to allow for setting up a > VMA far earlier in the process of mapping memory, reducing problematic > error handling paths, but this does not provide what all > drivers/filesystems need. > > In order to supply this, and to be able to move forward with removing > f_op->mmap altogether, introduce f_op->mmap_complete. > > This hook is called once the VMA is fully mapped and everything is done, > however with the mmap write lock and VMA write locks held. > > The hook is then provided with a fully initialised VMA which it can do what > it needs with, though the mmap and VMA write locks must remain held > throughout. > > It is not intended that the VMA be modified at this point, attempts to do > so will end in tears. > > This allows for operations such as pre-population typically via a remap, or > really anything that requires access to the VMA once initialised. > > In addition, a caller may need to take a lock in mmap_prepare, when it is > possible to modify the VMA, and release it on mmap_complete. In order to > handle errors which may arise between the two operations, f_op->mmap_abort > is provided. > > This hook should be used to drop any lock and clean up anything before the > VMA mapping operation is aborted. After this point the VMA will not be > added to any mapping and will not exist. > > We also add a new mmap_context field to the vm_area_desc type which can be > used to pass information pertinent to any locks which are held or any state > which is required for mmap_complete, abort to operate correctly. > > We also update the compatibility layer for nested filesystems which > currently still only specify an f_op->mmap() handler so that it correctly > invokes f_op->mmap_complete as necessary (note that no error can occur > between mmap_prepare and mmap_complete so mmap_abort will never be called > in this case). > > Also update the VMA tests to account for the changes. > > Signed-off-by: Lorenzo Stoakes > --- > include/linux/fs.h | 4 ++ > include/linux/mm_types.h | 5 ++ > mm/util.c | 18 +++++-- > mm/vma.c | 82 ++++++++++++++++++++++++++++++-- > tools/testing/vma/vma_internal.h | 31 ++++++++++-- > 5 files changed, 129 insertions(+), 11 deletions(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 594bd4d0521e..bb432924993a 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2195,6 +2195,10 @@ struct file_operations { > int (*uring_cmd_iopoll)(struct io_uring_cmd *, struct io_comp_batch *, > unsigned int poll_flags); > int (*mmap_prepare)(struct vm_area_desc *); > + int (*mmap_complete)(struct file *, struct vm_area_struct *, > + const void *context); > + void (*mmap_abort)(const struct file *, const void *vm_private_data, > + const void *context); Do we have a description somewhere what these things do, when they are called, and what a driver may be allowed to do with a VMA? In particular, the mmap_complete() looks like another candidate for letting a driver just go crazy on the vma? :) -- Cheers David / dhildenb