From: Zijun Hu <zijun_hu@icloud.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
"David S. Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
Thadeu Lima de Souza Cascardo <cascardo@igalia.com>,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
sparclinux@vger.kernel.org, Zijun Hu <zijun.hu@oss.qualcomm.com>
Subject: Re: [PATCH v4 6/8] char: misc: Does not request module for miscdevice with dynamic minor
Date: Wed, 9 Jul 2025 20:46:26 +0800 [thread overview]
Message-ID: <dabb7247-1b76-407f-b22f-c1ebd9ab9dd5@icloud.com> (raw)
In-Reply-To: <2025070625-voice-stuffing-e2fa@gregkh>
On 2025/7/6 16:55, Greg Kroah-Hartman wrote:
>> - if (!new_fops)
>> - goto fail;
>> }
>>
>> + if (!new_fops)
>> + goto fail;
>> +
> This is fine, but is it going to break any existing users that happened
> to rely on this behaviour?
no since there are no kernel users who register miscdevice with minor > 255.
next prev parent reply other threads:[~2025-07-09 12:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 13:25 [PATCH v4 0/8] char: misc: Various cleanup for miscdevice Zijun Hu
2025-07-04 13:25 ` [PATCH v4 1/8] char: misc: Move drivers/misc/misc_minor_kunit.c to drivers/char/ Zijun Hu
2025-07-06 8:51 ` Greg Kroah-Hartman
2025-07-04 13:26 ` [PATCH v4 2/8] char: misc: Adapt and add test cases for simple minor space division Zijun Hu
2025-07-06 8:52 ` Greg Kroah-Hartman
2025-07-04 13:26 ` [PATCH v4 3/8] char: misc: Disallow registering miscdevice whose minor > MISC_DYNAMIC_MINOR Zijun Hu
2025-07-04 13:26 ` [PATCH v4 4/8] char: misc: Add a reentry test case about dynamic minor request Zijun Hu
2025-07-04 13:26 ` [PATCH v4 5/8] char: misc: Make registering miscdevice reentry who wants dynamic minor Zijun Hu
2025-07-06 8:55 ` Greg Kroah-Hartman
2025-07-09 12:41 ` Zijun Hu
2025-07-09 13:10 ` Greg Kroah-Hartman
2025-07-04 13:26 ` [PATCH v4 6/8] char: misc: Does not request module for miscdevice with " Zijun Hu
2025-07-06 8:55 ` Greg Kroah-Hartman
2025-07-09 12:46 ` Zijun Hu [this message]
2025-07-04 13:26 ` [PATCH v4 7/8] char: misc: Register fixed minor EISA_EEPROM_MINOR in linux/miscdevice.h Zijun Hu
2025-07-04 13:26 ` [PATCH v4 8/8] sparc: kernel: apc: Remove macro APC_MINOR definition Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dabb7247-1b76-407f-b22f-c1ebd9ab9dd5@icloud.com \
--to=zijun_hu@icloud.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andreas@gaisler.com \
--cc=arnd@arndb.de \
--cc=cascardo@igalia.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=zijun.hu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).