From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AAAD223DF6 for ; Tue, 26 Aug 2025 13:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756213537; cv=none; b=HFI02Zu8tDBltZDHTs9vKHXmJ1lc1NrTetTvPDbt42K9HYbyvz3fdnyRUw9tLqujOJYceF0YARAiZYEzgWzUb8jPyEfgO0et2UnG5SmoobuKnxB/dqflkbgCzQq0d33gTB/o9MPlMXLDtDpyx2UcEPa9s6+Tgrs1yvwHvgNOP7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756213537; c=relaxed/simple; bh=FH1P8Y3Rlx+VsxrV8Fk6g6bj+LlOmbkGsQwEvGMw8wo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KVjmB9/t4k3nSZNSGSUWETT7CqhwQeO3GuFXNU97GprO2cbaQLXn+CXBtdveEap772M1nwOoG3L+Sf6mHkqIodPIWYudknaUWQzagWfSAyRx9uIqWlmteL5KKNW2jwrO0VnYsygFSoGJlddA4bKjn0U0xU55tX75wkezz0Lb7fU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gkNCk8L3; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gkNCk8L3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756213534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1BB02iWNVIJ9mg9RLb+t+28O/xwbqNfMBkX4EOOZu44=; b=gkNCk8L3/8fsanUdnqZNfJBNNS3rDuiK7CCEZIK20PO5gTTXkAvwWKf6a4Ar07qtcd/gkF I/oJymxWjN2G5GN5GgNNoe0HJ6k5lG3ZSzDDxd/h1NnHFva7qr5VP30lqFIEx/7SBqaL3e h4anDE8bKgClgvqip/m2X9/8oPWARCE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-185-hIzFuClBNbuA1lAKE43-zQ-1; Tue, 26 Aug 2025 09:05:33 -0400 X-MC-Unique: hIzFuClBNbuA1lAKE43-zQ-1 X-Mimecast-MFC-AGG-ID: hIzFuClBNbuA1lAKE43-zQ_1756213532 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45a1b0045a0so38344475e9.0 for ; Tue, 26 Aug 2025 06:05:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756213532; x=1756818332; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1BB02iWNVIJ9mg9RLb+t+28O/xwbqNfMBkX4EOOZu44=; b=HMAJ4YXZXEnz4rGTOtiChHcqQEMlNYJj3dLU1pYkxiQCqMf049ApTCYIDqjxfU2juL yopcAamdxgSE/WYqFvMGLVDa3PO2EN8KrTxzZJYhNRWyX2yhw/8/jGrRJVU4coq1Td6p Zq9ZalYTweVtW5RQX/d+fZ97p+6YbYaU2d+ZsxgEy3ySi5HmaFmtRCwaJ0kyE4KPWns8 TM2lqP18dvYkV12tl0lj4KNI33Vg3mPHd0u2F55Dp4Kph43u+vN7qaFAp+OeagoHLEUS v+NeNp5aQu+HHasyQgO1tjQB4BbIIFdapWYjxCE93aTODqzA3ZQPrrS+jn4tnlPHNTyH Jjhg== X-Forwarded-Encrypted: i=1; AJvYcCULeT8ZGJGUOibjDw1vdmzq8AHal9cGem+DU+eZqoeTSPSfmhzGzbJejpikS56jTRn3wkbrzucuHOsR@vger.kernel.org X-Gm-Message-State: AOJu0YxMCj+ONhyng8GBCreLqd6f/G4LS4i3silVd0WTCTKat0YGqfCg fFdWdJR+IJdImzCFEVWjAhb9+1MGIV8OQacrQm39K3g7Rq/0Q4bOPK8Cb8hful6AXbqF0hkcmlA ItpZ+OfXwi37SZMtJcLZ+sbnXWsDtwu5ygLCfl+T4KRbhsqFqK9NqX1CAY8zONWc= X-Gm-Gg: ASbGncsE52qd0MwMP3XQyotozEMFnDUXBM31ASZKQZdJhOPWbO6gUt/26LN8tJEGmpR Z2Bx5ewnV5WkvySCFamWe+MtfmNEVHNgjg5+Wm363Uof/sL1/HT9u9NNk975DS97C1xIUnXq5Q8 TDsUMQaKfexDEZ0/Uu0gloGVu3BghqIDsnVJFS1LjQhy1vvaEt5fnllocRSbYuFE3sPFr7yGG0d sQF8nntdYgZzg90zVYv9HPiqXVIAGGu4J/db6WZ33ZGgIZfnwhJKFaWHCVqNBRRHDS5y3LDvVmu dTXpn8IlKLlqk5BkRDIHn1qY2WKWDg7ScxMVdTMwDaBT4Ks4O/r4rqGu7IH0lIKbwEM39mT9mg= = X-Received: by 2002:a5d:5d0a:0:b0:3c7:6348:4086 with SMTP id ffacd0b85a97d-3c763484467mr7275245f8f.1.1756213531680; Tue, 26 Aug 2025 06:05:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IED6aZTaK2lqB/sF3ARmnAdAwZO8b9lpHwjPZdqb85yBXUF5jouz9AriJp/YIpO7DcxRXsArw== X-Received: by 2002:a5d:5d0a:0:b0:3c7:6348:4086 with SMTP id ffacd0b85a97d-3c763484467mr7275175f8f.1.1756213531071; Tue, 26 Aug 2025 06:05:31 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c7117d5b10sm16090666f8f.47.2025.08.26.06.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Aug 2025 06:05:30 -0700 (PDT) Message-ID: Date: Tue, 26 Aug 2025 15:05:27 +0200 Precedence: bulk X-Mailing-List: sparclinux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/10] mm: correct sign-extension issue in MMF_* flag masks To: Lorenzo Stoakes , Andrew Morton Cc: Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S . Miller" , Andreas Larsson , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , David Rientjes , Shakeel Butt , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Masami Hiramatsu , Oleg Nesterov , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Jason Gunthorpe , John Hubbard , Peter Xu , Jann Horn , Pedro Falcato , Matthew Wilcox , Mateusz Guzik , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org References: From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12.08.25 17:44, Lorenzo Stoakes wrote: > There is an issue with the mask declarations in linux/mm_types.h, which > naively do (1 << bit) operations. Unfortunately this results in the 1 being > defaulted as a signed (32-bit) integer. > > When the compiler expands the MMF_INIT_MASK bitmask it comes up with: > > (((1 << 2) - 1) | (((1 << 9) - 1) << 2) | (1 << 24) | (1 << 28) | (1 << 30) > | (1 << 31)) > > Which overflows the signed integer to -788,527,105. Implicitly casting this > to an unsigned integer results in sign-expansion, and thus this value > becomes 0xffffffffd10007ff, rather than the intended 0xd10007ff. > > While we're limited to a maximum of 32 bits in mm->flags, this isn't an > issue as the remaining bits being masked will always be zero. > > However, now we are moving towards having more bits in this flag, this > becomes an issue. > > Simply resolve this by using the _BITUL() helper to cast the shifted value > to an unsigned long. Hmm, I thought BIT() should be used and would just fine? include/linux/bits.h includes where we have #define BIT(nr) (UL(1) << (nr)) In contrast, _BITUL is a uapi thingy from include/uapi/linux/const.h ... as it seems. $ git grep "_BITUL" -- include/linux/ include/linux/mm_types.h:#define MMF_DUMPABLE_MASK (_BITUL(MMF_DUMPABLE_BITS) - 1) include/linux/mm_types.h: ((_BITUL(MMF_DUMP_FILTER_BITS) - 1) << MMF_DUMP_FILTER_SHIFT) include/linux/mm_types.h: (_BITUL(MMF_DUMP_ANON_PRIVATE) | _BITUL(MMF_DUMP_ANON_SHARED) | \ include/linux/mm_types.h: _BITUL(MMF_DUMP_HUGETLB_PRIVATE) | MMF_DUMP_MASK_DEFAULT_ELF) include/linux/mm_types.h:# define MMF_DUMP_MASK_DEFAULT_ELF _BITUL(MMF_DUMP_ELF_HEADERS) include/linux/mm_types.h:#define MMF_DISABLE_THP_MASK (_BITUL(MMF_DISABLE_THP_COMPLETELY) | \ include/linux/mm_types.h: _BITUL(MMF_DISABLE_THP_EXCEPT_ADVISED)) include/linux/mm_types.h:#define MMF_HAS_MDWE_MASK _BITUL(MMF_HAS_MDWE) include/linux/mm_types.h:#define MMF_VM_MERGE_ANY_MASK _BITUL(MMF_VM_MERGE_ANY) include/linux/mm_types.h:#define MMF_TOPDOWN_MASK _BITUL(MMF_TOPDOWN) Oh, hey, it's only your changes :P We should better just be using BIT(). -- Cheers David / dhildenb