From: Walker, Benjamin <benjamin.walker at intel.com>
To: spdk@lists.01.org
Subject: Re: [SPDK] Why do you need cntrlid unique across all subsystems
Date: Wed, 22 Mar 2017 16:22:42 +0000 [thread overview]
Message-ID: <1490199760.20464.6.camel@intel.com> (raw)
In-Reply-To: CAGYjvj1FBXF1iHhzqmWFF7bbdbUHdu7mMHW9xcwdbKq5nK2GkA@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
On Wed, 2017-03-22 at 21:30 +0530, Sriram Popuri wrote:
> Hi experts,
>
> I was looking at the function spdk_nvmf_session_gen_cntlid().
> Looks like the cntlid is unique across all nvme subsystems.
> I thought the cntlid is unique in a subsystem as per the spec. Am I
> missing something here?
You're right that the specification only requires cntlid to be unique
within a subsystem. As part of an earlier effort to allocate resources
to new connections more efficiently we made the cntlid globally unique.
However, that effort didn't bear any fruit and we're now pursuing a
different, better option. The cntlid can be changed to be only unique
within a subsystem again if you or anyone wanted to create a patch.
It's not hurting anything by being globally unique, but it doesn't need
to be.
>
> Regards,
> ~Sriram
> _______________________________________________
> SPDK mailing list
> SPDK(a)lists.01.org
> https://lists.01.org/mailman/listinfo/spdk
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3274 bytes --]
next reply other threads:[~2017-03-22 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 16:22 Walker, Benjamin [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-22 18:06 [SPDK] Why do you need cntrlid unique across all subsystems Sriram Popuri
2017-03-22 16:00 Sriram Popuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490199760.20464.6.camel@intel.com \
--to=spdk@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox