From: Walker, Benjamin <benjamin.walker at intel.com>
To: spdk@lists.01.org
Subject: Re: [SPDK] nvmf/rdma: handling QP errors
Date: Fri, 06 Apr 2018 17:37:53 +0000 [thread overview]
Message-ID: <1523036198.3669.7.camel@intel.com> (raw)
In-Reply-To: DM5PR04MB0379711EF5B8A4C7118C41C386BB0@DM5PR04MB0379.namprd04.prod.outlook.com
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On Thu, 2018-04-05 at 23:17 +0000, Philipp Skadorov wrote:
> Hi there,
> Looking at the list of errors ibv_get_async_event offers – would it make sense
> to monitor them in the polling loops?
> Right now, per my understanding, the only way SPDK gets that things go wrong
> is: when initiator issues disconnect.
> Any thoughts?
I agree with you. Monitoring for network errors this way is probably going to be
the right path forward. The challenge is doing it in a way that doesn't impact
performance, which means doing this polling inline with the code that attempts
to accept new connections. Take a look at the function "spdk_nvmf_rdma_accept",
which periodically polls rdma_get_cm_event to detect new or removed connections.
I wouldn't be surprised if rdma_get_cm_event is actually built on top of
ibv_get_async_event, but it certainly provides less detail.
>
> Regards,
> Philipp
> _______________________________________________
> SPDK mailing list
> SPDK(a)lists.01.org
> https://lists.01.org/mailman/listinfo/spdk
next reply other threads:[~2018-04-06 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 17:37 Walker, Benjamin [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-05 23:17 [SPDK] nvmf/rdma: handling QP errors Philipp Skadorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523036198.3669.7.camel@intel.com \
--to=spdk@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox