From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5360565814494160044==" MIME-Version: 1.0 From: Lorne Li Subject: [SPDK] Report a potential race condition in nvmf target Date: Sat, 28 Sep 2019 02:06:19 +0000 Message-ID: <30664e6c.96b4.16b8856c4a9.Coremail.lorneli@163.com> List-ID: To: spdk@lists.01.org --===============5360565814494160044== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi all, I think there may exist a race condition in nvmf target. When adding or removing a namespace, nvmf target using `spdk_nvmf_ctrlr_ns= _changed` to notify its ctrlr that ns has been changed from subsystem's thr= ead('app thread'). But I think func `spdk_nvmf_ctrlr_ns_changed` should be= called in ctrlr's thread, since it touches ctrlr's variables and even tran= sfers out ctrlr's aer_req. Last week, I launched a issue https://github.com/spdk/spdk/issues/837 in gi= thub to describe this race condition in detail and a panic likely caused by= this. It would be great if someone could take a look at it. Thanks in advance. | Lorne Li lorneli(a)163.com | =E7=AD=BE=E5=90=8D=E7=94=B1=E7=BD=91=E6=98=93=E9=82=AE=E7=AE=B1=E5=A4=A7=E5= =B8=88=E5=AE=9A=E5=88=B6 --===============5360565814494160044==--