Re: [SPDK] Content for v18.10.x

[Sasha Kotchubievsky <sashakot at dev.mellanox.co.il>]

[-- Attachment #1: Type: text/plain, Size: 8201 bytes --]

Hi Jim,

If you need my help to investigate the issue, let me know.

Do you see the same pattern in both branches in "master" and in "18.10.1"?

Best regards

Sasha

On 12/17/2018 5:36 PM, Harris, James R wrote:
> Hi Sasha,
>
> 437348 failed the first time in the Chandler test pool.  It had a signature that neither Ben nor me had seen before, and we were concerned that fixing the refcnt was exposing some other issue.  I personally haven't looked through all of the test failures on master since that patch was merged.  It's possible there are other fixes on master that aren't in 18.10.x yet.  So for now, I'm leaning against merging the refcnt patch for 18.10.1.
>
> -Jim
>
>
> On 12/16/18, 4:31 AM, "SPDK on behalf of Sasha Kotchubievsky" <spdk-bounces(a)lists.01.org on behalf of sashakot(a)dev.mellanox.co.il> wrote:
>
>      On 12/14/2018 6:21 PM, Harris, James R wrote:
>      >
>      > On 12/13/18, 12:46 AM, "SPDK on behalf of Sasha Kotchubievsky" <spdk-bounces(a)lists.01.org on behalf of sashakot(a)dev.mellanox.co.il> wrote:
>      >
>      >      Hi,
>      >
>      >      Thanks, for information.
>      >
>      >      Patch https://review.gerrithub.io/c/spdk/spdk/+/430802 is merged today
>      >      to "master". It will be nice, if you get it to 18.10.1 too.
>      >
>      >      Regarding to:
>      >
>      >      https://review.gerrithub.io/c/spdk/spdk/+/436974
>      >
>      >      https://review.gerrithub.io/c/spdk/spdk/+/436887
>      >
>      > Hi Sasha,
>      >
>      > The two patches mentioned have been merged to master and are in the build queue for 18.10.1 (URLs below):
>      > https://review.gerrithub.io/#/c/spdk/spdk/+/437348/
>      > https://review.gerrithub.io/#/c/spdk/spdk/+/437349/
>      
>      Hi Jim,
>      
>      Patch https://review.gerrithub.io/c/spdk/spdk/+/437348/ is abandoned
>      from 18.10.1
>      
>      The patch fixes ref counters issue introduced by
>      https://github.com/spdk/spdk/commit/567b1006a9d4533e5ae03d78b11040f5da0fe278#diff-28f9c2af26bafb4a7268c9aa7b9b65b7L590
>      and merged already into 18.10.1
>      
>      Sasha
>      
>      
>      >
>      > Regards,
>      >
>      > -Jim
>      >
>      >
>      >      I think, they fix/improve NVMF-OF (RDMA) solution and should be considered for merging into release version.
>      >      Ben, Jim  could you review those patches and merge them to "master" if they are OK with you.
>      >
>      >      Best regards
>      >      Sasha
>      >
>      >      On 12/13/2018 7:11 AM, Zawadzki, Tomasz wrote:
>      >      > Hi Sasha,
>      >      >
>      >      >
>      >      >
>      >      > The patch 'env_dpdk: tell DPDK to not free dynamically allocated memory' is merged to 18.10.x.
>      >      >
>      >      > Please see this list<https://review.gerrithub.io/#/q/project:spdk/spdk+branch:v18.10.x> on Gerrithub for up to date patches going into that branch.
>      >      >
>      >      >
>      >      >
>      >      > For the rest of the patches listed, we didn’t merge every fix between 18.10 and current master. Only focusing on the critical ones that got merged to master.
>      >      >
>      >      > We will look into those and see which could be integrated into 18.10.x , assuming they get merged to master first.
>      >      >
>      >      >
>      >      >
>      >      > Thanks,
>      >      >
>      >      > Tomek
>      >      >
>      >      >
>      >      >
>      >      > -----Original Message-----
>      >      > From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Sasha Kotchubievsky
>      >      > Sent: Wednesday, December 12, 2018 9:29 PM
>      >      > To: spdk(a)lists.01.org
>      >      > Subject: Re: [SPDK] Content for v18.10.x
>      >      >
>      >      >
>      >      >
>      >      > Hi Tomek,
>      >      >
>      >      >
>      >      >
>      >      >
>      >      >
>      >      > Great news
>      >      >
>      >      >
>      >      >
>      >      > Can you confirm that 2M page issue in NVME-OF RDMA is fixed in 18.10.1?
>      >      >
>      >      >
>      >      >
>      >      > It was fixed by https://github.com/spdk/spdk/commit/7a58660 , which is not in the 18.10.X .  But, maybe it's fixed by other patches that are in.
>      >      >
>      >      >
>      >      >
>      >      > If you need some help to reproduce and retest the issue, let me know.
>      >      >
>      >      >
>      >      >
>      >      > I'd consider to merge following patches  into 18.10.1:
>      >      >
>      >      >
>      >      >
>      >      >    -  https://review.gerrithub.io/c/spdk/spdk/+/436974  - This patch fixes resource leakage
>      >      >
>      >      >
>      >      >
>      >      >   -  https://review.gerrithub.io/c/spdk/spdk/+/436887 improves error handling
>      >      >
>      >      >
>      >      >
>      >      >   - https://review.gerrithub.io/c/spdk/spdk/+/430802  - This patch fixes tests compilation on ARM platform. It's pretty annoying issue.
>      >      >
>      >      >
>      >      >
>      >      > Thanks
>      >      >
>      >      >
>      >      >
>      >      > Sasha
>      >      >
>      >      >
>      >      >
>      >      > On 12/12/2018 10:17 PM, Zawadzki, Tomasz wrote:
>      >      >
>      >      >> Hi Sasha,
>      >      >> Yes, there is an update to SPDK 18.10.1 coming that focuses on adding packaging for SPDK, along with important fixes that were merged since last release.
>      >      >> Most of the patches were cherry-picked and merged into 18.10.x branch. Currently finishing up couple of the last ones.
>      >      >> The plan is to release it by end of this week.
>      >      >> Thanks,
>      >      >> Tomek
>      >      >> -----Original Message-----
>      >      >> From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Sasha
>      >      >> Kotchubievsky
>      >      >> Sent: Wednesday, December 12, 2018 11:02 AM
>      >      >> To: Storage Performance Development Kit <spdk(a)lists.01.org<mailto:spdk(a)lists.01.org>>
>      >      >> Subject: [SPDK] Content for v18.10.x
>      >      >> Hi,
>      >      >> As I see, some patches from "master" are merged into v18.10.x branch.
>      >      >> https://github.com/spdk/spdk/tree/v18.10.x
>      >      >> Are there plans to update v18.10 released in October?
>      >      >> Best regards
>      >      >> Sasha
>      >      >> _______________________________________________
>      >      >> SPDK mailing list
>      >      >> SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
>      >      >> https://lists.01.org/mailman/listinfo/spdk
>      >      >> _______________________________________________
>      >      >> SPDK mailing list
>      >      >> SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
>      >      >> https://lists.01.org/mailman/listinfo/spdk
>      >      > _______________________________________________
>      >      >
>      >      > SPDK mailing list
>      >      >
>      >      > SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
>      >      >
>      >      > https://lists.01.org/mailman/listinfo/spdk
>      >      > _______________________________________________
>      >      > SPDK mailing list
>      >      > SPDK(a)lists.01.org
>      >      > https://lists.01.org/mailman/listinfo/spdk
>      >      _______________________________________________
>      >      SPDK mailing list
>      >      SPDK(a)lists.01.org
>      >      https://lists.01.org/mailman/listinfo/spdk
>      >
>      >
>      > _______________________________________________
>      > SPDK mailing list
>      > SPDK(a)lists.01.org
>      > https://lists.01.org/mailman/listinfo/spdk
>      _______________________________________________
>      SPDK mailing list
>      SPDK(a)lists.01.org
>      https://lists.01.org/mailman/listinfo/spdk
>      
>
> _______________________________________________
> SPDK mailing list
> SPDK(a)lists.01.org
> https://lists.01.org/mailman/listinfo/spdk