From: Harris, James R <james.r.harris at intel.com>
To: spdk@lists.01.org
Subject: Re: [SPDK] Git submodule dirty
Date: Tue, 07 Aug 2018 14:32:39 +0000 [thread overview]
Message-ID: <6E8DF4F0-A189-44DD-B127-42F50AC51184@intel.com> (raw)
In-Reply-To: 21E5B7AF-9E53-4E58-BA3D-84E217F88F72@gmail.com
[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]
It’s probably the rsync into the VM. These files are symlinks in DPDK but by default rsync will not preserve the symlink but copy the backing file instead. git is detecting that the file type has changed.
Sent from my iPhone
> On Aug 7, 2018, at 7:16 AM, John Meneghini <john.a.meneghini(a)gmail.com> wrote:
>
> Has anyone seen this problem before?
>
> After updating the master branch I see that my dpdk submodule is dirty.
>
> Fedora:vagrant:spdk(vagrant_hugepgs) > git status
> On branch vagrant_hugepgs
> Changes not staged for commit:
> (use "git add <file>..." to update what will be committed)
> (use "git checkout -- <file>..." to discard changes in working directory)
> (commit or discard the untracked or modified content in submodules)
>
> modified: dpdk (modified content)
>
> no changes added to commit (use "git add" and/or "git commit -a")
>
> Fedora:vagrant:spdk(vagrant_hugepgs) > git diff
> diff --git a/dpdk b/dpdk
> --- a/dpdk
> +++ b/dpdk
> @@ -1 +1 @@
> -Subproject commit b6ae5bcff6ca09a7e1536eaa449aa6f4e704a6d9
> +Subproject commit b6ae5bcff6ca09a7e1536eaa449aa6f4e704a6d9-dirty
>
> Fedora:vagrant:spdk(vagrant_hugepgs) > cd dpdk
> Fedora:vagrant:dpdk((b6ae5bcff...)) > git status
> HEAD detached at b6ae5bcff
> Changes not staged for commit:
> (use "git add <file>..." to update what will be committed)
> (use "git checkout -- <file>..." to discard changes in working directory)
>
> typechange: app/test-bbdev/turbo_dec_default.data
> typechange: app/test-bbdev/turbo_enc_default.data
>
> More at:
>
> https://stackoverflow.com/questions/4873980/git-diff-says-subproject-is-dirty
>
>
> John Meneghini
> john.a.meneghini(a)gmail.com
>
>
>
> _______________________________________________
> SPDK mailing list
> SPDK(a)lists.01.org
> https://lists.01.org/mailman/listinfo/spdk
next reply other threads:[~2018-08-07 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 14:32 Harris, James R [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-07 15:59 [SPDK] Git submodule dirty Harris, James R
2018-08-07 15:00 Meneghini, John
2018-08-07 14:48 Luse, Paul E
2018-08-07 14:40 John Barnard
2018-08-07 14:16 John Meneghini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6E8DF4F0-A189-44DD-B127-42F50AC51184@intel.com \
--to=spdk@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).