From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1185521095975173447==" MIME-Version: 1.0 From: Harris, James R Subject: Re: [SPDK] Content for v18.10.x Date: Mon, 17 Dec 2018 15:36:21 +0000 Message-ID: <6FFBF975-EF6E-4399-885F-7A9455A419EF@intel.com> In-Reply-To: 105fedcb-aae9-5a45-673a-0b5a97c77411@dev.mellanox.co.il List-ID: To: spdk@lists.01.org --===============1185521095975173447== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Sasha, 437348 failed the first time in the Chandler test pool. It had a signature= that neither Ben nor me had seen before, and we were concerned that fixing= the refcnt was exposing some other issue. I personally haven't looked thr= ough all of the test failures on master since that patch was merged. It's = possible there are other fixes on master that aren't in 18.10.x yet. So fo= r now, I'm leaning against merging the refcnt patch for 18.10.1. -Jim =EF=BB=BFOn 12/16/18, 4:31 AM, "SPDK on behalf of Sasha Kotchubievsky" wrote: On 12/14/2018 6:21 PM, Harris, James R wrote: > > On 12/13/18, 12:46 AM, "SPDK on behalf of Sasha Kotchubievsky" wrote: > > Hi, > = > Thanks, for information. > = > Patch https://review.gerrithub.io/c/spdk/spdk/+/430802 is merged= today > to "master". It will be nice, if you get it to 18.10.1 too. > = > Regarding to: > = > https://review.gerrithub.io/c/spdk/spdk/+/436974 > = > https://review.gerrithub.io/c/spdk/spdk/+/436887 > > Hi Sasha, > > The two patches mentioned have been merged to master and are in the b= uild queue for 18.10.1 (URLs below): > https://review.gerrithub.io/#/c/spdk/spdk/+/437348/ > https://review.gerrithub.io/#/c/spdk/spdk/+/437349/ = Hi Jim, = Patch https://review.gerrithub.io/c/spdk/spdk/+/437348/ is abandoned = from 18.10.1 = The patch fixes ref counters issue introduced by = https://github.com/spdk/spdk/commit/567b1006a9d4533e5ae03d78b11040f5da0= fe278#diff-28f9c2af26bafb4a7268c9aa7b9b65b7L590 = and merged already into 18.10.1 = Sasha = = > > Regards, > > -Jim > > = > I think, they fix/improve NVMF-OF (RDMA) solution and should be = considered for merging into release version. > Ben, Jim could you review those patches and merge them to "mast= er" if they are OK with you. > = > Best regards > Sasha > = > On 12/13/2018 7:11 AM, Zawadzki, Tomasz wrote: > > Hi Sasha, > > > > > > > > The patch 'env_dpdk: tell DPDK to not free dynamically allocat= ed memory' is merged to 18.10.x. > > > > Please see this list on Gerrithub for up to date patches going into th= at branch. > > > > > > > > For the rest of the patches listed, we didn=E2=80=99t merge ev= ery fix between 18.10 and current master. Only focusing on the critical one= s that got merged to master. > > > > We will look into those and see which could be integrated into= 18.10.x , assuming they get merged to master first. > > > > > > > > Thanks, > > > > Tomek > > > > > > > > -----Original Message----- > > From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of S= asha Kotchubievsky > > Sent: Wednesday, December 12, 2018 9:29 PM > > To: spdk(a)lists.01.org > > Subject: Re: [SPDK] Content for v18.10.x > > > > > > > > Hi Tomek, > > > > > > > > > > > > Great news > > > > > > > > Can you confirm that 2M page issue in NVME-OF RDMA is fixed in= 18.10.1? > > > > > > > > It was fixed by https://github.com/spdk/spdk/commit/7a58660 , = which is not in the 18.10.X . But, maybe it's fixed by other patches that = are in. > > > > > > > > If you need some help to reproduce and retest the issue, let m= e know. > > > > > > > > I'd consider to merge following patches into 18.10.1: > > > > > > > > - https://review.gerrithub.io/c/spdk/spdk/+/436974 - This= patch fixes resource leakage > > > > > > > > - https://review.gerrithub.io/c/spdk/spdk/+/436887 improves= error handling > > > > > > > > - https://review.gerrithub.io/c/spdk/spdk/+/430802 - This p= atch fixes tests compilation on ARM platform. It's pretty annoying issue. > > > > > > > > Thanks > > > > > > > > Sasha > > > > > > > > On 12/12/2018 10:17 PM, Zawadzki, Tomasz wrote: > > > >> Hi Sasha, > >> Yes, there is an update to SPDK 18.10.1 coming that focuses o= n adding packaging for SPDK, along with important fixes that were merged si= nce last release. > >> Most of the patches were cherry-picked and merged into 18.10.= x branch. Currently finishing up couple of the last ones. > >> The plan is to release it by end of this week. > >> Thanks, > >> Tomek > >> -----Original Message----- > >> From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of = Sasha > >> Kotchubievsky > >> Sent: Wednesday, December 12, 2018 11:02 AM > >> To: Storage Performance Development Kit > > >> Subject: [SPDK] Content for v18.10.x > >> Hi, > >> As I see, some patches from "master" are merged into v18.10.x= branch. > >> https://github.com/spdk/spdk/tree/v18.10.x > >> Are there plans to update v18.10 released in October? > >> Best regards > >> Sasha > >> _______________________________________________ > >> SPDK mailing list > >> SPDK(a)lists.01.org > >> https://lists.01.org/mailman/listinfo/spdk > >> _______________________________________________ > >> SPDK mailing list > >> SPDK(a)lists.01.org > >> https://lists.01.org/mailman/listinfo/spdk > > _______________________________________________ > > > > SPDK mailing list > > > > SPDK(a)lists.01.org > > > > https://lists.01.org/mailman/listinfo/spdk > > _______________________________________________ > > SPDK mailing list > > SPDK(a)lists.01.org > > https://lists.01.org/mailman/listinfo/spdk > _______________________________________________ > SPDK mailing list > SPDK(a)lists.01.org > https://lists.01.org/mailman/listinfo/spdk > = > > _______________________________________________ > SPDK mailing list > SPDK(a)lists.01.org > https://lists.01.org/mailman/listinfo/spdk _______________________________________________ SPDK mailing list SPDK(a)lists.01.org https://lists.01.org/mailman/listinfo/spdk = --===============1185521095975173447==--