spdk.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Walker, Benjamin <benjamin.walker at intel.com>
To: spdk@lists.01.org
Subject: [SPDK] Re: SPDK socket abstraction layer
Date: Thu, 31 Oct 2019 18:54:50 +0000	[thread overview]
Message-ID: <7c17efd207274a60451415e26dee896d2a7af22b.camel@intel.com> (raw)
In-Reply-To: f5415d8f-7633-244c-15c6-453bf240bdd3@dev.mellanox.co.il

[-- Attachment #1: Type: text/plain, Size: 1870 bytes --]

On Thu, 2019-10-31 at 16:21 +0200, Sasha Kotchubievsky wrote:
> > However, I just figured out what's wrong, so maybe you can help me fix it.
> > The
> > zero copy is all working mechanically, except when I get the zero copy
> > completion notification, ee_code is set to SO_EE_CODE_ZEROCOPY_COPIED. So
> > something is not configured correctly in my networking stack and the kernel
> > is
> > doing deferred copies instead. Any ideas what I'd need to do in order to
> > enable
> > this? I'm fairly certain I have it working at my desk on Fedora 30 in
> > loopback,
> > based on the CPU traces I'm seeing, so maybe it's just a matter of
> > installing
> > Fedora 30 on the benchmark system instead.
> 
> I don't know about any specific setting for enabling ZERO-COPY. But, let 
> me double check that.
> 
> > Is it enough to apply those two patches for zero-copy in target ?
> > 
> > Asynchronous writevhttps://review.gerrithub.io/c/spdk/spdk/+/470523
> > 
> > MSG_ZEROCOPY use in the posix implementation
> > https://review.gerrithub.io/c/spdk/spdk/+/471752
> > Let me get the patches sorted out in a nice series and then you can grab the
> > top
> > of the series for testing.
> 
> This will be great.  On Sunday, we will create an environment like 
> yours  (except OS) and will check the feature.


Here's the patch at the top of the series:
https://review.gerrithub.io/c/spdk/spdk/+/471752

Zero copy is getting enabled on the socket and I do see completion
notifications, but it's always doing a deferred copy. If there was some
description somewhere of what causes the kernel to end up doing a deferred copy
instead of page pinning that would be really useful.

> 
> _______________________________________________
> SPDK mailing list -- spdk(a)lists.01.org
> To unsubscribe send an email to spdk-leave(a)lists.01.org


             reply	other threads:[~2019-10-31 18:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 18:54 Walker, Benjamin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-06-01 16:55 [SPDK] Re: SPDK socket abstraction layer Zawadzki, Tomasz
2019-11-07 18:45 Walker, Benjamin
2019-11-07 16:26 Or Gerlitz
2019-11-06 10:19 Or Gerlitz
2019-11-05 19:56 Sasha Kotchubievsky
2019-11-05 18:08 Walker, Benjamin
2019-11-05 15:06 Or Gerlitz
2019-11-05  5:29 allenz
2019-11-03 16:56 Walker, Benjamin
2019-11-03 15:59 Or Gerlitz
2019-10-31 21:11 Andrey Kuzmin
2019-10-31 14:21 Sasha Kotchubievsky
2019-10-30 23:20 Walker, Benjamin
2019-10-30 21:47 Sasha Kotchubievsky
2019-10-30 20:28 Walker, Benjamin
2019-10-30 19:55 Sasha Kotchubievsky
2019-10-30 18:46 Walker, Benjamin
2019-10-30 17:54 Harris, James R
2019-10-30 17:50 Sasha Kotchubievsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c17efd207274a60451415e26dee896d2a7af22b.camel@intel.com \
    --to=spdk@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).