On Nov 3, 2019 9:00 AM, Or Gerlitz <gerlitz.or(a)gmail.com> wrote:
On Thu, Oct 31, 2019 at 8:54 PM Walker, Benjamin
<benjamin.walker(a)intel.com> wrote:

> Here's the patch at the top of the series:
> https://review.gerrithub.io/c/spdk/spdk/+/471752

> Zero copy is getting enabled on the socket and I do see completion
> notifications, but it's always doing a deferred copy. If there was some
> description somewhere of what causes the kernel to end up doing a deferred copy
> instead of page pinning that would be really useful.

the patch you pointed out doesn't change lib/nvmf/tcp.c only the sock code..
can you also refer to the patch that change nvmf


The patches are all in a series with the one I linked at the end. They show in the "relation chain" section of Gerrit. You can click the "Download" button in Gerrit for the patch I linked and it will give you a git-fetch command that grabs the whole series.