* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 9:11 [PATCH 6.1 00/86] 6.1.104-rc2 review Greg Kroah-Hartman
@ 2024-08-08 10:33 ` Salvatore Bonaccorso
2024-08-10 5:02 ` Salvatore Bonaccorso
2024-08-08 11:03 ` Miguel Ojeda
` (9 subsequent siblings)
10 siblings, 1 reply; 19+ messages in thread
From: Salvatore Bonaccorso @ 2024-08-08 10:33 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
Hi Greg,
On Thu, Aug 08, 2024 at 11:11:49AM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
Sorry for bothering you again with it (see previous comment on
6.1.103, respectively 6.1.104-rc1): bpftool still would fail to
compile:
gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o
prog.c: In function ‘load_with_options’:
prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]
1710 | err = create_and_mount_bpffs_dir(pinmaps);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool
/bin/ld: prog.o: in function `load_with_options':
prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
/bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:216: bpftool] Error 1
make: *** [Makefile:113: bpftool] Error 2
Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In
fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit
adding call to create_and_mount_bpffs_dir:
$ git grep create_and_mount_bpffs_dir
tools/bpf/bpftool/prog.c: err = create_and_mount_bpffs_dir(pinmaps);
Regards,
Salvatore
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 10:33 ` Salvatore Bonaccorso
@ 2024-08-10 5:02 ` Salvatore Bonaccorso
2024-08-10 21:36 ` Quentin Monnet
0 siblings, 1 reply; 19+ messages in thread
From: Salvatore Bonaccorso @ 2024-08-10 5:02 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Hardik Garg, Akemi Yagi, bpf, Sahil Siddiq, Andrii Nakryiko,
Tao Chen, Sasha Levin
Hi Greg,
[adding as well people involved in the original commit and the
backporting for 6.1.y branch]
On Thu, Aug 08, 2024 at 12:33:22PM +0200, Salvatore Bonaccorso wrote:
> Hi Greg,
>
> On Thu, Aug 08, 2024 at 11:11:49AM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.1.104 release.
> > There are 86 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> > Anything received after that time might be too late.
>
> Sorry for bothering you again with it (see previous comment on
> 6.1.103, respectively 6.1.104-rc1): bpftool still would fail to
> compile:
>
> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o
> prog.c: In function ‘load_with_options’:
> prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]
> 1710 | err = create_and_mount_bpffs_dir(pinmaps);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool
> /bin/ld: prog.o: in function `load_with_options':
> prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
> /bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
> collect2: error: ld returned 1 exit status
> make[1]: *** [Makefile:216: bpftool] Error 1
> make: *** [Makefile:113: bpftool] Error 2
>
> Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In
> fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit
> adding call to create_and_mount_bpffs_dir:
>
> $ git grep create_and_mount_bpffs_dir
> tools/bpf/bpftool/prog.c: err = create_and_mount_bpffs_dir(pinmaps);
Just one additional note, at least 478a535ae54a ("bpftool: Mount bpffs
on provided dir instead of parent dir") would be a reqisite where the
code was refactored introducing create_and_mount_bpffs_dir() (but
won't apply cleanly to 6.1.y). But are more requisites needed?
Should it be safest to just revert the breaking commit for the bpftool
build?
Regards,
Salvatore
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-10 5:02 ` Salvatore Bonaccorso
@ 2024-08-10 21:36 ` Quentin Monnet
2024-08-11 15:23 ` Greg Kroah-Hartman
0 siblings, 1 reply; 19+ messages in thread
From: Quentin Monnet @ 2024-08-10 21:36 UTC (permalink / raw)
To: Salvatore Bonaccorso, Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Hardik Garg, Akemi Yagi, bpf, Sahil Siddiq, Andrii Nakryiko,
Tao Chen, Sasha Levin
2024-08-10 07:02 UTC+0200 ~ Salvatore Bonaccorso <carnil@debian.org>
> Hi Greg,
>
> [adding as well people involved in the original commit and the
> backporting for 6.1.y branch]
>
> On Thu, Aug 08, 2024 at 12:33:22PM +0200, Salvatore Bonaccorso wrote:
>> Hi Greg,
>>
>> On Thu, Aug 08, 2024 at 11:11:49AM +0200, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 6.1.104 release.
>>> There are 86 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
>>> Anything received after that time might be too late.
>>
>> Sorry for bothering you again with it (see previous comment on
>> 6.1.103, respectively 6.1.104-rc1): bpftool still would fail to
>> compile:
>>
>> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o
>> prog.c: In function ‘load_with_options’:
>> prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]
>> 1710 | err = create_and_mount_bpffs_dir(pinmaps);
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool
>> /bin/ld: prog.o: in function `load_with_options':
>> prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
>> /bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
>> collect2: error: ld returned 1 exit status
>> make[1]: *** [Makefile:216: bpftool] Error 1
>> make: *** [Makefile:113: bpftool] Error 2
>>
>> Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In
>> fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit
>> adding call to create_and_mount_bpffs_dir:
>>
>> $ git grep create_and_mount_bpffs_dir
>> tools/bpf/bpftool/prog.c: err = create_and_mount_bpffs_dir(pinmaps);
>
> Just one additional note, at least 478a535ae54a ("bpftool: Mount bpffs
> on provided dir instead of parent dir") would be a reqisite where the
> code was refactored introducing create_and_mount_bpffs_dir() (but
> won't apply cleanly to 6.1.y). But are more requisites needed?
>
> Should it be safest to just revert the breaking commit for the bpftool
> build?
>
> Regards,
> Salvatore
>
Hi,
You should be able to fix the build by first cherry-picking commit
2a36c26fe3b8 ("bpftool: Support bpffs mountpoint as pin path for prog
loadall"), and then commit 478a535ae54a ("bpftool: Mount bpffs on
provided dir instead of parent dir") as you figured. Both commits have a
minor conflict on tools/bpf/bpftool/struct_ops.c, which should be
addressed by discarding the relevant hunk (for both commit).
Alternatively, it's also fine to revert the breaking commit. It's a
quality of life improvement without which users may have to manually
mount the bpffs at the location they want to pin their maps when loading
multiple BPF programs with "bpftool prog loadall", in the unlikely event
they're not using /sys/kernel/bpf, prior to running the bpftool command.
It's not in use during the kernel build process or for the BPF
selftests, so not necessary on stable branches.
I hope this helps,
Quentin
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-10 21:36 ` Quentin Monnet
@ 2024-08-11 15:23 ` Greg Kroah-Hartman
0 siblings, 0 replies; 19+ messages in thread
From: Greg Kroah-Hartman @ 2024-08-11 15:23 UTC (permalink / raw)
To: Quentin Monnet
Cc: Salvatore Bonaccorso, stable, patches, linux-kernel, torvalds,
akpm, linux, shuah, patches, lkft-triage, pavel, jonathanh,
f.fainelli, sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
broonie, Hardik Garg, Akemi Yagi, bpf, Sahil Siddiq,
Andrii Nakryiko, Tao Chen, Sasha Levin
On Sat, Aug 10, 2024 at 10:36:20PM +0100, Quentin Monnet wrote:
> 2024-08-10 07:02 UTC+0200 ~ Salvatore Bonaccorso <carnil@debian.org>
> > Hi Greg,
> >
> > [adding as well people involved in the original commit and the
> > backporting for 6.1.y branch]
> >
> > On Thu, Aug 08, 2024 at 12:33:22PM +0200, Salvatore Bonaccorso wrote:
> >> Hi Greg,
> >>
> >> On Thu, Aug 08, 2024 at 11:11:49AM +0200, Greg Kroah-Hartman wrote:
> >>> This is the start of the stable review cycle for the 6.1.104 release.
> >>> There are 86 patches in this series, all will be posted as a response
> >>> to this one. If anyone has any issues with these being applied, please
> >>> let me know.
> >>>
> >>> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> >>> Anything received after that time might be too late.
> >>
> >> Sorry for bothering you again with it (see previous comment on
> >> 6.1.103, respectively 6.1.104-rc1): bpftool still would fail to
> >> compile:
> >>
> >> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o
> >> prog.c: In function ‘load_with_options’:
> >> prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]
> >> 1710 | err = create_and_mount_bpffs_dir(pinmaps);
> >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool
> >> /bin/ld: prog.o: in function `load_with_options':
> >> prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
> >> /bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
> >> collect2: error: ld returned 1 exit status
> >> make[1]: *** [Makefile:216: bpftool] Error 1
> >> make: *** [Makefile:113: bpftool] Error 2
> >>
> >> Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In
> >> fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit
> >> adding call to create_and_mount_bpffs_dir:
> >>
> >> $ git grep create_and_mount_bpffs_dir
> >> tools/bpf/bpftool/prog.c: err = create_and_mount_bpffs_dir(pinmaps);
> >
> > Just one additional note, at least 478a535ae54a ("bpftool: Mount bpffs
> > on provided dir instead of parent dir") would be a reqisite where the
> > code was refactored introducing create_and_mount_bpffs_dir() (but
> > won't apply cleanly to 6.1.y). But are more requisites needed?
> >
> > Should it be safest to just revert the breaking commit for the bpftool
> > build?
> >
> > Regards,
> > Salvatore
> >
>
> Hi,
>
> You should be able to fix the build by first cherry-picking commit
> 2a36c26fe3b8 ("bpftool: Support bpffs mountpoint as pin path for prog
> loadall"),
That commit does not apply cleanly :(
I'll just go revert the original here, that makes it simpler overall.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 9:11 [PATCH 6.1 00/86] 6.1.104-rc2 review Greg Kroah-Hartman
2024-08-08 10:33 ` Salvatore Bonaccorso
@ 2024-08-08 11:03 ` Miguel Ojeda
2024-08-08 11:55 ` Ron Economos
` (8 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Miguel Ojeda @ 2024-08-08 11:03 UTC (permalink / raw)
To: gregkh
Cc: akpm, allen.lkml, broonie, conor, f.fainelli, jonathanh,
linux-kernel, linux, lkft-triage, patches, patches, pavel,
rwarsow, shuah, srw, stable, sudipm.mukherjee, torvalds,
Miguel Ojeda
On Thu, 08 Aug 2024 11:11:49 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
Boot-tested under QEMU for Rust x86_64:
Tested-by: Miguel Ojeda <ojeda@kernel.org>
Thanks!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 9:11 [PATCH 6.1 00/86] 6.1.104-rc2 review Greg Kroah-Hartman
2024-08-08 10:33 ` Salvatore Bonaccorso
2024-08-08 11:03 ` Miguel Ojeda
@ 2024-08-08 11:55 ` Ron Economos
2024-08-08 14:43 ` Ron Economos
2024-08-08 13:35 ` ChromeOS Kernel Stable Merge
` (7 subsequent siblings)
10 siblings, 1 reply; 19+ messages in thread
From: Ron Economos @ 2024-08-08 11:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, broonie
On 8/8/24 2:11 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
I'm seeing a build failure.
sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct
hda_codec_ops’ has no member named ‘suspend’
273 | .suspend = cx_auto_suspend,
| ^~~~~~~
sound/pci/hda/patch_conexant.c:273:20: error: initialization of ‘void
(*)(struct hda_codec *, hda_nid_t, unsigned int)’ {aka ‘void (*)(struct
hda_codec *, short unsigned int, unsigned int)’} from incompatible
pointer type ‘int (*)(struct hda_codec *)’
[-Werror=incompatible-pointer-types]
273 | .suspend = cx_auto_suspend,
| ^~~~~~~~~~~~~~~
sound/pci/hda/patch_conexant.c:273:20: note: (near initialization for
‘cx_auto_patch_ops.set_power_state’)
sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct
hda_codec_ops’ has no member named ‘check_power_status’; did you mean
‘set_power_state’?
274 | .check_power_status = snd_hda_gen_check_power_status,
| ^~~~~~~~~~~~~~~~~~
| set_power_state
sound/pci/hda/patch_conexant.c:274:31: error:
‘snd_hda_gen_check_power_status’ undeclared here (not in a function);
did you mean ‘snd_hda_check_power_state’?
274 | .check_power_status = snd_hda_gen_check_power_status,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| snd_hda_check_power_state
This is triggered because my config does not include CONFIG_PM. But the
error is caused by upstream patch
9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce
CONFIG_PM dependencies" being missing. This patch removes the #ifdef
CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not set,
some structure members are missing and the the build fails.
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 11:55 ` Ron Economos
@ 2024-08-08 14:43 ` Ron Economos
2024-08-08 16:45 ` Ron Economos
0 siblings, 1 reply; 19+ messages in thread
From: Ron Economos @ 2024-08-08 14:43 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, broonie
On 8/8/24 4:55 AM, Ron Economos wrote:
> On 8/8/24 2:11 AM, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 6.1.104 release.
>> There are 86 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
>>
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>> linux-6.1.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>>
> I'm seeing a build failure.
>
> sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct
> hda_codec_ops’ has no member named ‘suspend’
> 273 | .suspend = cx_auto_suspend,
> | ^~~~~~~
> sound/pci/hda/patch_conexant.c:273:20: error: initialization of ‘void
> (*)(struct hda_codec *, hda_nid_t, unsigned int)’ {aka ‘void
> (*)(struct hda_codec *, short unsigned int, unsigned int)’} from
> incompatible pointer type ‘int (*)(struct hda_codec *)’
> [-Werror=incompatible-pointer-types]
> 273 | .suspend = cx_auto_suspend,
> | ^~~~~~~~~~~~~~~
> sound/pci/hda/patch_conexant.c:273:20: note: (near initialization for
> ‘cx_auto_patch_ops.set_power_state’)
> sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct
> hda_codec_ops’ has no member named ‘check_power_status’; did you mean
> ‘set_power_state’?
> 274 | .check_power_status = snd_hda_gen_check_power_status,
> | ^~~~~~~~~~~~~~~~~~
> | set_power_state
> sound/pci/hda/patch_conexant.c:274:31: error:
> ‘snd_hda_gen_check_power_status’ undeclared here (not in a function);
> did you mean ‘snd_hda_check_power_state’?
> 274 | .check_power_status = snd_hda_gen_check_power_status,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | snd_hda_check_power_state
>
> This is triggered because my config does not include CONFIG_PM. But
> the error is caused by upstream patch
> 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce
> CONFIG_PM dependencies" being missing. This patch removes the #ifdef
> CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not set,
> some structure members are missing and the the build fails.
>
>
Same failure occurs in 6.6.45-rc1 if CONFIG_PM is not set.
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 14:43 ` Ron Economos
@ 2024-08-08 16:45 ` Ron Economos
2024-08-11 10:14 ` Greg Kroah-Hartman
0 siblings, 1 reply; 19+ messages in thread
From: Ron Economos @ 2024-08-08 16:45 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, broonie
On 8/8/24 7:43 AM, Ron Economos wrote:
> On 8/8/24 4:55 AM, Ron Economos wrote:
>> On 8/8/24 2:11 AM, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 6.1.104 release.
>>> There are 86 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
>>>
>>> or in the git tree and branch at:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>>> linux-6.1.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>> I'm seeing a build failure.
>>
>> sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct
>> hda_codec_ops’ has no member named ‘suspend’
>> 273 | .suspend = cx_auto_suspend,
>> | ^~~~~~~
>> sound/pci/hda/patch_conexant.c:273:20: error: initialization of ‘void
>> (*)(struct hda_codec *, hda_nid_t, unsigned int)’ {aka ‘void
>> (*)(struct hda_codec *, short unsigned int, unsigned int)’} from
>> incompatible pointer type ‘int (*)(struct hda_codec *)’
>> [-Werror=incompatible-pointer-types]
>> 273 | .suspend = cx_auto_suspend,
>> | ^~~~~~~~~~~~~~~
>> sound/pci/hda/patch_conexant.c:273:20: note: (near initialization for
>> ‘cx_auto_patch_ops.set_power_state’)
>> sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct
>> hda_codec_ops’ has no member named ‘check_power_status’; did you mean
>> ‘set_power_state’?
>> 274 | .check_power_status = snd_hda_gen_check_power_status,
>> | ^~~~~~~~~~~~~~~~~~
>> | set_power_state
>> sound/pci/hda/patch_conexant.c:274:31: error:
>> ‘snd_hda_gen_check_power_status’ undeclared here (not in a function);
>> did you mean ‘snd_hda_check_power_state’?
>> 274 | .check_power_status = snd_hda_gen_check_power_status,
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> | snd_hda_check_power_state
>>
>> This is triggered because my config does not include CONFIG_PM. But
>> the error is caused by upstream patch
>> 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce
>> CONFIG_PM dependencies" being missing. This patch removes the #ifdef
>> CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not set,
>> some structure members are missing and the the build fails.
>>
>>
> Same failure occurs in 6.6.45-rc1 if CONFIG_PM is not set.
>
>
Note: Both upstream 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda:
codec: Reduce CONFIG_PM dependencies" and
6c8fd3499423fc3ebb735f32d4a52bc5825f6301 "ALSA: hda: generic: Reduce
CONFIG_PM dependencies" are required to fix the build if CONFIG_PM is
not set.
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 16:45 ` Ron Economos
@ 2024-08-11 10:14 ` Greg Kroah-Hartman
0 siblings, 0 replies; 19+ messages in thread
From: Greg Kroah-Hartman @ 2024-08-11 10:14 UTC (permalink / raw)
To: Ron Economos
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
On Thu, Aug 08, 2024 at 09:45:57AM -0700, Ron Economos wrote:
> On 8/8/24 7:43 AM, Ron Economos wrote:
> > On 8/8/24 4:55 AM, Ron Economos wrote:
> > > On 8/8/24 2:11 AM, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 6.1.104 release.
> > > > There are 86 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> > > >
> > > > or in the git tree and branch at:
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > > > linux-6.1.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > > >
> > > I'm seeing a build failure.
> > >
> > > sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct
> > > hda_codec_ops’ has no member named ‘suspend’
> > > 273 | .suspend = cx_auto_suspend,
> > > | ^~~~~~~
> > > sound/pci/hda/patch_conexant.c:273:20: error: initialization of
> > > ‘void (*)(struct hda_codec *, hda_nid_t, unsigned int)’ {aka ‘void
> > > (*)(struct hda_codec *, short unsigned int, unsigned int)’} from
> > > incompatible pointer type ‘int (*)(struct hda_codec *)’
> > > [-Werror=incompatible-pointer-types]
> > > 273 | .suspend = cx_auto_suspend,
> > > | ^~~~~~~~~~~~~~~
> > > sound/pci/hda/patch_conexant.c:273:20: note: (near initialization
> > > for ‘cx_auto_patch_ops.set_power_state’)
> > > sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct
> > > hda_codec_ops’ has no member named ‘check_power_status’; did you
> > > mean ‘set_power_state’?
> > > 274 | .check_power_status = snd_hda_gen_check_power_status,
> > > | ^~~~~~~~~~~~~~~~~~
> > > | set_power_state
> > > sound/pci/hda/patch_conexant.c:274:31: error:
> > > ‘snd_hda_gen_check_power_status’ undeclared here (not in a
> > > function); did you mean ‘snd_hda_check_power_state’?
> > > 274 | .check_power_status = snd_hda_gen_check_power_status,
> > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > | snd_hda_check_power_state
> > >
> > > This is triggered because my config does not include CONFIG_PM. But
> > > the error is caused by upstream patch
> > > 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce
> > > CONFIG_PM dependencies" being missing. This patch removes the #ifdef
> > > CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not
> > > set, some structure members are missing and the the build fails.
> > >
> > >
> > Same failure occurs in 6.6.45-rc1 if CONFIG_PM is not set.
> >
> >
> Note: Both upstream 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda:
> codec: Reduce CONFIG_PM dependencies" and
> 6c8fd3499423fc3ebb735f32d4a52bc5825f6301 "ALSA: hda: generic: Reduce
> CONFIG_PM dependencies" are required to fix the build if CONFIG_PM is not
> set.
thanks, I have fixed this all now up.
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 9:11 [PATCH 6.1 00/86] 6.1.104-rc2 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2024-08-08 11:55 ` Ron Economos
@ 2024-08-08 13:35 ` ChromeOS Kernel Stable Merge
2024-08-08 16:58 ` Pavel Machek
` (6 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: ChromeOS Kernel Stable Merge @ 2024-08-08 13:35 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, chromeos-kernel-stable-merge, Greg Kroah-Hartman, patches,
linux-kernel, torvalds, akpm, linux, shuah, patches, lkft-triage,
pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw, rwarsow,
conor, allen.lkml, broonie
Hello,
This rc kernel passed ChromeOS CQ tests:
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/5766148/2?tab=checks
Thanks,
Tested-by: ChromeOS CQ Test <chromeos-kernel-stable-merge@google.com>
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 9:11 [PATCH 6.1 00/86] 6.1.104-rc2 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2024-08-08 13:35 ` ChromeOS Kernel Stable Merge
@ 2024-08-08 16:58 ` Pavel Machek
2024-08-08 17:03 ` Anders Roxell
` (5 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Pavel Machek @ 2024-08-08 16:58 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Hi!
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-6.1.y
Tested-by: Pavel Machek (CIP) <pavel@denx.de>
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 9:11 [PATCH 6.1 00/86] 6.1.104-rc2 review Greg Kroah-Hartman
` (4 preceding siblings ...)
2024-08-08 16:58 ` Pavel Machek
@ 2024-08-08 17:03 ` Anders Roxell
2024-08-09 5:46 ` Peter Schneider
` (4 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Anders Roxell @ 2024-08-08 17:03 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
On Thu, 8 Aug 2024 at 11:11, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Results from Linaro's test farm.
No regressions on arm64, arm, x86_64, and i386.
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
## Build
* kernel: 6.1.104-rc2
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git commit: 54b8e3a13b43747af658936db1fa59a365d52997
* git describe: v6.1.103-87-g54b8e3a13b43
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.103-87-g54b8e3a13b43
## Test Regressions (compared to v6.1.102-441-gdbbffaaee188)
## Metric Regressions (compared to v6.1.102-441-gdbbffaaee188)
## Test Fixes (compared to v6.1.102-441-gdbbffaaee188)
## Metric Fixes (compared to v6.1.102-441-gdbbffaaee188)
## Test result summary
total: 219072, pass: 188702, fail: 2594, skip: 27408, xfail: 368
## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 135 total, 135 passed, 0 failed
* arm64: 38 total, 38 passed, 0 failed
* i386: 28 total, 28 passed, 0 failed
* mips: 26 total, 25 passed, 1 failed
* parisc: 4 total, 3 passed, 1 failed
* powerpc: 36 total, 35 passed, 1 failed
* riscv: 11 total, 11 passed, 0 failed
* s390: 14 total, 12 passed, 2 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 7 total, 7 passed, 0 failed
* x86_64: 33 total, 33 passed, 0 failed
## Test suites summary
* boot
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-efivarfs
* kselftest-exec
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-kcmp
* kselftest-kvm
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-mincore
* kselftest-mqueue
* kselftest-net
* kselftest-net-mptcp
* kselftest-openat2
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timers
* kselftest-timesync-off
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user_events
* kselftest-vDSO
* kselftest-watchdog
* kselftest-x86
* kunit
* kvm-unit-tests
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-smoke
* ltp-smoketest
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 9:11 [PATCH 6.1 00/86] 6.1.104-rc2 review Greg Kroah-Hartman
` (5 preceding siblings ...)
2024-08-08 17:03 ` Anders Roxell
@ 2024-08-09 5:46 ` Peter Schneider
2024-08-09 10:51 ` Jon Hunter
` (3 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Peter Schneider @ 2024-08-09 5:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, broonie
Am 08.08.2024 um 11:11 schrieb Greg Kroah-Hartman:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
Builds, boots and works on my 2-socket Ivy Bridge Xeon E5-2697 v2 server. No dmesg
oddities or regressions found.
Tested-by: Peter Schneider <pschneider1968@googlemail.com>
Beste Grüße,
Peter Schneider
--
Climb the mountain not to plant your flag, but to embrace the challenge,
enjoy the air and behold the view. Climb it so you can see the world,
not so the world can see you. -- David McCullough Jr.
OpenPGP: 0xA3828BD796CCE11A8CADE8866E3A92C92C3FF244
Download: https://www.peters-netzplatz.de/download/pschneider1968_pub.asc
https://keys.mailvelope.com/pks/lookup?op=get&search=pschneider1968@googlemail.com
https://keys.mailvelope.com/pks/lookup?op=get&search=pschneider1968@gmail.com
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 9:11 [PATCH 6.1 00/86] 6.1.104-rc2 review Greg Kroah-Hartman
` (6 preceding siblings ...)
2024-08-09 5:46 ` Peter Schneider
@ 2024-08-09 10:51 ` Jon Hunter
2024-08-09 11:58 ` Shreeya Patel
` (2 subsequent siblings)
10 siblings, 0 replies; 19+ messages in thread
From: Jon Hunter @ 2024-08-09 10:51 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Greg Kroah-Hartman, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
linux-tegra, stable
On Thu, 08 Aug 2024 11:11:49 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
All tests passing for Tegra ...
Test results for stable-v6.1:
10 builds: 10 pass, 0 fail
26 boots: 26 pass, 0 fail
116 tests: 116 pass, 0 fail
Linux version: 6.1.104-rc2-g54b8e3a13b43
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Jon
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 9:11 [PATCH 6.1 00/86] 6.1.104-rc2 review Greg Kroah-Hartman
` (7 preceding siblings ...)
2024-08-09 10:51 ` Jon Hunter
@ 2024-08-09 11:58 ` Shreeya Patel
2024-08-09 18:35 ` Florian Fainelli
2024-08-12 21:49 ` Guenter Roeck
10 siblings, 0 replies; 19+ messages in thread
From: Shreeya Patel @ 2024-08-09 11:58 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Kernel CI - Regressions
---- On Thu, 08 Aug 2024 14:41:49 +0530 Greg Kroah-Hartman wrote ---
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
Date: 2024-08-07
## Build failures:
No **new** build failures seen for the stable-rc/linux-6.1.y commit head \o/
## Boot failures:
No **new** boot failures seen for the stable-rc/linux-6.1.y commit head \o/
Tested-by: kernelci.org bot <bot@kernelci.org>
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 9:11 [PATCH 6.1 00/86] 6.1.104-rc2 review Greg Kroah-Hartman
` (8 preceding siblings ...)
2024-08-09 11:58 ` Shreeya Patel
@ 2024-08-09 18:35 ` Florian Fainelli
2024-08-12 21:49 ` Guenter Roeck
10 siblings, 0 replies; 19+ messages in thread
From: Florian Fainelli @ 2024-08-09 18:35 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw, rwarsow,
conor, allen.lkml, broonie
On 8/8/24 02:11, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-08 9:11 [PATCH 6.1 00/86] 6.1.104-rc2 review Greg Kroah-Hartman
` (9 preceding siblings ...)
2024-08-09 18:35 ` Florian Fainelli
@ 2024-08-12 21:49 ` Guenter Roeck
2024-08-13 2:44 ` Guenter Roeck
10 siblings, 1 reply; 19+ messages in thread
From: Guenter Roeck @ 2024-08-12 21:49 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, broonie
Hi,
On 8/8/24 02:11, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
...
> Naohiro Aota <naohiro.aota@wdc.com>
> btrfs: zoned: fix zone_unusable accounting on making block group read-write again
>
This patch results in a variety of problems with the parisc64 qemu emulation.
Some examples from various test runs:
[ 10.527204] alg: akcipher: test 1 failed for rsa-generic, err=-22
[ 10.529743] alg: self-tests for rsa using rsa-generic failed (rc=-22)
[ 10.529905] ------------[ cut here ]------------
[ 10.530276] alg: self-tests for rsa using rsa-generic failed (rc=-22)
[ 10.530732] WARNING: CPU: 0 PID: 50 at crypto/testmgr.c:5907 alg_test+0x618/0x688
[ 7.420056] ==================================================================
[ 7.420507] BUG: KFENCE: invalid read in walk_stackframe.isra.0+0xb4/0x138
[ 7.420507]
[ 7.420827] Invalid read at 0x0000000042f07000:
[ 7.421037] walk_stackframe.isra.0+0xb4/0x138
[ 7.421204] arch_stack_walk+0x38/0x50
[ 7.421338] stack_trace_save_regs+0x58/0x70
[ 7.421498] kfence_report_error+0x14c/0x730
[ 7.421649] kfence_handle_page_fault+0x2c8/0x2d0
[ 7.421996] handle_interruption+0x9b0/0xb58
[ 7.422168] intr_check_sig+0x0/0x3c
[ 8.891194] =============================================================================
[ 8.891558] BUG sgpool-32 (Tainted: G B W N): Wrong object count. Counter is 3 but counted were 18
[ 0.403174] =============================================================================
[ 0.403568] BUG audit_buffer (Not tainted): Wrong object count. Counter is 1 but counted were 34
[ 0.505914] =============================================================================
[ 0.506258] BUG skbuff_head_cache (Tainted: G B ): Freechain corrupt
[ 2.831636] =============================================================================
[ 2.832144] BUG skbuff_head_cache (Tainted: G B ): Left Redzone overwritten
Reverting it fixes the problem.
Bisect log is attached for reference.
I tried to repeat the test with v6.1.105-rc1, but that fails to compile for parisc64.
/home/groeck/src/linux-stable/include/linux/slab.h:228: warning: "ARCH_KMALLOC_MINALIGN" redefined
228 | #define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN
This is due to commit 96423e23e05b ("parisc: fix a possible DMA corruption").
After reverting that patch I don't see the above problems anymore in v6.1.105-rc1,
so it looks like the btrfs patches in v6.1.105-rc1 may have fixed it (or maybe
there is another hidden bug in the parisc64 qemu emulation).
Guenter
---
# bad: [36790ef5e00b69ccb92817f95ba1928eea24eebb] Linux 6.1.104
# good: [48d525b0e4634c487cf46a41c1e2824e9ee258ce] Linux 6.1.103
git bisect start 'HEAD' 'v6.1.103'
# good: [d06daf0ad645d9225a3ff6958dd82e1f3988fa64] sched: act_ct: take care of padding in struct zones_ht_key
git bisect good d06daf0ad645d9225a3ff6958dd82e1f3988fa64
# good: [ed15fdf30736a255c0e4f5d0263e12cf6636fade] rust: SHADOW_CALL_STACK is incompatible with Rust
git bisect good ed15fdf30736a255c0e4f5d0263e12cf6636fade
# bad: [5670466033d14329aaa87e726a481a6c56892eff] drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()
git bisect bad 5670466033d14329aaa87e726a481a6c56892eff
# bad: [47ab33e1d6a796a82f9b7a70ed95c9649e92d7d2] mptcp: sched: check both directions for backup
git bisect bad 47ab33e1d6a796a82f9b7a70ed95c9649e92d7d2
# good: [8bb9cf2edf490e65678f2d57634ac763a778aeb6] HID: wacom: Modify pen IDs
git bisect good 8bb9cf2edf490e65678f2d57634ac763a778aeb6
# bad: [5db999fff545b924b24c9afd368ef5c17279b176] protect the fetch of ->fd[fd] in do_dup2() from mispredictions
git bisect bad 5db999fff545b924b24c9afd368ef5c17279b176
# bad: [36dac679722e5aa68c9efa822a38a5ea0c107342] btrfs: zoned: fix zone_unusable accounting on making block group read-
write again
git bisect bad 36dac679722e5aa68c9efa822a38a5ea0c107342
# first bad commit: [36dac679722e5aa68c9efa822a38a5ea0c107342] btrfs: zoned: fix zone_unusable accounting on making bloc
k group read-write again
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
2024-08-12 21:49 ` Guenter Roeck
@ 2024-08-13 2:44 ` Guenter Roeck
0 siblings, 0 replies; 19+ messages in thread
From: Guenter Roeck @ 2024-08-13 2:44 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, broonie
On 8/12/24 14:49, Guenter Roeck wrote:
> Hi,
>
> On 8/8/24 02:11, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 6.1.104 release.
>> There are 86 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
>> and the diffstat can be found below.
>>
> ...
>> Naohiro Aota <naohiro.aota@wdc.com>
>> btrfs: zoned: fix zone_unusable accounting on making block group read-write again
>>
>
> This patch results in a variety of problems with the parisc64 qemu emulation.
> Some examples from various test runs:
>
> [ 10.527204] alg: akcipher: test 1 failed for rsa-generic, err=-22
> [ 10.529743] alg: self-tests for rsa using rsa-generic failed (rc=-22)
> [ 10.529905] ------------[ cut here ]------------
> [ 10.530276] alg: self-tests for rsa using rsa-generic failed (rc=-22)
> [ 10.530732] WARNING: CPU: 0 PID: 50 at crypto/testmgr.c:5907 alg_test+0x618/0x688
>
> [ 7.420056] ==================================================================
> [ 7.420507] BUG: KFENCE: invalid read in walk_stackframe.isra.0+0xb4/0x138
> [ 7.420507]
> [ 7.420827] Invalid read at 0x0000000042f07000:
> [ 7.421037] walk_stackframe.isra.0+0xb4/0x138
> [ 7.421204] arch_stack_walk+0x38/0x50
> [ 7.421338] stack_trace_save_regs+0x58/0x70
> [ 7.421498] kfence_report_error+0x14c/0x730
> [ 7.421649] kfence_handle_page_fault+0x2c8/0x2d0
> [ 7.421996] handle_interruption+0x9b0/0xb58
> [ 7.422168] intr_check_sig+0x0/0x3c
>
> [ 8.891194] =============================================================================
> [ 8.891558] BUG sgpool-32 (Tainted: G B W N): Wrong object count. Counter is 3 but counted were 18
>
> [ 0.403174] =============================================================================
> [ 0.403568] BUG audit_buffer (Not tainted): Wrong object count. Counter is 1 but counted were 34
>
> [ 0.505914] =============================================================================
> [ 0.506258] BUG skbuff_head_cache (Tainted: G B ): Freechain corrupt
>
> [ 2.831636] =============================================================================
> [ 2.832144] BUG skbuff_head_cache (Tainted: G B ): Left Redzone overwritten
>
> Reverting it fixes the problem.
>
> Bisect log is attached for reference.
>
>
> I tried to repeat the test with v6.1.105-rc1, but that fails to compile for parisc64.
>
> /home/groeck/src/linux-stable/include/linux/slab.h:228: warning: "ARCH_KMALLOC_MINALIGN" redefined
> 228 | #define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN
>
> This is due to commit 96423e23e05b ("parisc: fix a possible DMA corruption").
> After reverting that patch I don't see the above problems anymore in v6.1.105-rc1,
> so it looks like the btrfs patches in v6.1.105-rc1 may have fixed it (or maybe
> there is another hidden bug in the parisc64 qemu emulation).
>
Oh, never mind. I did a reverse bisect on v6.1.105-rc1 (after fixing the build failure there),
and it points to an unrelated commit. Looks like another qemu emulation bug. Sorry for the noise.
Guenter
^ permalink raw reply [flat|nested] 19+ messages in thread