From: "Sylwester Nawrocki" <s.nawrocki@samsung.com>
To: "'Marek Szyprowski'" <m.szyprowski@samsung.com>,
<linux-samsung-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>
Cc: "'Krzysztof Kozlowski'" <krzk@kernel.org>,
"'Chanwoo Choi'" <cw00.choi@samsung.com>,
"'Peter Griffin'" <peter.griffin@linaro.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>,
"'Stephen Boyd'" <sboyd@kernel.org>,
"'Brian Masney'" <bmasney+clk@redhat.com>,
"'Jerome Brunet'" <jbrunet+clk@baylibre.com>,
"'Henrik Grimler'" <henrik@grimler.se>, <stable@vger.kernel.org>
Subject: RE: [PATCH v3 1/3] clk: samsung: exynos-audss: Propagate -EPROBE_DEFER from input clocks
Date: Mon, 2 Nov 2026 20:14:03 +0100 [thread overview]
Message-ID: <000001dd6afe$5302e900$f908bb00$@samsung.com> (raw)
In-Reply-To: <20261030075325.517182-2-m.szyprowski@samsung.com>
> -----Original Message-----
> From: Marek Szyprowski <m.szyprowski@samsung.com>
> Sent: piątek, 30 października 2026 08:53
> To: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>; Krzysztof Kozlowski
> <krzk@kernel.org>; Sylwester Nawrocki <s.nawrocki@samsung.com>; Chanwoo
> Choi <cw00.choi@samsung.com>; Peter Griffin <peter.griffin@linaro.org>; Alim
> Akhtar <alim.akhtar@samsung.com>; Stephen Boyd <sboyd@kernel.org>; Brian
> Masney <bmasney+clk@redhat.com>; Jerome Brunet
> <jbrunet+clk@baylibre.com>; Henrik Grimler <henrik@grimler.se>;
> stable@vger.kernel.org
> Subject: [PATCH v3 1/3] clk: samsung: exynos-audss: Propagate -EPROBE_DEFER
> from input clocks
>
> exynos_audss_clk_probe() fetches the optional pll_ref/pll_in/cdclk/
> sclk_audio/sclk_pcm_in input clocks with devm_clk_get() and only
> checks IS_ERR() before falling back to a default parent clock name.
> This means a transient -EPROBE_DEFER (e.g. because the clock provider
> behind "pll_in" has not registered its real clock yet) is silently
> treated the same as the clock simply not being present, so the
> mout_audss/mout_i2s muxes get permanently registered with the wrong
> parent name.
>
> Fix this by checking for -EPROBE_DEFER on each of these clocks right
> after fetching them, before anything is registered, and bailing out
> of probe so it gets retried once the real clocks are available.
>
> Fixes: 547f33509ccc ("clk: exynos-audss: allow input clocks to be specified in
> device tree")
> Cc: stable@vger.kernel.org
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
next prev parent reply other threads:[~2026-11-02 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20261030075333eucas1p21e27f19273b7e71c53d6ef620e52bf55@eucas1p2.samsung.com>
[not found] ` <20261030075325.517182-1-m.szyprowski@samsung.com>
2026-10-30 7:53 ` [PATCH v3 1/3] clk: samsung: exynos-audss: Propagate -EPROBE_DEFER from input clocks Marek Szyprowski
2026-11-02 19:14 ` Sylwester Nawrocki [this message]
2026-10-30 7:53 ` [PATCH v3 2/3] clk: samsung: exynos5-subcmu: Use pm_runtime_get_sync() during probe Marek Szyprowski
2026-11-02 19:14 ` Sylwester Nawrocki
2026-10-30 7:53 ` [PATCH v3 3/3] clk: samsung: exynos5-subcmu: Defer probe until power domains are available Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001dd6afe$5302e900$f908bb00$@samsung.com' \
--to=s.nawrocki@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=bmasney+clk@redhat.com \
--cc=cw00.choi@samsung.com \
--cc=henrik@grimler.se \
--cc=jbrunet+clk@baylibre.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox