From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Jonghwan Choi To: 'Jonghwan Choi' , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, 'Chen Gang' , 'Al Viro' References: In-reply-to: Subject: [PATCH 3.8-stable] kernel/audit_tree.c: tree will leak memory when failure occurs in audit_trim_trees() Date: Tue, 30 Apr 2013 17:44:01 +0900 Message-id: <007001ce457e$dcfff1c0$96ffd540$%choi@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: ko Sender: linux-kernel-owner@vger.kernel.org List-ID: This patch looks like it should be in the 3.8-stable tree, should we apply it? ------------------ From: "Chen Gang " commit 12b2f117f3bf738c1a00a6f64393f1953a740bd4 upstream audit_trim_trees() calls get_tree(). If a failure occurs we must call put_tree(). [akpm@linux-foundation.org: run put_tree() before mutex_lock() for small scalability improvement] Signed-off-by: Chen Gang Cc: Al Viro Cc: Eric Paris Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Jonghwan Choi --- kernel/audit_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c index 642a89c..a291aa2 100644 --- a/kernel/audit_tree.c +++ b/kernel/audit_tree.c @@ -617,9 +617,9 @@ void audit_trim_trees(void) } spin_unlock(&hash_lock); trim_marked(tree); - put_tree(tree); drop_collected_mounts(root_mnt); skip_it: + put_tree(tree); mutex_lock(&audit_filter_mutex); } list_del(&cursor); -- 1.7.9.5